linux-toradex.git/drivers/hid/hid-picolcd_core.c, branch v4.4.50

HID: picolcd: be more verbose when reporting report size error

2014-08-27T21:27:10+00:00

picolcd device is not expected to send any report with size larger than
64 bytes.

If this impossible event happens (sic!), print also a report ID to allow
for easier debugging.

Suggested-by: Bruno Prémont 
Signed-off-by: Jiri Kosina

HID: picolcd: sanity check report size in raw_event() callback

2014-08-27T07:14:39+00:00

The report passed to us from transport driver could potentially be
arbitrarily large, therefore we better sanity-check it so that raw_data
that we hold in picolcd_pending structure are always kept within proper
bounds.

Cc: stable@vger.kernel.org
Reported-by: Steven Vittitoe 
Signed-off-by: Jiri Kosina

HID: picolcd_core: validate output report details

2013-09-04T10:03:27+00:00

A HID device could send a malicious output report that would cause the
picolcd HID driver to trigger a NULL dereference during attr file writing.

[jkosina@suse.cz: changed

	report->maxfield < 1

to

	report->maxfield != 1

as suggested by Bruno].

CVE-2013-2899

Signed-off-by: Kees Cook 
Cc: stable@kernel.org
Reviewed-by: Bruno Prémont 
Acked-by: Bruno Prémont 
Signed-off-by: Jiri Kosina

HID: use hid_hw_request() instead of direct call to usbhid

2013-02-25T12:26:41+00:00

This allows the hid drivers to be independent from the transport layer.

The patch was constructed by replacing all occurences of
usbhid_submit_report() by its hid_hw_request() counterpart.
Then, drivers not requiring USB_HID anymore have their USB_HID
dependency cleaned in the Kconfig file.

Finally, few drivers still depends on USB_HID. Many of them
are requiring the io wait callback. They are found in the next patch.

Signed-off-by: Benjamin Tissoires 
Reviewed-by: Mika Westerberg 

For the sensor-hub part:
Tested-by: Mika Westerberg 
Signed-off-by: Jiri Kosina

HID: Use module_hid_driver macro

2013-01-03T09:27:31+00:00

Use the new module_hid_driver macro in all HID drivers that have
a simple register/unregister init/exit.

This also converts the hid drivers that test for a failure of
hid_register_driver() and report the failure. Using module_hid_driver
in those drivers removes the failure message.

Signed-off-by: H Hartley Sweeten 
Signed-off-by: Jiri Kosina

HID: picolcd_core: Remove setting hdev->claimed before calling hid_hw_start()

2012-09-19T11:57:03+00:00

Current implementation of hid_hw_start() allows connect_mask to be 0.
Setting hdev->claimed = HID_CLAIMED_INPUT before calling hid_hw_start() is not
necessary. Remove it.

Signed-off-by: Axel Lin 
Acked-By: Bruno Prémont 
Signed-off-by: Jiri Kosina

HID: picoLCD: drop version check during probe

2012-09-19T11:43:51+00:00

Commit 4ea5454203d991ec85264f64f89ca8855fce69b0
[HID: Fix race condition between driver core and ll-driver] introduced
new locking around probe/remove functions that prevents any report/reply
from hardware to reach driver until it returned from probe.

As such, the ask-reply way to checking picoLCD firmware version during
probe is bound to timeout and let probe fail.

Drop the check to let driver successfully probe again (until locking issues
are resolved allowing to reinstate the check).

Signed-off-by: Bruno Prémont 
Signed-off-by: Jiri Kosina

HID: picoLCD: use proper device as input_dev parent

2012-09-05T09:48:08+00:00

Signed-off-by: Bruno Prémont 
Signed-off-by: Jiri Kosina

HID: picoLCD: Add support for CIR

2012-09-05T09:48:07+00:00

Implement support for picoLCD's CIR header using RC_CORE for decoding
the IR event stream.

Signed-off-by: Bruno Prémont 
Signed-off-by: Jiri Kosina

HID: picoLCD: prevent NULL pointer dereferences

2012-09-05T09:48:06+00:00

Driver code expects to get access to struct picolcd_data from hiddev
and is not prepared to find a NULL pointer there. Most prominent
candidate to trip on it is picolcd_fb_deferred_io().
Delay removing struct picolcd_data from hiddev until all sub-devices
have been unregistered.

Signed-off-by: Bruno Prémont 
Signed-off-by: Jiri Kosina