linux-toradex.git/drivers/hid/hid-picolcd_core.c, branch v6.14-rc2

Merge tag 'backlight-next-6.10' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight

2024-05-22T17:45:12+00:00

Pull backlight updates from Lee Jones:
 "Fix-ups:
   - FB Backlight interaction overhaul
   - Remove superfluous code and simplify overall
   - Constify various structs and struct attributes

  Bug Fixes:
   - Repair LED flickering
   - Fix signedness bugs"

* tag 'backlight-next-6.10' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight: (42 commits)
  backlight: sky81452-backlight: Remove unnecessary call to of_node_get()
  backlight: mp3309c: Fix LEDs flickering in PWM mode
  backlight: otm3225a: Drop driver owner assignment
  backlight: lp8788: Drop support for platform data
  backlight: lcd: Make lcd_class constant
  backlight: Make backlight_class constant
  backlight: mp3309c: Fix signedness bug in mp3309c_parse_fwnode()
  const_structs.checkpatch: add lcd_ops
  fbdev: omap: lcd_ams_delta: Constify lcd_ops
  fbdev: imx: Constify lcd_ops
  fbdev: clps711x: Constify lcd_ops
  HID: picoLCD: Constify lcd_ops
  backlight: tdo24m: Constify lcd_ops
  backlight: platform_lcd: Constify lcd_ops
  backlight: otm3225a: Constify lcd_ops
  backlight: ltv350qv: Constify lcd_ops
  backlight: lms501kf03: Constify lcd_ops
  backlight: lms283gf05: Constify lcd_ops
  backlight: l4f00242t03: Constify lcd_ops
  backlight: jornada720_lcd: Constify lcd_ops
  ...

HID: hid-picolcd*: Convert sprintf() family to sysfs_emit() family

2024-04-03T11:42:04+00:00

Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

sprintf() and scnprintf() will be converted as well if they have.

Generally, this patch is generated by
make coccicheck M= MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci

No functional change intended

CC: Christophe JAILLET 
CC: "Bruno Prémont" 
CC: Jiri Kosina 
CC: Benjamin Tissoires 
CC: linux-input@vger.kernel.org
Signed-off-by: Li Zhijian 
Signed-off-by: Jiri Kosina

hid: hid-picolcd: Fix initialization order

2024-03-28T10:08:57+00:00

For drivers that support backlight, LCD and fbdev devices, fbdev has
to be initialized last. See documentation for struct fbinfo.bl_dev.

Signed-off-by: Thomas Zimmermann 
Cc: Bruno Prémont 
Reviewed-by: Javier Martinez Canillas 
Link: https://lore.kernel.org/r/20240305162425.23845-4-tzimmermann@suse.de
Signed-off-by: Lee Jones

HID: hid-picolcd_core: Remove unused variable 'ret'

2021-04-07T16:46:20+00:00

Fixes the following W=1 kernel build warning(s):

 drivers/hid/hid-picolcd_core.c: In function ‘picolcd_raw_event’:
 drivers/hid/hid-picolcd_core.c:332:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]

Cc: "Bruno Prémont" 
Cc: Jiri Kosina 
Cc: Benjamin Tissoires 
Cc: "L. Vinyard, Jr" 
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones 
Signed-off-by: Benjamin Tissoires

HID: do not call hid_set_drvdata(hdev, NULL) in drivers

2019-08-22T15:11:58+00:00

This is a common pattern in the HID drivers to reset the drvdata. Some
do it properly, some do it only in case of failure.

But, this is actually already handled by driver core, so there is no need
to do it manually.

[for hid-sensor-hub.c]
Acked-by: Srinivas Pandruvada 
[For hid-picolcd_core.c]
Acked-by: Bruno Prémont 
Signed-off-by: Benjamin Tissoires

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 265

2019-06-05T15:30:28+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license as published by
  the free software foundation version 2 of the license this driver is
  distributed in the hope that it will be useful but without any
  warranty without even the implied warranty of merchantability or
  fitness for a particular purpose see the gnu general public license
  for more details you should have received a copy of the gnu general
  public license along with this software if not see http www gnu org
  licenses

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 8 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Richard Fontana 
Reviewed-by: Allison Randal 
Reviewed-by: Alexios Zavras 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190529141333.861653206@linutronix.de
Signed-off-by: Greg Kroah-Hartman

HID: picolcd: Convert to use sysfs_streq()

2019-03-27T13:14:29+00:00

Convert to use sysfs_streq() instead of custom approach.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Jiri Kosina

HID: picolcd: be more verbose when reporting report size error

2014-08-27T21:27:10+00:00

picolcd device is not expected to send any report with size larger than
64 bytes.

If this impossible event happens (sic!), print also a report ID to allow
for easier debugging.

Suggested-by: Bruno Prémont 
Signed-off-by: Jiri Kosina

HID: picolcd: sanity check report size in raw_event() callback

2014-08-27T07:14:39+00:00

The report passed to us from transport driver could potentially be
arbitrarily large, therefore we better sanity-check it so that raw_data
that we hold in picolcd_pending structure are always kept within proper
bounds.

Cc: stable@vger.kernel.org
Reported-by: Steven Vittitoe 
Signed-off-by: Jiri Kosina

HID: picolcd_core: validate output report details

2013-09-04T10:03:27+00:00

A HID device could send a malicious output report that would cause the
picolcd HID driver to trigger a NULL dereference during attr file writing.

[jkosina@suse.cz: changed

	report->maxfield < 1

to

	report->maxfield != 1

as suggested by Bruno].

CVE-2013-2899

Signed-off-by: Kees Cook 
Cc: stable@kernel.org
Reviewed-by: Bruno Prémont 
Acked-by: Bruno Prémont 
Signed-off-by: Jiri Kosina