linux-toradex.git/drivers/hid/hid-picolcd_debugfs.c, branch v3.10.12

HID: use hid_hw_request() instead of direct call to usbhid

2013-02-25T12:26:41+00:00

This allows the hid drivers to be independent from the transport layer.

The patch was constructed by replacing all occurences of
usbhid_submit_report() by its hid_hw_request() counterpart.
Then, drivers not requiring USB_HID anymore have their USB_HID
dependency cleaned in the Kconfig file.

Finally, few drivers still depends on USB_HID. Many of them
are requiring the io wait callback. They are found in the next patch.

Signed-off-by: Benjamin Tissoires 
Reviewed-by: Mika Westerberg 

For the sensor-hub part:
Tested-by: Mika Westerberg 
Signed-off-by: Jiri Kosina

HID: picoLCD: optimize for inactive debugfs

2012-10-01T08:25:01+00:00

Matthieu CASTET adjusted picolcd_debug_out_report() to only operate when
there is an active listener on debugfs for events.

His change got lost while splitting hid_picolcd.c, restore it.

Signed-off-by: Bruno Prémont 
Signed-off-by: Jiri Kosina

HID: picoLCD: bounds check in dump_buff_as_hex()

2012-09-24T21:04:55+00:00

Make sure we keep enough space for terminating NUL character after last
newline. If we have too much data, replace last byte with '.'s to
make overflow visible.

Using hex_dump_to_buffer() is not interesting as it adds more overhead
and does not append the trailing linefeed.

Reported-by: Dan Carpenter 
Signed-off-by: Bruno Prémont 
Signed-off-by: Jiri Kosina

HID: picoLCD: fix dumping of IR_DATA report

2012-09-05T09:48:07+00:00

The first payload byte indicates how many IR data bytes are following, not
including itself. The IR data bytes appear in pairs as they represent a
series of 16bit intervals.

Signed-off-by: Bruno Prémont 
Signed-off-by: Jiri Kosina

HID: picoLCD: optimize for inactive debugfs

2012-09-05T09:48:07+00:00

Matthieu CASTET adjusted picolcd_debug_out_report() to only operate when
there is an active listener on debugfs for events.

Do the same on the more important picolcd_debug_raw_event() that is
called in interrupt context as opposed to picolcd_debug_out_report()
which happens in whichever context that sends reports to device.

Signed-off-by: Bruno Prémont 
Signed-off-by: Jiri Kosina

HID: picolcd: Add missing #include

2012-08-22T14:27:58+00:00

m68k/allmodconfig:

drivers/hid/hid-picolcd_debugfs.c: In function ‘picolcd_debug_reset_write’:
drivers/hid/hid-picolcd_debugfs.c:54: error: implicit declaration of function ‘copy_from_user’
drivers/hid/hid-picolcd_debugfs.c: In function ‘picolcd_debug_eeprom_read’:
drivers/hid/hid-picolcd_debugfs.c:112: error: implicit declaration of function ‘copy_to_user’

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Jiri Kosina

HID: picoLCD: satify some checkpatch warnings

2012-08-15T08:12:07+00:00

WARNING: static const char * array should probably be static const char * const
+static const char *error_codes[] = {

WARNING: min() should probably be min_t(size_t, 20, s)
+       raw_data[2] = min((size_t)20, s);

Note: the second min_t suggestion cannot be followed because GCC is not
smart enough to track constants through it and make
copy_from_user_overflow() check happy.

WARNING: min() should probably be min_t(u8, 20, raw_data[2])
+       if (copy_from_user(raw_data+3, u, min((u8)20, raw_data[2])))
                return -EFAULT;

Signed-off-by: Bruno Prémont 
Signed-off-by: Jiri Kosina

HID: picoLCD: split driver code

2012-08-15T08:08:57+00:00

In order to make code maintenance easier, split the vairous
functions into individial files (this removes a bunch of #ifdefs).

Signed-off-by: Bruno Prémont 
Signed-off-by: Jiri Kosina