linux-toradex.git/drivers/hid/hid-playstation.c, branch v6.3

Merge branch 'for-6.3/sony' into for-linus

2023-02-22T09:40:03+00:00

- enforce DS4 controllers to use hid-playstation (Roderick Colenbrander)
- various hid-playstation gyro fixes (Roderick Colenbrander)

HID: playstation: correct DualSense gyro bias handling.

2023-01-18T09:12:49+00:00

The bias for the gyroscope is not used correctly. The sensor bias
needs to be used in calculation of the 'sensivity' instead of being
an offset.

In practice this has little input on the values as the bias values
tends to be small (+/- 20).

Signed-off-by: Roderick Colenbrander 
Signed-off-by: Jiri Kosina

HID: playstation: correct DualShock4 gyro bias handling.

2023-01-18T09:12:20+00:00

The bias for the gyroscope is not used correctly. The sensor bias
needs to be used in calculation of the 'sensivity' instead of being
an offset.

In practice this has little input on the values as the bias values
tends to be small (+/- 20).

Signed-off-by: Roderick Colenbrander 
Signed-off-by: Jiri Kosina

HID: playstation: fix DualShock4 unreachable calibration code.

2023-01-18T09:11:48+00:00

Reported-by: Abaci Robot 
Reported-by: Jiapeng Chong 
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 
Signed-off-by: Roderick Colenbrander 
Signed-off-by: Jiri Kosina

HID: playstation: sanity check DualSense calibration data.

2023-01-18T09:10:58+00:00

Make sure calibration values are defined to prevent potential kernel
crashes. This fixes a hypothetical issue for virtual or clone devices
inspired by a similar fix for DS4.

Signed-off-by: Roderick Colenbrander 
Signed-off-by: Jiri Kosina

HID: playstation: sanity check DualShock4 calibration data.

2023-01-18T09:10:27+00:00

Some DualShock4 devices report invalid calibration data resulting
in kernel oopses due to division by zero during report handling.

The devices affected generally appear to be clone devices, which don't
implement all reports properly and don't populate proper calibration
data. The issue may have been seen on an official device with erased
calibration reports.

This patch prevents the crashes by essentially disabling calibration
when invalid values are detected.

Signed-off-by: Roderick Colenbrander 
Tested-by: Alain Carlucci 
Signed-off-by: Jiri Kosina

HID: playstation: fix free of uninialized pointer for DS4 in Bluetooth.

2022-12-19T12:18:02+00:00

The 'buf' variable is only used in the USB (if-path) and not in the Bluetooth
else-path. Since it is not set to NULL. this results in freeing an uninitialized
pointer. Since the else code-path doesn't need buf, just return 0.

Fixes: 2d77474a2392 ("HID: playstation: add DualShock4 bluetooth support.")
Signed-off-by: Roderick Colenbrander 
Signed-off-by: Benjamin Tissoires 
Link: https://lore.kernel.org/r/20221213044935.1775499-2-roderick.colenbrander@sony.com

HID: playstation: fix DualShock4 bluetooth CRC endian issue.

2022-11-16T23:46:13+00:00

The driver was by accident reading the CRC directly from a hardware
structure instead of using get_unaligned_le32.

Fixes: 2d77474a2392 ("HID: playstation: add DualShock4 bluetooth support.")
Reported-by: kernel test robot 
Signed-off-by: Roderick Colenbrander 
Signed-off-by: Jiri Kosina

HID: playstation: fix DualShock4 bluetooth memory corruption bug.

2022-11-16T23:46:13+00:00

The size of the output buffer used for output reports was not updated
to the larger size needed for Bluetooth. This ultimately resulted
in memory corruption of surrounding structures e.g. due to memsets.

Fixes: 2d77474a2392 ("HID: playstation: add DualShock4 bluetooth support.")
Reported-by: Benjamin Tissoires 
Signed-off-by: Roderick Colenbrander 
Signed-off-by: Jiri Kosina

HID: playstation: add DualShock4 dongle support.

2022-11-11T10:07:09+00:00

This patch adds support for the DualShock4 dongle in a very similar
way we contributed to hid-sony before.

The dongle is a USB to Bluetooth bridge and uses the same HID reports
as a USB device. It reports data through the DS4's main USB input
report independent on whether a Bluetooth controller is connected.
For this reason there is custom dongle report parsing code to
detect controller hotplug and kick of calibration work until we
are ready to process actual input reports.

The logic also incorporates a workaround needed for Steam in which
hid-playstation and Steam using hidraw can fight.

Signed-off-by: Roderick Colenbrander 
Signed-off-by: Jiri Kosina