linux-toradex.git/drivers/hid/hid-rmi.c, branch v4.17-rc7

HID: Fix hid_report_len usage

2018-02-16T12:30:56+00:00

Follow the change of return type u32 of hid_report_len,
fix all the types of variables those get the return value of
hid_report_len to u32, and all other code already uses u32.

Cc: stable@vger.kernel.org
Signed-off-by: Aaron Ma 
Signed-off-by: Jiri Kosina

HID: rmi: Support the Fujitsu R726 Pad dock using hid-rmi

2018-01-23T14:20:40+00:00

The Fujitsu R726 Pad has an optional USB keyboard dock which contains
a Synaptics touchpad. The dock identifies itself as a
Primax Rezel Tablet Keyboard.

Signed-off-by: Andrew Duggan 
Signed-off-by: Jiri Kosina

HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-19T08:03:50+00:00

The hid-rmi driver may handle non rmi devices on composite USB devices.
Callbacks need to make sure that the current device is a RMI device before
calling RMI specific functions. Most callbacks already have this check, but
this patch adds checks to the remaining callbacks.

Reported-by: Hendrik Langer 
Tested-by: Hendrik Langer 
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Andrew Duggan 
Signed-off-by: Jiri Kosina

HID: rmi: Make sure the HID device is opened on resume

2017-09-08T13:00:52+00:00

So it looks like that suspend/resume has actually always been broken on
hid-rmi. The fact it worked was a rather silly coincidence that was
relying on the HID device to already be opened upon resume. This means
that so long as anything was reading the /dev/input/eventX node for for
an RMI device, it would suspend and resume correctly. As well, if
nothing happened to be keeping the HID device away it would shut off,
then the RMI driver would get confused on resume when it stopped
responding and explode.

So, call hid_hw_open() in rmi_post_resume() so we make sure that the
device is alive before we try talking to it.

This fixes RMI device suspend/resume over HID.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=196851
[jkosina@suse.cz: removed useless hunk that was zero-initializing 'ret']
Signed-off-by: Lyude 
Cc: Andrew Duggan 
Cc: stable@vger.kernel.org
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: rmi: Support the Lenovo Thinkpad X1 Tablet dock using hid-rmi

2017-01-11T21:15:00+00:00

Signed-off-by: Andrew Duggan 
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: rmi: Make hid-rmi a transport driver for synaptics-rmi4

2017-01-11T21:15:00+00:00

The Synaptics RMI4 driver provides support for RMI4 devices. Instead of
duplicating the RMI4 processing code, make hid-rmi a transport driver
and register it with the Synaptics RMI4 core.

Signed-off-by: Andrew Duggan 
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: rmi: make transfer buffers DMA capable

2016-11-23T16:43:25+00:00

Kernel v4.9 strictly enforces DMA capable buffers, so we need to remove
buffers allocated on the stack.

Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: rmi: Check that the device is a RMI device in suspend and resume callbacks

2016-01-27T21:39:32+00:00

Commit 092563604217 ("HID: rmi: Disable scanning if the device is not a wake
source") introduced a regression for devices which use hid-rmi to handle
composite USB devices. The suspend or resume callbacks are not checking
that the device is a RMI device before calling rmi_read or rmi_write.
This results in dereferencing uninitialized variables on non RMI devices. This
patch checks that the RMI_DEVICE flag is set before sending RMI commands to the
device.

Reported-by: Rodrigo Gomes 
Signed-off-by: Andrew Duggan 
Signed-off-by: Jiri Kosina

HID: hid-input: allow input_configured callback return errors

2015-11-05T17:51:50+00:00

When configuring input device via input_configured callback we may
encounter errors (for example input_mt_init_slots() may fail). Instead
of continuing with half-initialized input device let's allow driver
indicate failures.

Signed-off-by: Jaikumar Ganesh 
Signed-off-by: Arve Hjønnevåg 
Reviewed-by: Benjamin Tissoires 
Reviewed-by: David Herrmann 
Acked-by: Nikolai Kondrashov 
Acked-by: Andrew Duggan 
Signed-off-by: Dmitry Torokhov 
Signed-off-by: Jiri Kosina

HID: rmi: Set F01 interrupt enable register when not set

2015-07-17T09:29:53+00:00

A firmware bug in some touchpads causes the F01 interrupt enable register
to be cleared on reset. This register controls which RMI functions generate
interrupts and when it is cleared, the touchpad stops reporting all data.
This patch looks for the cleared F01 control register and writes the
correct value based on interrupt mask computed while scanning the PDT.

Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=91102
Signed-off-by: Andrew Duggan 
Signed-off-by: Jiri Kosina