linux-toradex.git/drivers/hid/hid-rmi.c, branch v4.9.118

HID: Fix hid_report_len usage

2018-04-24T07:34:11+00:00

commit 3064a03b94e60388f0955fcc29f3e8a978d28f75 upstream.

Follow the change of return type u32 of hid_report_len,
fix all the types of variables those get the return value of
hid_report_len to u32, and all other code already uses u32.

Cc: stable@vger.kernel.org
Signed-off-by: Aaron Ma 
Signed-off-by: Jiri Kosina 
Signed-off-by: Greg Kroah-Hartman

HID: rmi: make transfer buffers DMA capable

2016-11-23T16:43:25+00:00

Kernel v4.9 strictly enforces DMA capable buffers, so we need to remove
buffers allocated on the stack.

Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: rmi: Check that the device is a RMI device in suspend and resume callbacks

2016-01-27T21:39:32+00:00

Commit 092563604217 ("HID: rmi: Disable scanning if the device is not a wake
source") introduced a regression for devices which use hid-rmi to handle
composite USB devices. The suspend or resume callbacks are not checking
that the device is a RMI device before calling rmi_read or rmi_write.
This results in dereferencing uninitialized variables on non RMI devices. This
patch checks that the RMI_DEVICE flag is set before sending RMI commands to the
device.

Reported-by: Rodrigo Gomes 
Signed-off-by: Andrew Duggan 
Signed-off-by: Jiri Kosina

HID: hid-input: allow input_configured callback return errors

2015-11-05T17:51:50+00:00

When configuring input device via input_configured callback we may
encounter errors (for example input_mt_init_slots() may fail). Instead
of continuing with half-initialized input device let's allow driver
indicate failures.

Signed-off-by: Jaikumar Ganesh 
Signed-off-by: Arve Hjønnevåg 
Reviewed-by: Benjamin Tissoires 
Reviewed-by: David Herrmann 
Acked-by: Nikolai Kondrashov 
Acked-by: Andrew Duggan 
Signed-off-by: Dmitry Torokhov 
Signed-off-by: Jiri Kosina

HID: rmi: Set F01 interrupt enable register when not set

2015-07-17T09:29:53+00:00

A firmware bug in some touchpads causes the F01 interrupt enable register
to be cleared on reset. This register controls which RMI functions generate
interrupts and when it is cleared, the touchpad stops reporting all data.
This patch looks for the cleared F01 control register and writes the
correct value based on interrupt mask computed while scanning the PDT.

Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=91102
Signed-off-by: Andrew Duggan 
Signed-off-by: Jiri Kosina

HID: rmi: Write updated F11 control registers after reset

2015-07-13T11:13:56+00:00

When a device is reset the values of control registers will be reset to
the defaults. This patch reapplies the control register values set for F11
by the driver.

Signed-off-by: Andrew Duggan 
Tested-by: Gabriele Mazzotta 
Signed-off-by: Jiri Kosina

HID: rmi: Disable scanning if the device is not a wake source

2015-07-09T12:24:51+00:00

Some touchpads are configured with firmware which continues to scan for
fingers at a minimal scan rate even after receiving the HID power sleep
command. This allows a finger touching the touchpad to genrate a wake
event. This patch ensures that scanning is disabled if the touchpad is
not a wake source and ensures scanning is enabled on resume.

Signed-off-by: Andrew Duggan 
Signed-off-by: Jiri Kosina

Merge branches 'for-4.2/i2c-hid', 'for-4.2/lenovo', 'for-4.2/plantronics', 'for-4.2/rmi', 'for-4.2/sensor-hub', 'for-4.2/sjoy', 'for-4.2/sony' and 'for-4.2/wacom' into for-linus

2015-06-22T14:23:43+00:00

Conflicts:
	drivers/hid/wacom_wac.c

HID: rmi: Disable populating F30 when the touchpad has physical buttons

2015-06-16T21:40:02+00:00

Physical buttons do not use F30 to report their state and in some cases the
data reported in F30 is incorrect and inconsistent with what is reported by
the HID descriptor. When physical buttons are present, ignore F30 and let
hid-input report buttons based on what is defined in the HID descriptor.

Signed-off-by: Andrew Duggan 
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: rmi: fix some harmless BIT() mistakes

2015-05-18T09:22:53+00:00

These defines are used like this:

	if (!(test_bit(RMI_STARTED, &hdata->flags)))

So the intent was to use bits 0, 1 and 2 but because of the extra BIT()
shifts we're actually using 1, 2 and 4.  It's harmless because it's done
consistently but static checkers will complain.

Fixes: 9fb6bf02e3ad ('HID: rmi: introduce RMI driver for Synaptics touchpads')
Signed-off-by: Dan Carpenter 
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina