linux-toradex.git/drivers/hid/hid-sony.c, branch v6.10-rc3

HID: sony: Remove usage of the deprecated ida_simple_xx() API

2024-04-16T07:50:37+00:00

ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

This is less verbose.

Signed-off-by: Christophe JAILLET 
Signed-off-by: Jiri Kosina

HID: sony: remove redundant assignment

2024-04-12T15:55:57+00:00

The variable ret is being assigned a value that is never read
afterwards. The assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/hid/hid-sony.c:2020:3: warning: Value stored to 'ret'
is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King 
Signed-off-by: Jiri Kosina

HID: sony: remove duplicate NULL check before calling usb_free_urb()

2023-10-05T10:50:35+00:00

usb_free_urb() does the NULL check itself, so there is no need to duplicate
it prior to calling.

Reported-by: kernel test robot 
Fixes: e1cd4004cde7c9 ("HID: sony: Fix a potential memory leak in sony_probe()")
Signed-off-by: Jiri Kosina

HID: sony: Fix a potential memory leak in sony_probe()

2023-09-04T09:14:22+00:00

If an error occurs after a successful usb_alloc_urb() call, usb_free_urb()
should be called.

Fixes: fb1a79a6b6e1 ("HID: sony: fix freeze when inserting ghlive ps3/wii dongles")
Signed-off-by: Christophe JAILLET 
Signed-off-by: Jiri Kosina

HID: sony: remove DualShock4 support.

2023-01-18T08:49:41+00:00

Now that hid-playstation provides DualShock4 support, remove
DualShock4 support from hid-sony as it is redundant.

Signed-off-by: Roderick Colenbrander 
Signed-off-by: Jiri Kosina

HID: sony: Fix unused function warning

2022-12-20T14:37:52+00:00

Compiling this driver without setting "CONFIG_SONY_FF" generates the
following warning:

	drivers/hid/hid-sony.c:2358:20: warning: unused function
	'sony_send_output_report' [-Wunused-function]
	static inline void sony_send_output_report(struct sony_sc *sc)
	                   ^
	1 warning generated.

Add the missing preprocessor check to fix it.

Signed-off-by: José Expósito 
Signed-off-by: Jiri Kosina

HID: sony: Fix double word in comments

2022-09-20T10:27:29+00:00

Remove the repeated word "not" in comments.

Signed-off-by: Shaomin Deng 
Signed-off-by: Benjamin Tissoires 
Link: https://lore.kernel.org/r/20220904154515.25143-1-dengshaomin@cdjrlc.com

HID: sony: fix error path in probe

2021-12-02T14:36:18+00:00

When the setup of the GHL fails, we are not calling hid_hw_stop().
This leads to the hidraw node not being released, meaning a crash
whenever somebody attempts to open the file.

Cc: stable@vger.kernel.org
Signed-off-by: Benjamin Tissoires 
Reviewed-by: Greg Kroah-Hartman 
Link: https://lore.kernel.org/r/20211202095334.14399-2-benjamin.tissoires@redhat.com

HID: check for valid USB device for many HID drivers

2021-12-02T14:36:18+00:00

Many HID drivers assume that the HID device assigned to them is a USB
device as that was the only way HID devices used to be able to be
created in Linux.  However, with the additional ways that HID devices
can be created for many different bus types, that is no longer true, so
properly check that we have a USB device associated with the HID device
before allowing a driver that makes this assumption to claim it.

Cc: Jiri Kosina 
Cc: Benjamin Tissoires 
Cc: Michael Zaidman 
Cc: Stefan Achatz 
Cc: Maxime Coquelin 
Cc: Alexandre Torgue 
Cc: linux-input@vger.kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman 
Tested-by: Benjamin Tissoires 
[bentiss: amended for thrustmater.c hunk to apply]
Signed-off-by: Benjamin Tissoires 
Link: https://lore.kernel.org/r/20211201183503.2373082-3-gregkh@linuxfoundation.org

Merge branch 'for-5.15/sony' into for-linus

2021-09-01T20:03:18+00:00

- Support for GHLive PS4 dongles