linux-toradex.git/drivers/hid/hid-uclogic-core.c, branch v6.9

HID: uclogic: Correct devm device reference for hidinput input_dev name

2023-08-24T13:57:57+00:00

Reference the HID device rather than the input device for the devm
allocation of the input_dev name. Referencing the input_dev would lead to a
use-after-free when the input_dev was unregistered and subsequently fires a
uevent that depends on the name. At the point of firing the uevent, the
name would be freed by devres management.

Use devm_kasprintf to simplify the logic for allocating memory and
formatting the input_dev name string.

Reported-by: syzbot+3a0ebe8a52b89c63739d@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/linux-input/ZOZIZCND+L0P1wJc@penguin/T/
Reported-by: Maxime Ripard 
Closes: https://lore.kernel.org/linux-input/ZOZIZCND+L0P1wJc@penguin/T/#m443f3dce92520f74b6cf6ffa8653f9c92643d4ae
Fixes: cce2dbdf258e ("HID: uclogic: name the input nodes based on their tool")
Suggested-by: Maxime Ripard 
Suggested-by: Dmitry Torokhov 
Signed-off-by: Rahul Rameshbabu 
Reviewed-by: Maxime Ripard 
Link: https://lore.kernel.org/r/20230824061308.222021-2-sergeantsagara@protonmail.com
Signed-off-by: Benjamin Tissoires

Merge branch 'for-6.3/uclogic' into for-linus

2023-02-22T09:41:39+00:00

UClogic assorted fixes and new devices support (José Expósito)

HID: uclogic: Add support for XP-PEN Deco Pro MW

2023-01-18T08:44:57+00:00

The XP-PEN Deco Pro MW is a UGEE v2 device with a frame with 8 buttons,
a bitmap dial and a mouse. Its pen has 2 buttons, supports tilt and
pressure.

It can be connected using a USB cable or, to use it in wireless mode,
using a USB Bluetooth dongle. When it is connected in wireless mode the
device battery is used to power it.

All the pieces to support it are already in place. Add its ID and
quirks in order to support the device.

Link: https://github.com/DIGImend/digimend-kernel-drivers/issues/622
Tested-by: Andreas Grosse 
Signed-off-by: José Expósito 
Signed-off-by: Jiri Kosina

HID: uclogic: Add support for XP-PEN Deco Pro SW

2023-01-18T08:44:57+00:00

The XP-PEN Deco Pro SW is a UGEE v2 device with a frame with 8 buttons,
a bitmap dial and a mouse; however, the UCLOGIC_MOUSE_FRAME_QUIRK is
required because it reports an incorrect frame type. Its pen has 2
buttons, supports tilt and pressure.

It can be connected using a USB cable or, to use it in wireless mode,
using a USB Bluetooth dongle. When it is connected in wireless mode the
device battery is used to power it.

All the pieces to support it are already in place. Add its ID and
quirks in order to support the device.

Signed-off-by: José Expósito 
Signed-off-by: Jiri Kosina

HID: uclogic: Handle wireless device reconnection

2023-01-18T08:44:57+00:00

UGEEv2 tablets with battery can be connected using a USB cable or a USB
Bluetooth dongle.

When the Bluetooth dongle is used, the connection to that tablet can be
lost because the tablet is out of the range of the receiver or because
it was switched off using the switch placed in the back of the tablet's
frame.

After losing connection, the tablet is able to reconnect automatically
and its firmware sends a special packet indicating that the device was
reconnected. In response to this packet, the tablet needs to receive the
same array of magic data it expects on probe to enable its interfaces.

This patch implements a generic mechanism to hook raw events and
schedule a work to perform any custom action.

Tested-by: Mia Kanashi 
Tested-by: Andreas Grosse 
Signed-off-by: José Expósito 
Signed-off-by: Jiri Kosina

HID: uclogic: Add frame type quirk

2023-01-18T08:44:57+00:00

The report descriptor used to get information about UGEE v2 devices is
incorrect in the XP-PEN Deco Pro SW. It indicates that the device frame
is of type UCLOGIC_PARAMS_FRAME_BUTTONS but the device has a frame of
type UCLOGIC_PARAMS_FRAME_MOUSE.

Here is the original report descriptor:

  0x0e 0x03 0xc8 0xb3 0x34 0x65 0x08 0x00 0xff 0x1f 0xd8 0x13 0x00 0x00
                                     ^ This byte should be 2

Add a quirk to be able to fix the reported frame type.

Tested-by: Mia Kanashi 
Tested-by: Andreas Grosse 
Signed-off-by: José Expósito 
Signed-off-by: Jiri Kosina

HID: uclogic: Add support for XP-PEN Deco 01 V2

2023-01-18T08:43:32+00:00

The XP-PEN Deco 01 V2 is a UGEE v2 device with a frame with 8 buttons.
Its pen has 2 buttons, supports tilt and pressure.

Add its ID in order to support the device.

Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/839
Tested-by: Mark Waddoups 
Signed-off-by: José Expósito 
Signed-off-by: Jiri Kosina

HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk

2022-11-21T17:35:01+00:00

Commit f7d8e387d9ae ("HID: uclogic: Switch to Digitizer usage for
styluses") changed the usage used in UCLogic from "Pen" to "Digitizer".

However, the IS_INPUT_APPLICATION() macro evaluates to false for
HID_DG_DIGITIZER causing issues with the XP-Pen Star G640 tablet.

Add the HID_QUIRK_HIDINPUT_FORCE quirk to bypass the
IS_INPUT_APPLICATION() check.

Reported-by: Torge Matthies 
Reported-by: Alexander Zhang 
Tested-by: Alexander Zhang 
Signed-off-by: José Expósito 
Signed-off-by: Jiri Kosina

HID: uclogic: Add support for Parblo A610 PRO

2022-08-25T08:26:31+00:00

The Parblo A610 PRO is a UGEE v2 device with a frame with 9 buttons
and a bitmap dial. Its pen has 2 buttons, supports tilt and pressure.

Add its ID in order to support the device.

Signed-off-by: José Expósito 
Signed-off-by: Jiri Kosina

HID: uclogic: Add support for XP-PEN Deco Pro S

2022-08-25T08:26:31+00:00

The XP-PEN Deco Pro S is a UGEE v2 device with a frame with 8 buttons,
a bitmap dial and a mouse. Its pen has 2 buttons, supports tilt and
pressure.

All the pieces to support it are already in place. Add its ID in order
to support the device.

The required Wireshark traces were captured by Jouke Witteveen.
For more information check [1].

Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/738  [1]
Tested-by: Jouke Witteveen 
Signed-off-by: José Expósito 
Signed-off-by: Jiri Kosina