linux-toradex.git/drivers/hid/hidraw.c, branch v3.4.2

Merge branch 'upstream' into for-linus

2011-10-25T07:59:04+00:00

Conflicts:
	drivers/hid/hid-core.c
	drivers/hid/hid-ids.h

HID: hidraw: open count should not increase if error

2011-09-27T16:42:22+00:00

In hidraw_open, if hid_hw_power returns with error, hidraw device open count
should not increase.

Signed-off-by: Amit Nagal 
Signed-off-by: Jiri Kosina

HID: hidraw: protect hidraw_disconnect() better

2011-09-20T13:23:46+00:00

The function hidraw_disconnect() only acquires the hidraw minors_lock
when clearing the entry in hidraw_table. However the device_destroy()
call can cause a userland read/write to return with an error. It may
cause the program to release the file descripter before the disconnect
is finished. hidraw_disconnect() has already set hidraw->exist to 0,
which makes hidraw_release() kfree the hidraw structure, which
hidraw_disconnect() continues to access and even tries to kfree again.
Similarly if a hidraw_release() occurs after setting hidraw->exist to 0,
the same thing can happen.

This is fixed by expanding the mutex critical section to cover the whole
function from setting hidraw->exist to 0 to freeing the hidraw
structure, preventing a hidraw_release() from interfering.

Signed-off-by: James Hogan 
Tested-by: David Herrmann 
Signed-off-by: Jiri Kosina

HID: hidraw: free list for all error in hidraw_open

2011-09-07T11:48:47+00:00

In function hidraw_open struct hidraw_list *list should be freed for
all error conditions.

Signed-off-by: Amit Nagal 
Signed-off-by: Jiri Kosina

HID: 'name' and 'phys' in 'struct hid_device' can never be NULL

2011-05-18T11:23:31+00:00

As they are static members of fix size, there is no need to NULL-check them.

Signed-off-by: Daniel Mack 
Cc: Dmitry Torokhov 
Cc: Jiri Kosina 
Signed-off-by: Jiri Kosina

HID: hidraw: fix comments

2011-03-27T18:30:32+00:00

Adjust the comments a little bit.

Signed-off-by: Jiri Kosina

Merge branches 'dragonrise', 'hidraw-feature', 'multitouch', 'ntrig', 'roccat', 'upstream' and 'upstream-fixes' into for-linus

2011-03-17T13:31:46+00:00

HID: Add Support for Setting and Getting Feature Reports from hidraw

2011-02-11T14:05:49+00:00

Per the HID Specification, Feature reports must be sent and received on
the Configuration endpoint (EP 0) through the Set_Report/Get_Report
interfaces.  This patch adds two ioctls to hidraw to set and get feature
reports to and from the device.  Modifications were made to hidraw and
usbhid.

New hidraw ioctls:
  HIDIOCSFEATURE - Perform a Set_Report transfer of a Feature report.
  HIDIOCGFEATURE - Perform a Get_Report transfer of a Feature report.

Signed-off-by: Alan Ott 
Signed-off-by: Antonio Ospite 
Signed-off-by: Jiri Kosina

HID: hidraw: fix hidraw_disconnect()

2011-02-01T10:16:51+00:00

hidraw_disconnect() first sets an entry in hidraw_table to NULL
and calls device_destroy() afterwards. The thereby called
hidraw_release() tries to read this already cleared value resulting
in never removing any device from the list.
This got fixed by changing the order of events.

Signed-off-by: Stefan Achatz 
Signed-off-by: Jiri Kosina

HID: hidraw: Replace Confusing += Operator with =

2011-01-31T14:43:46+00:00

Setting of the return value of hidraw_read() uses the += operator when
= is more appropriate.  There is no case where ret can be anything
other than zero when the assignment is made, making = equivalent to
+= and much more clear.

Signed-off-by: Alan Ott 
Signed-off-by: Jiri Kosina