linux-toradex.git/drivers/hid/intel-ish-hid, branch v5.8-rc2

HID: intel-ish-hid: avoid bogus uninitialized-variable warning

2020-05-05T07:54:25+00:00

Older compilers like gcc-4.8 don't see that the variable is
initialized when it is used:

In file included from include/linux/compiler_types.h:68:0,
                 from :0:
drivers/hid/intel-ish-hid/ishtp-fw-loader.c: In function 'load_fw_from_host':
include/linux/compiler-gcc.h:75:45: warning: 'fw_info.ldr_capability.max_dma_buf_size' may be used uninitialized in this function [-Wmaybe-uninitialized]
 #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                             ^
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:770:22: note: 'fw_info.ldr_capability.max_dma_buf_size' was declared here
  struct shim_fw_info fw_info;
                      ^

Make sure to initialize it before returning an error from ish_query_loader_prop().

Fixes: 91b228107da3 ("HID: intel-ish-hid: ISH firmware loader client driver")
Signed-off-by: Arnd Bergmann 
Acked-by: Srinivas Pandruvada 
Signed-off-by: Jiri Kosina

HID: intel-ish-hid: hbm.h: Replace zero-length array with flexible-array member

2020-03-20T23:07:32+00:00

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Jiri Kosina

HID: intel-ish-hid: ishtp-dev.h: Replace zero-length array with flexible-array member

2020-03-20T23:07:32+00:00

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Jiri Kosina

HID: intel-ish-hid: ipc: Add Tiger Lake PCI device ID

2019-12-29T20:39:03+00:00

Added Tiger Lake PCI device ID to the supported device list.

Signed-off-by: Srinivas Pandruvada 
Signed-off-by: Jiri Kosina

HID: intel-ish-hid: ipc: add CMP device id

2019-12-18T14:21:24+00:00

Add Comet Lake H into ishtp support list.

Signed-off-by: Even Xu 
Acked-by: Srinivas Pandruvada 
Signed-off-by: Benjamin Tissoires

HID: intel-ish-hid: Spelling s/diconnect/disconnect/

2019-11-02T20:08:36+00:00

Fix misspelling of "disconnect".

Signed-off-by: Geert Uytterhoeven 
Acked-by: Srinivas Pandruvada 
Signed-off-by: Jiri Kosina

HID: intel-ish-hid: fix wrong error handling in ishtp_cl_alloc_tx_ring()

2019-10-16T06:26:55+00:00

When allocating tx ring buffers failed, should free tx buffers, not rx buffers.

Signed-off-by: Zhang Lixu 
Acked-by: Srinivas Pandruvada 
Signed-off-by: Jiri Kosina

Merge branch 'for-5.4/ish' into for-linus

2019-09-22T20:33:41+00:00

- fixes for handling power management for intel-ish devices with NO_D3 flag
  set, from Zhang Lixu

Signed-off-by: Jiri Kosina

HID: intel-ish-hid: ipc: add EHL device id

2019-08-19T12:10:41+00:00

EHL is a new platform using ishtp solution, add its device id
to support list.

Signed-off-by: Even Xu 
Acked-by: Srinivas Pandruvada 
Signed-off-by: Jiri Kosina

HID: intel-ish-hid: ipc: check the NO_D3 flag to distinguish resume paths

2019-08-19T12:01:50+00:00

The NO_D3 flag would be set if the ISH enter D0i3 in ish_suspend(),
The resume paths can be distinguished by checking the NO_D3 flag.
It's more reasonable than checking the FW status.

Signed-off-by: Zhang Lixu 
Acked-by: Srinivas Pandruvada 
Signed-off-by: Jiri Kosina