linux-toradex.git/drivers/hid/uhid.c, branch v3.15-rc1

HID: uhid: Add UHID_CREATE2 + UHID_INPUT2

2014-04-01T16:27:33+00:00

UHID_CREATE2:
HID report descriptor data (rd_data) is an array in struct uhid_create2_req,
instead of a pointer. Enables use from languages that don't support pointers,
e.g. Python.

UHID_INPUT2:
Data array is the last field of struct uhid_input2_req. Enables userspace to
write only the required bytes to kernel (ev.type + ev.u.input2.size + the part
of the data array that matters), instead of the entire struct uhid_input2_req.

Note:
UHID_CREATE2 increases the total size of struct uhid_event slightly, thus
increasing the size of messages that are queued for userspace. However, this
won't affect the userspace processing of these events.

[Jiri Kosina : adjust to hid_get_raw_report() and
				hid_output_raw_report() API changes]

Signed-off-by: Petri Gynther 
Reviewed-by: David Herrmann 
Signed-off-by: Jiri Kosina

HID: remove hid_output_raw_report transport implementations

2014-03-14T14:30:24+00:00

Nobody calls hid_output_raw_report anymore, and nobody should.
We can now remove the various implementation in the different
transport drivers and the declarations.

Reviewed-by: David Herrmann 
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: uHID: implement .raw_request

2014-02-17T13:51:41+00:00

uHID is missing a SET_REPORT protocol implementation, but as
.hid_get_raw_report() as been removed from struct hid_device,
there were no means to access GET_REPORT in uhid.

Signed-off-by: Benjamin Tissoires 
Reviewed-by: David Herrmann 
Signed-off-by: Jiri Kosina

HID: uhid: reintroduce uhid_hid_get_raw()

2014-02-17T13:49:34+00:00

This reverts commit 4a76d370f0c0508b5d6580d15eae3d40b47d837c. Removing
it was a mistake, as we need a means to access GET_REPORT.

Reported-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: uHID: remove duplicated code

2014-02-17T13:49:22+00:00

uhid_hid_output_report() can be implemented through a simple call
to uhid_hid_output_raw().

Signed-off-by: Benjamin Tissoires 
Reviewed-by: David Herrmann 
Signed-off-by: Jiri Kosina

HID: uhid: remove uhid_hid_get_raw()

2014-02-17T13:15:48+00:00

This function is now unused since cafebc058bf8 ("HID: remove
hid_get_raw_report in struct hid_device").

Signed-off-by: Jiri Kosina

HID: remove hid_get_raw_report in struct hid_device

2014-02-17T13:05:58+00:00

dev->hid_get_raw_report(X) and hid_hw_raw_request(X, HID_REQ_GET_REPORT)
are strictly equivalent. Switch the hid subsystem to the hid_hw notation
and remove the field .hid_get_raw_report in struct hid_device.

Reviewed-by: David Herrmann 
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: Add the transport-driver function to the uhid driver

2014-01-29T13:23:42+00:00

Add the uhid_output_report transport-driver function to the uhid driver.

Signed-off-by: Frank Praznik 
Acked-by: David Herrmann 
Signed-off-by: Jiri Kosina

HID: uhid: fix leak for 64/32 UHID_CREATE

2013-11-27T09:53:49+00:00

UHID allows short writes so user-space can omit unused fields. We
automatically set them to 0 in the kernel. However, the 64/32 bit
compat-handler didn't do that in the UHID_CREATE fallback. This will
reveal random kernel heap data (of random size, even) to user-space.

Fixes: befde0226a59 ('HID: uhid: make creating devices work on 64/32 systems')

Reported-by: Ben Hutchings 
Signed-off-by: David Herrmann 
Cc: stable@vger.kernel.org
Signed-off-by: Jiri Kosina

HID: uhid: allocate static minor

2013-09-26T09:03:29+00:00

udev has this nice feature of creating "dead" /dev/ device-nodes if
it finds a devnode: modalias. Once the node is accessed, the kernel
automatically loads the module that provides the node. However, this
requires udev to know the major:minor code to use for the node. This
feature was introduced by:

  commit 578454ff7eab61d13a26b568f99a89a2c9edc881
  Author: Kay Sievers 
  Date:   Thu May 20 18:07:20 2010 +0200

      driver core: add devname module aliases to allow module on-demand auto-loading

However, uhid uses dynamic minor numbers so this doesn't actually work. We
need to load uhid to know which minor it's going to use.

Hence, allocate a static minor (just like uinput does) and we're good
to go.

Reported-by: Tom Gundersen 
Signed-off-by: David Herrmann 
Signed-off-by: Jiri Kosina