linux-toradex.git/drivers/hwmon/abituguru.c, branch v7.2-rc5

hwmon: Switch back to struct platform_driver::remove()

2024-11-10T22:48:07+00:00

After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.

Convert all platform drivers below drivers/hwmonto use .remove(), with
the eventual goal to drop struct platform_driver::remove_new(). As
.remove() and .remove_new() have the same prototypes, conversion is done
by just changing the structure member name in the driver initializer.

While touching these files, make indention of the struct initializer
consistent in several files.

Signed-off-by: Uwe Kleine-König 
Message-ID: <20241017155900.137357-2-u.kleine-koenig@baylibre.com>
Signed-off-by: Guenter Roeck

hwmon: (abituguru) Convert to platform remove callback returning void

2023-10-27T14:27:24+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Reviewed-by: Hans de Goede 
Link: https://lore.kernel.org/r/20230918085951.1234172-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck

hwmon: (abitguru) Switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()

2022-09-25T21:22:11+00:00

These newer PM macros allow the compiler to see what code it can remove
if !CONFIG_PM_SLEEP.  This allows the removal of messy #ifdef barriers.

Signed-off-by: Jonathan Cameron 
Cc: Hans de Goede 
Link: https://lore.kernel.org/r/20220925172759.3573439-2-jic23@kernel.org
Signed-off-by: Guenter Roeck

hwmon: abituguru: make array probe_order static, makes object smaller

2019-11-06T22:37:19+00:00

Don't populate the array probe_order on the stack but instead make it
static. Makes the object code smaller by 94 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
  41473	  13448	    320	  55241	   d7c9	drivers/hwmon/abituguru.o

After:
   text	   data	    bss	    dec	    hex	filename
  41315	  13512	    320	  55147	   d76b	drivers/hwmon/abituguru.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King 
Reviewed-by: Hans de Goede 
Link: https://lore.kernel.org/r/20191006145231.24022-1-colin.king@canonical.com
Signed-off-by: Guenter Roeck

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61

2019-05-24T15:36:45+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license as published by
  the free software foundation either version 2 of the license or at
  your option any later version this program is distributed in the
  hope that it will be useful but without any warranty without even
  the implied warranty of merchantability or fitness for a particular
  purpose see the gnu general public license for more details you
  should have received a copy of the gnu general public license along
  with this program if not write to the free software foundation inc
  675 mass ave cambridge ma 02139 usa

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-or-later

has been chosen to replace the boilerplate/reference in 441 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Michael Ellerman  (powerpc)
Reviewed-by: Richard Fontana 
Reviewed-by: Allison Randal 
Reviewed-by: Kate Stewart 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190520071858.739733335@linutronix.de
Signed-off-by: Greg Kroah-Hartman

hwmon: drop owner assignment from platform_drivers

2014-10-20T14:20:36+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

hwmon: Correct some typos

2013-10-18T16:12:02+00:00

Signed-off-by: LABBE Corentin 
Signed-off-by: Guenter Roeck

hwmon: fix error return code in abituguru_probe()

2013-05-13T15:07:13+00:00

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun 
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck

hwmon: Fix 'Macros with complex values' checkpatch errors

2013-04-08T04:16:38+00:00

Fix:

ERROR: Macros with complex values should be enclosed in parenthesis

when it is seen due to complex code and not due to multi-line variable
declarations.

Cc: Hans de Goede 
Cc: Alistair John Strachan 
Acked-by: Alistair John Strachan 
Signed-off-by: Guenter Roeck

hwmon: checkpatch cleanup: Replace printk with pr_debug or dev_dbg as appropriate

2013-04-08T04:16:38+00:00

Cc: Hans de Goede 
Cc: Alistair John Strachan 
Cc: Henrik Rydberg 
Acked-by: Alistair John Strachan 
Signed-off-by: Guenter Roeck