linux-toradex.git/drivers/hwmon/applesmc.c, branch v4.5

hwmon : (applesmc) Fix uninitialized variables warnings

2015-11-16T05:52:39+00:00

Fix the following "maybe used uninitialized" warnings by
initializing the variables to keep the compiler quiet.
There is no "used uninitialized" in this case.

  CC [M]  drivers/hwmon/applesmc.o
drivers/hwmon/applesmc.c: In function ‘applesmc_init_smcreg’:
drivers/hwmon/applesmc.c:595:43: warning: ‘right_light_sensor’
may be used uninitialized in this function [-Wmaybe-uninitialized]
  s->num_light_sensors = left_light_sensor + right_light_sensor;
                                           ^
drivers/hwmon/applesmc.c:540:26: note: ‘right_light_sensor’ was
declared here
  bool left_light_sensor, right_light_sensor;
                          ^
drivers/hwmon/applesmc.c:595:43: warning: ‘left_light_sensor’ may
be used uninitialized in this function [-Wmaybe-uninitialized]
  s->num_light_sensors = left_light_sensor + right_light_sensor;
                                           ^
drivers/hwmon/applesmc.c:540:7: note: ‘left_light_sensor’ was
declared here
  bool left_light_sensor, right_light_sensor;
       ^

Signed-off-by: Shuah Khan 
Signed-off-by: Guenter Roeck

hwmon: applesmc: fix comment typos

2015-09-29T13:28:01+00:00

s/ressources/resources/

Signed-off-by: Bastien Nocera 
Signed-off-by: Jiri Kosina

hwmon: drop owner assignment from platform_drivers

2014-10-20T14:20:36+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

hwmon: (applesmc) Always read until end of data

2013-10-09T16:48:55+00:00

The crash reported and investigated in commit 5f4513 turned out to be
caused by a change to the read interface on newer (2012) SMCs.

Tests by Chris show that simply reading the data valid line is enough
for the problem to go away. Additional tests show that the newer SMCs
no longer wait for the number of requested bytes, but start sending
data right away.  Apparently the number of bytes to read is no longer
specified as before, but instead found out by reading until end of
data. Failure to read until end of data confuses the state machine,
which eventually causes the crash.

As a remedy, assuming bit0 is the read valid line, make sure there is
nothing more to read before leaving the read function.

Tested to resolve the original problem, and runtested on MBA3,1,
MBP4,1, MBP8,2, MBP10,1, MBP10,2. The patch seems to have no effect on
machines before 2012.

Tested-by: Chris Murphy 
Cc: stable@vger.kernel.org
Signed-off-by: Henrik Rydberg 
Signed-off-by: Guenter Roeck

hwmon: (applesmc) Check key count before proceeding

2013-09-26T10:48:43+00:00

After reports from Chris and Josh Boyer of a rare crash in applesmc,
Guenter pointed at the initialization problem fixed below. The patch
has not been verified to fix the crash, but should be applied
regardless.

Reported-by: 
Suggested-by: Guenter Roeck 
Signed-off-by: Henrik Rydberg 
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck

hwmon: checkpatch cleanup: Replace printk with pr_debug or dev_dbg as appropriate

2013-04-08T04:16:38+00:00

Cc: Hans de Goede 
Cc: Alistair John Strachan 
Cc: Henrik Rydberg 
Acked-by: Alistair John Strachan 
Signed-off-by: Guenter Roeck

hwmon: Add missing inclusions of

2012-10-10T13:25:56+00:00

These drivers use IS_ERR so they should include .

Signed-off-by: Jean Delvare 
Acked-by: Guenter Roeck 
Acked-by: Luca Tettamanti 
Cc: Henrik Rydberg

hwmon: (applesmc) Bump max wait

2012-09-18T20:20:49+00:00

A heavy-load test on a MacBookPro6,1 is still showing a substantial
amount of read errors.  Increasing the maximum wait time to 128 ms
resolves the issue.

Signed-off-by: Parag Warudkar 
Signed-off-by: Henrik Rydberg 
Signed-off-by: Guenter Roeck

hwmon: (applesmc) Decode and act on read/write status codes

2012-07-27T21:00:12+00:00

The behavior of the SMC has changed several times over the years,
causing read failures in the driver. It seems the problem can be
explained by a shift in SMC speed combined with improper action on
status codes.

We should first wait for the SMC to settle, which was the most
frequent response on the old slow machines. Then, if the SMC is busy,
we need to try again later by resending the command. This was the most
likely response until 2012. Now, with a shorter wait time, we are
again most likely to poll while the SMC is settling, and as a result
we see high failure rates on many old and new models.

With the distinction between busy and failure, we can also wait longer
before retrying, without sacrificing speed.  This seems to bring
failures down to virtually zero on all models.

Tested on: MBA1,1 MBA3,1 MBA5,1 MBA5,2 MBP9,2

Tested-by: Adam Somerville 
Tested-by: Hubert Eichner 
Signed-off-by: Henrik Rydberg 
Signed-off-by: Guenter Roeck

hwmon: (applesmc) Ignore some temperature registers

2012-07-22T04:48:45+00:00

Not all sensors in the T range are useful temperatures.  This patch
creates a subset of sensors to be exported to userland, excluding the
unknown types.

Signed-off-by: Henrik Rydberg 
Signed-off-by: Guenter Roeck