linux-toradex.git/drivers/hwmon/coretemp.c, branch T30_LinuxImageV2.0Beta2_20130626

hwmon: (coretemp) Fix for non-SMP builds

2011-11-11T17:44:13+00:00

commit 2aba6cac2a84f3b80e11a680c34d55e7739b474d upstream.

The definition of TO_ATTR_NO in the non-SMP case is wrong. As the SMP
definition resolves to the correct value, just use this for both
cases.

Without this fix the temperature attributes are named temp0_* instead
of temp2_*, so libsensors won't pick them. Broken since kernel 3.0.

Signed-off-by: Jean Delvare 
Tested-by: Phil Sutter 
Acked-by: Durgadoss R 
Acked-by: Guenter Roeck 
Signed-off-by: Greg Kroah-Hartman

hwmon: (coretemp) Avoid leaving around dangling pointer

2011-09-28T15:19:21+00:00

Storing the struct temp_data pointer allocated from create_core_data()
when returning an error has the potential of leaving around a pointer
to freed memory. Reset it to NULL for error returns.

Reported-by: Jan Beulich 
Signed-off-by: Guenter Roeck 
Acked-by: Jean Delvare

hwmon: (coretemp) Fixup platform device ID change

2011-09-28T15:19:20+00:00

With recent change "hwmon: (coretemp) don't use kernel assigned CPU
number as platform device ID", the microcode check is now running on
random CPU. Fix that by checking the microcode before creating the
platform device rather than at probe time.

Also avoid calling TO_PHYS_ID(cpu) twice in the same function, it's
expensive.

Signed-off-by: Jean Delvare 
Cc: Jan Beulich 
Cc: Guenter Roeck 
Signed-off-by: Guenter Roeck

hwmon: (coretemp) remove struct platform_data * parameter from create_core_data()

2011-09-23T17:39:11+00:00

The only caller of the function obtained the pointer solely for the
purpose of passing it to this function, while it can be easily
determined from the struct platform_device * parameter also passed.

Signed-off-by: Jan Beulich 
Signed-off-by: Guenter Roeck

hwmon: (coretemp) constify static data

2011-09-23T17:39:10+00:00

These arrays won't ever be written to, so protect them from
unintentional modification.

Signed-off-by: Jan Beulich 
Signed-off-by: Guenter Roeck

hwmon: (coretemp) don't use kernel assigned CPU number as platform device ID

2011-09-23T17:38:09+00:00

... as that has the potential to conflict with (particularly soft) CPU
hot removal and re-adding.

Signed-off-by: Jan Beulich 
[guenter.roeck@ericsson.com: use platform device ID as physical CPU id]
Signed-off-by: Guenter Roeck

hwmon: (coretemp) Don't use threshold registers for tempX_max

2011-09-22T00:25:18+00:00

With commit c814a4c7c4aad795835583344353963a0a673eb0, the meaning of tempX_max
was changed. It no longer returns the value of bits 8:15 of
MSR_IA32_TEMPERATURE_TARGET, but instead returns the value of CPU threshold
register T1. tempX_max_hyst was added to reflect the value of temperature
threshold register T0.

As it turns out, T0 and T1 are used on some systems, presumably by the BIOS.
Also, T0 and T1 don't have a well defined meaning. The thresholds may be used
as upper or lower limits, and it is not guaranteed that T0 <= T1. Thus, the new
attribute mapping does not reflect the actual usage of the threshold registers.
Also, register contents are changed during runtime by an entity other than the
hwmon driver, meaning the values cached by the driver do not reflect actual
register contents.

Revert most of c814a4c7c4aad795835583344353963a0a673eb0 to address the problem.
Support for T0 and T1 will be added back in with a separate commit, using new
attribute names.

Signed-off-by: Guenter Roeck 
Cc: Fenghua Yu 
Cc: Durgadoss R 
Acked-by: Jean Delvare

hwmon: (coretemp) Let the user force TjMax

2011-09-22T00:25:18+00:00

On old CPUs (and even some recent Atom CPUs) TjMax can't be read from
the CPU registers, so it is guessed by the driver using a complex
heuristic which isn't reliable. So let users who know their CPU's
TjMax pass it as a module parameter.

Signed-off-by: Jean Delvare 
Cc: Fenghua Yu 
Cc: "R, Durgadoss" 
Cc: Guenter Roeck 
Cc: Alexander Stein 
Acked-by: Fenghua Yu 
Signed-off-by: Guenter Roeck

hwmon: (coretemp) Drop duplicate function get_pkg_tjmax

2011-09-22T00:25:18+00:00

Function get_pkg_tjmax is a simplified copy of get_tjmax. Drop it and
always use get_tjmax, result is the same and this avoids code
duplication.

Also make get_tjmax less verbose: don't warn about MSR read failure
when failure was expected, and don't report TjMax in the logs unless
debugging is enabled.

Signed-off-by: Jean Delvare 
Cc: Fenghua Yu 
Cc: Guenter Roeck 
Cc: Durgadoss R 
Acked-by: Fenghua Yu 
Signed-off-by: Guenter Roeck

hwmon: (coretemp) Initialize tmin

2011-09-14T10:55:05+00:00

ttarget is initialized when the driver is loaded, but tmin is not.
As a result, tempX_max_hyst attributes read 0. Fix this.

Also use THERM_*_THRESHOLD* constants in these initializations instead
of hard-coding the constants.

Signed-off-by: Jean Delvare 
Cc: "R, Durgadoss" 
Cc: Guenter Roeck 
Cc: Fenghua Yu 
Signed-off-by: Guenter Roeck