linux-toradex.git/drivers/hwmon/f75375s.c, branch v3.4-rc2

hwmon: (f75375s) Fix warning message seen in some configurations

2012-04-01T17:24:34+00:00

In some configurations, BUG() does not result in an endless loop but returns to
the caller. This results in the following compiler warning:

drivers/hwmon/f75375s.c: In function 'duty_mode_enabled':
drivers/hwmon/f75375s.c:280: warning: control reaches end of non-void function
drivers/hwmon/f75375s.c: In function 'auto_mode_enabled':
drivers/hwmon/f75375s.c:295: warning: control reaches end of non-void function

Fix the warning by returning something sensible after BUG().

Cc: Nikolaus Schulz 
Cc: Riku Voipio 
Signed-off-by: Guenter Roeck 
Acked-by: Jean Delvare 
Signed-off-by: Guenter Roeck

hwmon: convert drivers/hwmon/* to use module_i2c_driver()

2012-03-19T01:26:50+00:00

This patch converts the drivers in drivers/hwmon/* to use the
module_i2c_driver() macro which makes the code smaller and a bit simpler.

Signed-off-by: Axel Lin 
Cc: Corentin Labbe 
Cc: Dirk Eibach 
Cc: "Mark M. Hoffman" 
Cc: Steve Glendinning 
Cc: Riku Voipio 
Cc: Guillaume Ligneul 
Cc: David George 
Cc: "Hans J. Koch" 
Cc: Marc Hulsman 
Cc: Rudolf Marek 
Signed-off-by: Guenter Roeck

hwmon: (f75375s) Catch some attempts to write to r/o registers

2012-03-02T20:02:23+00:00

It makes no sense to attempt to manually configure the fan in auto mode,
or set the duty cycle directly in closed loop mode.  The corresponding
registers are then read-only.  If the user tries it nonetheless, error out
with EINVAL instead of silently doing nothing.

Signed-off-by: Nikolaus Schulz 
[guenter.roeck@ericsson.com: Minor formatting cleanup]
Signed-off-by: Guenter Roeck

hwmon: (f75375s) Properly map the F75387 automatic modes to pwm_enable

2012-03-02T19:56:43+00:00

The F75387 supports automatic fan control using either PWM duty cycle or
RPM speed values.  Make the driver detect the latter mode, and expose the
different modes in sysfs as per pwm_enable, so that the user can switch
between them.

The interpretation of the pwm_enable attribute for the F75387 is adjusted
to be a superset of those values used for similar Fintek chips which do
not support automatic duty mode, with 2 mapping to automatic speed mode,
and moving automatic duty mode to the new value 4.

Toggling the duty mode via pwm_enable is currently denied for the F75387,
as the chip then simply reinterprets the fan configuration register values
according to the new mode, switching between RPM and PWM units, which
makes this a dangerous operation.

This patch introduces a new pwm mode into the driver. This is necessary
because the new mode (automatic pwm mode, 4) may already be enabled by the
BIOS, and the driver should not break existing functionality. This was seen
on at least one board.

Signed-off-by: Nikolaus Schulz 
Signed-off-by: Guenter Roeck

hwmon: (f75375s) Make pwm*_mode writable for the F75387

2012-02-28T22:44:02+00:00

Signed-off-by: Nikolaus Schulz 
Signed-off-by: Guenter Roeck

hwmon: (f75375s) Fix writes to the pwm* attribute for the F75387

2012-02-28T22:39:47+00:00

For the F75387, the register holding the current PWM duty cycle value is
r/o; changing it requires writing to the fan expect register instead.

Signed-off-by: Nikolaus Schulz 
[guenter.roeck@ericsson.com: Simplified function parameters]
Signed-off-by: Guenter Roeck

hwmon: (f75375s) Fix register write order when setting fans to full speed

2012-02-23T14:47:47+00:00

By hwmon sysfs interface convention, setting pwm_enable to zero sets a fan
to full speed.  In the f75375s driver, this need be done by enabling
manual fan control, plus duty mode for the F875387 chip, and then setting
the maximum duty cycle.  Fix a bug where the two necessary register writes
were swapped, effectively discarding the setting to full-speed.

Signed-off-by: Nikolaus Schulz 
Cc: Riku Voipio 
Signed-off-by: Guenter Roeck

hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured value

2012-02-09T19:21:49+00:00

Treat pwmX as a measured value, not as a (mostly static) limit value, so
that it is updated more frequently from the device register.

Signed-off-by: Nikolaus Schulz 
Signed-off-by: Guenter Roeck

hwmon: (f75375s) Fix bit shifting in f75375_write16

2012-02-09T04:47:34+00:00

In order to extract the high byte of the 16-bit word, shift the word to
the right, not to the left.

Signed-off-by: Nikolaus Schulz 
Cc: stable@kernel.org # 2.6.32+
Signed-off-by: Guenter Roeck

hwmon: (f75375s) Fix reading of wrong register when initializing the F75387

2012-02-09T04:47:33+00:00

Unlike the other chips supported by this driver, the F75387 stores the
pwm_mode in register F75375_REG_FAN_TIMER, not F75375_REG_CONFIG1.

Signed-off-by: Nikolaus Schulz 
Signed-off-by: Guenter Roeck