linux-toradex.git/drivers/hwmon/gl520sm.c, branch v3.7.4

hwmon: (gl520sm) Convert to use devm_ functions

2012-07-22T04:48:40+00:00

Convert to use devm_ functions to reduce code size and simplify the code.

Signed-off-by: Guenter Roeck 
Acked-by: Jean Delvare

hwmon: (gl520sm) Fix: do not use assignment in if condition

2012-03-19T01:27:23+00:00

Fix checkpatch issue:
ERROR: do not use assignment in if condition

Replace repeated calls to device_create_file() with calls to sysfs_create_group.

Signed-off-by: Guenter Roeck

hwmon: (gl520sm) Fix checkpatch issues

2012-03-19T01:27:23+00:00

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<=' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that ':' (ctx:VxV)
ERROR: spaces required around that '?' (ctx:VxV)
ERROR: trailing statements should be on next line
WARNING: line over 80 characters
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not always fixed (complexity):
ERROR: do not use assignment in if condition

Signed-off-by: Guenter Roeck

hwmon: convert drivers/hwmon/* to use module_i2c_driver()

2012-03-19T01:26:50+00:00

This patch converts the drivers in drivers/hwmon/* to use the
module_i2c_driver() macro which makes the code smaller and a bit simpler.

Signed-off-by: Axel Lin 
Cc: Corentin Labbe 
Cc: Dirk Eibach 
Cc: "Mark M. Hoffman" 
Cc: Steve Glendinning 
Cc: Riku Voipio 
Cc: Guillaume Ligneul 
Cc: David George 
Cc: "Hans J. Koch" 
Cc: Marc Hulsman 
Cc: Rudolf Marek 
Signed-off-by: Guenter Roeck

hwmon: Use i2c_smbus_{read,write}_word_swapped

2011-11-04T11:00:47+00:00

Make use of the new i2c_smbus_{read,write}_word_swapped functions.
This makes the driver code more compact and readable. It also ensures
proper error handling.

Signed-off-by: Jean Delvare 
Acked-by: Jonathan Cameron 
Acked-by: Guenter Roeck 
Cc: Dirk Eibach 
Cc: "Mark M. Hoffman" 
Cc: Guillaume Ligneul

treewide: fix potentially dangerous trailing ';' in #defined values/expressions

2011-07-21T12:10:00+00:00

All these are instances of
  #define NAME value;
or
  #define NAME(params_opt) value;

These of course fail to build when used in contexts like
  if(foo $OP NAME)
  while(bar $OP NAME)
and may silently generate the wrong code in contexts such as
  foo = NAME + 1;    /* foo = value; + 1; */
  bar = NAME - 1;    /* bar = value; - 1; */
  baz = NAME & quux; /* baz = value; & quux; */

Reported on comp.lang.c,
Message-ID: 
Initial analysis of the dangers provided by Keith Thompson in that thread.

There are many more instances of more complicated macros having unnecessary
trailing semicolons, but this pile seems to be all of the cases of simple
values suffering from the problem. (Thus things that are likely to be found
in one of the contexts above, more complicated ones aren't.)

Signed-off-by: Phil Carmody 
Signed-off-by: Jiri Kosina

i2c: Drop I2C_CLIENT_INSMOD_1

2009-12-14T20:17:26+00:00

This macro simply declares an enum, so drivers might as well declare
it themselves.

Signed-off-by: Jean Delvare 
Tested-by: Wolfram Sang

i2c: Get rid of struct i2c_client_address_data

2009-12-14T20:17:25+00:00

Struct i2c_client_address_data only contains one field at this point,
which makes its usefulness questionable. Get rid of it and pass simple
address lists around instead.

Signed-off-by: Jean Delvare 
Tested-by: Wolfram Sang

i2c: Drop the kind parameter from detect callbacks

2009-12-14T20:17:23+00:00

The "kind" parameter always has value -1, and nobody is using it any
longer, so we can remove it.

Signed-off-by: Jean Delvare 
Tested-by: Wolfram Sang

hwmon: Clean up detect functions

2009-12-09T19:35:57+00:00

As kind is now hard-coded to -1, there is room for code clean-ups.

Signed-off-by: Jean Delvare 
Acked-by: Corentin Labbe 
Cc: "Mark M. Hoffman" 
Cc: Juerg Haefliger 
Cc: Riku Voipio 
Acked-by: "Hans J. Koch" 
Cc: Rudolf Marek