linux-toradex.git/drivers/hwmon/it87.c, branch v4.10

hwmon: (it87) Drop useless comments

2016-09-09T04:34:17+00:00

Remove the index comments at the end of it87_attributes_in. They
serve no purpose (as there is no reference to them in
it87_in_is_visible) and some of them were obviously wrong.

Signed-off-by: Jean Delvare 
Cc: Martin Blumenstingl 
Cc: Guenter Roeck 
Signed-off-by: Guenter Roeck

hwmon: (it87) Add missing sysfs attribute group terminator

2016-08-29T12:31:31+00:00

Attribute array it87_attributes_in lacks its NULL terminator,
causing random behavior when operating on the attribute group.

Fixes: 52929715634a ("hwmon: (it87) Use is_visible for voltage sensors")
Signed-off-by: Jean Delvare 
Cc: Martin Blumenstingl 
Cc: Guenter Roeck 
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck

hwmon: (it87) Features mask must be 32 bit wide

2016-08-12T01:35:47+00:00

Coverity reports:

result_independent_of_operands: data->features & (65536UL /* 1UL << 16 */)
is always 0 regardless of the values of its operands. This occurs as the
logical operand of if.

data->features needs to be 32 bit wide since there are more than 16 features.

Fixes: cc18da79d9b7 ("hwmon: (it87) Support up to 6 temperature sensors ... ");
Signed-off-by: Guenter Roeck

hwmon: (it87) Add support for IT8628E

2016-04-19T13:32:38+00:00

IT8628E is functionally identical to IT8620E.

Tested-by: Martin Blumenstingl 
Signed-off-by: Guenter Roeck

hwmon: (it87) Fix pwm_temp_map for system with 6 pwm channels

2016-04-19T13:32:37+00:00

Tested-by: Martin Blumenstingl 
Signed-off-by: Guenter Roeck

hwmon: (it87) Support automatic pwm control on newer chips

2016-04-19T13:32:37+00:00

Tested-by: Martin Blumenstingl 
Signed-off-by: Guenter Roeck

hwmon: (it87) Enhance validation for fan4 and fan5

2016-04-19T13:32:37+00:00

Several of the chips supported by this driver have a configuration
register to enable fan4 and fan5. Use those registers to determine
if fan4 and fan5 tachometers are supported.

Tested-by: Martin Blumenstingl 
Signed-off-by: Guenter Roeck

hwmon: (it87) Support disabling fan control for all pwm control and chips

2016-04-19T13:32:37+00:00

On/Off mode is only supported for pwm controls 0-2, and not supported at all for
IT8603E/IT8623E. For pwm controls 3-6 and for IT8603E/IT8623E, SmartGuardian mode
is always enabled. Use it and set the pwm value to the maximum if fan control
is disabled.

Tested-by: Martin Blumenstingl 
Signed-off-by: Guenter Roeck

hwmon: (it87) Formatting cleanup

2016-04-19T13:32:37+00:00

Fix various checkpatch complaints to clean up the code and
make it easier to read.

CHECK: Do not include the paragraph about writing to the FSF
CHECK: Alignment should match open parenthesis
CHECK: Logical continuations should be on the previous line
CHECK: No space is necessary after a cast
CHECK: Please don't use multiple blank lines
CHECK: Please use a blank line after function/struct/union/enum
       declarations
CHECK: spaces preferred around that '+' (ctx:VxV)
WARNING: Missing a blank line after declarations

No functional change.

Tested-by: Martin Blumenstingl 
Signed-off-by: Guenter Roeck

hwmon: (it87) Use defines for array sizes and sensor counts

2016-04-19T13:32:37+00:00

Using array size defines makes it much easier to find errors
in index values and loop counts.

Tested-by: Martin Blumenstingl 
Signed-off-by: Guenter Roeck