linux-toradex.git/drivers/hwmon/k10temp.c, branch v5.7-rc2

hwmon: (k10temp) make some symbols static

2020-04-12T22:12:51+00:00

Fix the following sparse warning:

drivers/hwmon/k10temp.c:189:12: warning: symbol 'k10temp_temp_label' was
not declared. Should it be static?
drivers/hwmon/k10temp.c:202:12: warning: symbol 'k10temp_in_label' was
not declared. Should it be static?
drivers/hwmon/k10temp.c:207:12: warning: symbol 'k10temp_curr_label' was
not declared. Should it be static?

Reported-by: Hulk Robot 
Signed-off-by: Jason Yan 
Link: https://lore.kernel.org/r/20200409084502.42126-1-yanaijie@huawei.com
Signed-off-by: Guenter Roeck

hwmon: (k10temp) Reorganize and simplify temperature support detection

2020-03-09T03:35:46+00:00

Use a bit map to describe if temperature channels are supported,
and use it for all temperature channels. Use a separate flag,
independent of Tdie support, to indicate if the system is running
on a Ryzen CPU.

Signed-off-by: Guenter Roeck

hwmon: (k10temp) Swap Tdie and Tctl on Family 17h CPUs

2020-03-09T03:35:46+00:00

Traditionally, the temperature displayed by k10temp was Tctl.
On Family 17h CPUs, Tdie was displayed instead. To reduce confusion,
Tctl was added later as second temperature. This resulted in Tdie
being reported as temp1_input, and Tctl as temp2_input. This is
different to non-Ryzen CPUs, where Tctl is displayed as temp1_input.
Swap temp1_input and temp2_input on Family 17h CPUs, such that Tctl
is now reported as temp1_input and Tdie is reported as temp2_input,
to align with other CPUs, streamline the code, and make it less
confusing. Coincidentally, this also aligns the code with its
documentation, which states that Tdie is reported as temp2_input.

Signed-off-by: Guenter Roeck

hwmon: (k10temp) Display up to eight sets of CCD temperatures

2020-01-23T23:17:59+00:00

In HWiNFO, we see support for Tccd1, Tccd3, Tccd5, and Tccd7 temperature
sensors on Zen2 based Threadripper CPUs. Checking register maps on
Threadripper 3970X confirms SMN register addresses and values for those
sensors.

Register values observed in an idle system:

0x059950: 00000000 00000abc 00000000 00000ad8
0x059960: 00000000 00000ade 00000000 00000ae4

Under load:

0x059950: 00000000 00000c02 00000000 00000c14
0x059960: 00000000 00000c30 00000000 00000c22

More analysis shows that EPYC CPUs support up to 8 CCD temperature
sensors. EPYC 7601 supports three CCD temperature sensors. Unlike
Zen2 CPUs, the register space in Zen1 CPUs supports a maximum of four
sensors, so only search for a maximum of four sensors on Zen1 CPUs.

On top of that, in thm_10_0_sh_mask.h in the Linux kernel, we find
definitions for THM_DIE{1-3}_TEMP__VALID_MASK, set to 0x00000800, as well
as matching SMN addresses. This lets us conclude that bit 11 of the
respective registers is a valid bit. With this assumption, the temperature
offset is now 49 degrees C. This conveniently matches the documented
temperature offset for Tdie, again suggesting that above registers indeed
report temperatures sensor values. Assume that bit 11 is indeed a valid
bit, and add support for the additional sensors.

With this patch applied, output from 3970X (idle) looks as follows:

k10temp-pci-00c3
Adapter: PCI adapter
Tdie:         +55.9°C
Tctl:         +55.9°C
Tccd1:        +39.8°C
Tccd3:        +43.8°C
Tccd5:        +43.8°C
Tccd7:        +44.8°C

Tested-by: Michael Larabel 
Signed-off-by: Guenter Roeck

hwmon: (k10temp) Add debugfs support

2020-01-23T21:15:11+00:00

Show thermal and SVI registers for Family 17h CPUs.

Tested-by: Sebastian Reichel 
Signed-off-by: Guenter Roeck

hwmon: (k10temp) Don't show temperature limits on Ryzen (Zen) CPUs

2020-01-23T21:15:11+00:00

The maximum Tdie or Tctl is not published for Ryzen CPUs. What is
known, however, is that the traditional value of 70 degrees C is no
longer correct. On top of that, the limit applies to Tctl, not to Tdie.
Displaying it in either context is meaningless, confusing, and wrong.
Stop doing it.

Tested-by: Brad Campbell 
Tested-by: Holger Kiehl 
Tested-by: Michael Larabel 
Tested-by: Jonathan McDowell 
Tested-by: Ken Moffat 
Signed-off-by: Guenter Roeck

hwmon: (k10temp) Show core and SoC current and voltages on Ryzen CPUs

2020-01-23T21:15:11+00:00

Ryzen CPUs report core and SoC voltages and currents. Add support
for it to the k10temp driver.

For the time being, only report voltages and currents for Ryzen
CPUs. Threadripper and EPYC appear to use a different mechanism.

Tested-by: Brad Campbell 
Tested-by: Bernhard Gebetsberger 
Tested-by: Holger Kiehl 
Tested-by: Michael Larabel 
Tested-by: Jonathan McDowell 
Tested-by: Ken Moffat 
Tested-by: Darren Salt 
Signed-off-by: Guenter Roeck

hwmon: (k10temp) Report temperatures per CPU die

2020-01-23T21:15:11+00:00

Zen2 reports reporting temperatures per CPU die (called Core Complex Dies,
or CCD, by AMD). Add support for it to the k10temp driver.

Tested-by: Brad Campbell 
Tested-by: Bernhard Gebetsberger 
Tested-by: Holger Kiehl 
Tested-by: Michael Larabel 
Tested-by: Jonathan McDowell 
Tested-by: Ken Moffat 
Tested-by: Darren Salt 
Signed-off-by: Guenter Roeck

hmon: (k10temp) Convert to use devm_hwmon_device_register_with_info

2020-01-23T21:15:11+00:00

Convert driver to use devm_hwmon_device_register_with_info to simplify
the code and to reduce its size.

Old size (x86_64):
   text	   data	    bss	    dec	    hex	filename
   8247	   4488	     64	  12799	   31ff	drivers/hwmon/k10temp.o
New size:
   text	   data	    bss	    dec	    hex	filename
   6778	   2792	     64	   9634	   25a2	drivers/hwmon/k10temp.o

Tested-by: Brad Campbell 
Tested-by: Bernhard Gebetsberger 
Tested-by: Holger Kiehl 
Tested-by: Michael Larabel 
Tested-by: Jonathan McDowell 
Tested-by: Ken Moffat 
Tested-by: Darren Salt 
Signed-off-by: Guenter Roeck

hwmon: (k10temp) Use bitops

2020-01-23T21:15:11+00:00

Using bitops makes bit masks and shifts easier to read.

Tested-by: Brad Campbell 
Tested-by: Bernhard Gebetsberger 
Tested-by: Holger Kiehl 
Tested-by: Michael Larabel 
Tested-by: Jonathan McDowell 
Tested-by: Ken Moffat 
Tested-by: Darren Salt 
Signed-off-by: Guenter Roeck