linux-toradex.git/drivers/hwmon/pc87360.c, branch v3.4.34

hwmon: (pc87360) Fix: do not use assignment in if condition

2012-03-19T01:27:27+00:00

Fix checkpatch issue:
ERROR: do not use assignment in if condition

Replace repeated calls to device_create_file() with calls to sysfs_create_group.

Cc: Jean Delvare 
Cc: Jim Cromie 
Signed-off-by: Guenter Roeck

hwmon: (pc87360) Fix checkpatch issues

2012-03-19T01:27:26+00:00

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: "foo * bar" should be "foo *bar"
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that ':' (ctx:VxE)
ERROR: spaces required around that '==' (ctx:VxV)
WARNING: braces {} are not necessary for single statement blocks
WARNING: line over 80 characters
WARNING: please, no space before tabs
WARNING: please, no spaces at the start of a line
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Not or not all fixed (code complexity):
ERROR: Macros with complex values should be enclosed in parenthesis
ERROR: do not use assignment in if condition

Cc: Jim Cromie 
Signed-off-by: Guenter Roeck

hwmon: (pc87360) Fix multi-line comments

2012-03-19T01:26:56+00:00

Cc: Jim Cromie 
Acked-by: Jim Cromie 
Signed-off-by: Guenter Roeck

hwmon: (pc87360) Use pr_fmt and pr_

2011-01-12T20:55:11+00:00

Added #define pr_fmt KBUILD_MODNAME ": " fmt
Converted printks to pr_
Coalesced any long formats
Removed prefixes from formats

[JD: Also convert debug messages]

Signed-off-by: Joe Perches 
Signed-off-by: Jean Delvare

hwmon: (pc87360) Fix device resource declaration

2010-08-14T19:08:48+00:00

It's not OK to call platform_device_add_resources() multiple times
in a row. Despite its name, this functions sets the resources, it
doesn't add them. So we have to prepare an array with all the
resources, and then call platform_device_add_resources() once.

Before this fix, only the last I/O resource would be actually
registered. The other I/O resources were leaked.

Signed-off-by: Jean Delvare 
Cc: Jim Cromie 
Cc: stable@kernel.org

hwmon: Include instead of

2009-09-15T15:18:13+00:00

Drivers should be including  instead of .

Signed-off-by: H Hartley Sweeten 
Cc: Alistair John Strachan 
Cc: Nicolas Boichat 
Cc: Juerg Haefliger 
Cc: Frank Seidel 
Acked-by: Jim Cromie 
Cc: "Mark M. Hoffman" 
Cc: Roger Lucas 
Signed-off-by: Jean Delvare

hwmon: Check for ACPI resource conflicts

2009-01-07T15:37:35+00:00

Check for ACPI resource conflicts in hwmon drivers. I've included
all Super-I/O and PCI drivers.

I've voluntarily left out:
* Vendor-specific drivers: if they conflicted on any system, this would
  pretty much mean that they conflict on all systems, and we would know
  by now.
* Legacy ISA drivers (lm78 and w83781d): they only support chips found
  on old designs were ACPI either wasn't supported or didn't deal with
  thermal management.
* Drivers accessing the I/O resources indirectly (e.g. through SMBus):
  the checks are already done where they belong, i.e. in the bus drivers.

Signed-off-by: Jean Delvare 
Acked-by: David Hubbard

hwmon/pc87360 separate alarm files: add therm-min/max/crit-alarms

2008-10-20T15:52:35+00:00

Adds therm-min/max/crit-alarm callbacks, sensor-device-attribute
declarations, and refs to those new decls in the macro used to initialize
the therm_group (of sysfs files)

The thermistors use voltage channels to measure; so they don't have a
fault-alarm, but unlike the other voltages, they do have an overtemp,
which we call crit (by convention).

[akpm@linux-foundation.org: cleanup]
Signed-off-by: Jim Cromie 
Cc: Jean Delvare 
Cc: "Mark M. Hoffman" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

hwmon/pc87360 separate alarm files: add dev_dbg help

2008-10-20T15:52:35+00:00

temp and vin status register values may be set by chip specifications, set
again by bios, or by this previously loaded driver.  Debug output nicely
displays modprobe init=\d actions.

Signed-off-by: Jim Cromie 
Cc: Jean Delvare 
Cc: "Mark M. Hoffman" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

hwmon/pc87360 separate alarm files: define LDNI_MAX const

2008-10-20T15:52:35+00:00

Driver handles 3 logical devices in fixed length array.  Give this a
define-d constant.

Signed-off-by: Jim Cromie 
Cc: Jean Delvare 
Cc: "Mark M. Hoffman" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds