linux-toradex.git/drivers/hwmon, branch v3.2.53

hwmon: (applesmc) Always read until end of data

2013-11-28T14:02:02+00:00

commit 25f2bd7f5add608c1d1405938f39c96927b275ca upstream.

The crash reported and investigated in commit 5f4513 turned out to be
caused by a change to the read interface on newer (2012) SMCs.

Tests by Chris show that simply reading the data valid line is enough
for the problem to go away. Additional tests show that the newer SMCs
no longer wait for the number of requested bytes, but start sending
data right away.  Apparently the number of bytes to read is no longer
specified as before, but instead found out by reading until end of
data. Failure to read until end of data confuses the state machine,
which eventually causes the crash.

As a remedy, assuming bit0 is the read valid line, make sure there is
nothing more to read before leaving the read function.

Tested to resolve the original problem, and runtested on MBA3,1,
MBP4,1, MBP8,2, MBP10,1, MBP10,2. The patch seems to have no effect on
machines before 2012.

Tested-by: Chris Murphy 
Signed-off-by: Henrik Rydberg 
Signed-off-by: Guenter Roeck 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings

hwmon: (applesmc) Silence uninitialized warnings

2013-10-26T20:06:13+00:00

commit 0fc86eca1b338d06ec500b34ef7def79c32b602b upstream.

Some error paths do not set a result, leading to the (false)
assumption that the value may be used uninitialized. Set results for
those paths as well.

Signed-off-by: Henrik Rydberg 
Signed-off-by: Guenter Roeck 
Signed-off-by: Ben Hutchings

hwmon: (applesmc) Check key count before proceeding

2013-10-26T20:06:06+00:00

commit 5f4513864304672e6ea9eac60583eeac32e679f2 upstream.

After reports from Chris and Josh Boyer of a rare crash in applesmc,
Guenter pointed at the initialization problem fixed below. The patch
has not been verified to fix the crash, but should be applied
regardless.

Reported-by: 
Suggested-by: Guenter Roeck 
Signed-off-by: Henrik Rydberg 
Signed-off-by: Guenter Roeck 
Signed-off-by: Ben Hutchings

hwmon: (adt7470) Fix incorrect return code check

2013-09-10T00:57:21+00:00

commit 93d783bcca69bfacc8dc739d8a050498402587b5 upstream.

In adt7470_write_word_data(), which writes two bytes using
i2c_smbus_write_byte_data(), the return codes are incorrectly AND-ed
together when they should be OR-ed together.

The return code of i2c_smbus_write_byte_data() is zero for success.

The upshot is only the first byte was ever written to the hardware.
The 2nd byte was never written out.

I noticed that trying to set the fan speed limits was not working
correctly on my system.  Setting the fan speed limits is the only
code that uses adt7470_write_word_data().  After making the change
the limit settings work and the alarms work also.

Signed-off-by: Curt Brune 
Signed-off-by: Guenter Roeck 
Signed-off-by: Ben Hutchings

hwmon: (adm1021) Strengthen chip detection for ADM1021, LM84 and MAX1617

2013-06-19T01:16:57+00:00

commit 591bfcfc334a003ba31c0deff03b22e73349939b upstream.

On a system with both MAX1617 and JC42 sensors, JC42 sensors can be misdetected
as LM84. Strengthen detection sufficiently enough to avoid this misdetection.
Also improve detection for ADM1021.

Modeled after chip detection code in sensors-detect command.

Signed-off-by: Guenter Roeck 
Tested-by: Jean Delvare 
Acked-by: Jean Delvare 
Signed-off-by: Ben Hutchings

hwmon: fix error return code in abituguru_probe()

2013-05-30T13:34:57+00:00

commit ecacb0b17c08fae89f65468727f0e4b8e91da4e1 upstream.

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun 
Signed-off-by: Guenter Roeck 
Signed-off-by: Ben Hutchings

hwmon: (pmbus/ltc2978) Fix temperature reporting

2013-03-20T15:03:36+00:00

commit 8c958c703ef8804093437959221951eaf0e1e664 upstream.

On LTC2978, only READ_TEMPERATURE is supported. It reports
the internal junction temperature. This register is unpaged.

On LTC3880, READ_TEMPERATURE and READ_TEMPERATURE2 are supported.
READ_TEMPERATURE is paged and reports external temperatures.
READ_TEMPERATURE2 is unpaged and reports the internal junction
temperature.

Signed-off-by: Guenter Roeck 
Acked-by: Jean Delvare 
Signed-off-by: Ben Hutchings

hwmon: (lineage-pem) Add missing terminating entry for pem_[input|fan]_attributes

2013-03-20T15:03:36+00:00

commit df069079c153d22adf6c28dcc0b1cf62bba75167 upstream.

Signed-off-by: Axel Lin 
Acked-by: Jean Delvare 
Signed-off-by: Guenter Roeck 
Signed-off-by: Ben Hutchings

hwmon: (sht15) Check return value of regulator_enable()

2013-03-20T15:03:22+00:00

commit 3e78080f81481aa8340374d5a37ae033c1cf4272 upstream.

Not having power is a pretty serious error so check that we are able to
enable the supply and error out if we can't.

Signed-off-by: Mark Brown 
Signed-off-by: Guenter Roeck 
[bwh: Backported to 3.2: driver does not use the devm API to manage
 memory, so goto err_free_data rather than returning on error]
Signed-off-by: Ben Hutchings

hwmon: (pmbus/ltc2978) Use detected chip ID to select supported functionality

2013-03-20T15:03:22+00:00

commit f366fccd0809f13ba20d64cae3c83f7338c88af7 upstream.

We read the chip ID from the chip, use it to determine if the chip ID provided
to the driver is correct, and report it if wrong. We should also use the
correct chip ID to select supported functionality.

Signed-off-by: Guenter Roeck 
Acked-by: Jean Delvare 
Signed-off-by: Ben Hutchings