linux-toradex.git/drivers/hwmon, branch v3.2.55

hwmon: (coretemp) Fix truncated name of alarm attributes

2014-02-15T19:20:17+00:00

commit 3f9aec7610b39521c7c69d754de7265f6994c194 upstream.

When the core number exceeds 9, the size of the buffer storing the
alarm attribute name is insufficient and the attribute name is
truncated. This causes libsensors to skip these attributes as the
truncated name is not recognized.

Reported-by: Andreas Hollmann 
Signed-off-by: Jean Delvare 
Signed-off-by: Guenter Roeck 
Signed-off-by: Ben Hutchings

hwmon: Prevent some divide by zeros in FAN_TO_REG()

2014-01-03T04:33:30+00:00

commit 3806b45ba4655147a011df03242cc197ab986c43 upstream.

The "rpm * div" operations can overflow here, so this patch adds an
upper limit to rpm to prevent that.  Jean Delvare helped me with this
patch.

Signed-off-by: Dan Carpenter 
Acked-by: Roger Lucas 
Signed-off-by: Jean Delvare 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings

hwmon: (w83l768ng) Fix fan speed control range

2014-01-03T04:33:30+00:00

commit 33a7ab91d509fa33b4bcd3ce0038cc80298050da upstream.

The W83L786NG stores the fan speed on 4 bits while the sysfs interface
uses a 0-255 range. Thus the driver should scale the user input down
to map it to the device range, and scale up the value read from the
device before presenting it to the user. The reserved register nibble
should be left unchanged.

Signed-off-by: Jean Delvare 
Reviewed-by: Guenter Roeck 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings

hwmon: (w83l786ng) Fix fan speed control mode setting and reporting

2014-01-03T04:33:30+00:00

commit cf7559bc053471f32373d71d04a9aa19e0b48d59 upstream.

The wrong mask is used, which causes some fan speed control modes
(pwmX_enable) to be incorrectly reported, and some modes to be
impossible to set.

[JD: add subject and description.]

Signed-off-by: Brian Carnes 
Signed-off-by: Jean Delvare 
Signed-off-by: Ben Hutchings

hwmon: (lm90) Fix max6696 alarm handling

2014-01-03T04:33:22+00:00

commit e41fae2b1ed8c78283d73651cd65be0228c0dd1c upstream.

Bit 2 of status register 2 on MAX6696 (external diode 2 open)
sets ALERT; the bit thus has to be listed in alert_alarms.
Also display a message in the alert handler if the condition
is encountered.

Even though not all overtemperature conditions cause ALERT
to be set, we should not ignore them in the alert handler.
Display messages for all out-of-range conditions.

Reported-by: Jean Delvare 
Signed-off-by: Guenter Roeck 
Signed-off-by: Jean Delvare 
Signed-off-by: Ben Hutchings

hwmon: (applesmc) Always read until end of data

2013-11-28T14:02:02+00:00

commit 25f2bd7f5add608c1d1405938f39c96927b275ca upstream.

The crash reported and investigated in commit 5f4513 turned out to be
caused by a change to the read interface on newer (2012) SMCs.

Tests by Chris show that simply reading the data valid line is enough
for the problem to go away. Additional tests show that the newer SMCs
no longer wait for the number of requested bytes, but start sending
data right away.  Apparently the number of bytes to read is no longer
specified as before, but instead found out by reading until end of
data. Failure to read until end of data confuses the state machine,
which eventually causes the crash.

As a remedy, assuming bit0 is the read valid line, make sure there is
nothing more to read before leaving the read function.

Tested to resolve the original problem, and runtested on MBA3,1,
MBP4,1, MBP8,2, MBP10,1, MBP10,2. The patch seems to have no effect on
machines before 2012.

Tested-by: Chris Murphy 
Signed-off-by: Henrik Rydberg 
Signed-off-by: Guenter Roeck 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings

hwmon: (applesmc) Silence uninitialized warnings

2013-10-26T20:06:13+00:00

commit 0fc86eca1b338d06ec500b34ef7def79c32b602b upstream.

Some error paths do not set a result, leading to the (false)
assumption that the value may be used uninitialized. Set results for
those paths as well.

Signed-off-by: Henrik Rydberg 
Signed-off-by: Guenter Roeck 
Signed-off-by: Ben Hutchings

hwmon: (applesmc) Check key count before proceeding

2013-10-26T20:06:06+00:00

commit 5f4513864304672e6ea9eac60583eeac32e679f2 upstream.

After reports from Chris and Josh Boyer of a rare crash in applesmc,
Guenter pointed at the initialization problem fixed below. The patch
has not been verified to fix the crash, but should be applied
regardless.

Reported-by: 
Suggested-by: Guenter Roeck 
Signed-off-by: Henrik Rydberg 
Signed-off-by: Guenter Roeck 
Signed-off-by: Ben Hutchings

hwmon: (adt7470) Fix incorrect return code check

2013-09-10T00:57:21+00:00

commit 93d783bcca69bfacc8dc739d8a050498402587b5 upstream.

In adt7470_write_word_data(), which writes two bytes using
i2c_smbus_write_byte_data(), the return codes are incorrectly AND-ed
together when they should be OR-ed together.

The return code of i2c_smbus_write_byte_data() is zero for success.

The upshot is only the first byte was ever written to the hardware.
The 2nd byte was never written out.

I noticed that trying to set the fan speed limits was not working
correctly on my system.  Setting the fan speed limits is the only
code that uses adt7470_write_word_data().  After making the change
the limit settings work and the alarms work also.

Signed-off-by: Curt Brune 
Signed-off-by: Guenter Roeck 
Signed-off-by: Ben Hutchings

hwmon: (adm1021) Strengthen chip detection for ADM1021, LM84 and MAX1617

2013-06-19T01:16:57+00:00

commit 591bfcfc334a003ba31c0deff03b22e73349939b upstream.

On a system with both MAX1617 and JC42 sensors, JC42 sensors can be misdetected
as LM84. Strengthen detection sufficiently enough to avoid this misdetection.
Also improve detection for ADM1021.

Modeled after chip detection code in sensors-detect command.

Signed-off-by: Guenter Roeck 
Tested-by: Jean Delvare 
Acked-by: Jean Delvare 
Signed-off-by: Ben Hutchings