linux-toradex.git/drivers/hwspinlock/sprd_hwspinlock.c, branch v6.0-rc3

hwspinlock: sprd: Use struct_size() helper in devm_kzalloc()

2022-03-11T20:56:57+00:00

Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worst scenario, could lead to heap overflows.

Also, address the following sparse warnings:
drivers/hwspinlock/sprd_hwspinlock.c:96:36: warning: using sizeof on a flexible structure

Link: https://github.com/KSPP/linux/issues/174
Signed-off-by: Gustavo A. R. Silva 
Reviewed-by: Baolin Wang 
Signed-off-by: Bjorn Andersson 
Link: https://lore.kernel.org/r/20220125225723.GA78256@embeddedor

hwspinlock: sprd: fixed warning of unused variable 'sprd_hwspinlock_of_match'

2020-11-18T03:42:13+00:00

The macro function of_match_ptr() is NULL if CONFIG_OF is not set, in this
case Clang compiler would complain the of_device_id variable is unused.

Reviewed-by: Baolin Wang 
Reported-by: kernel test robot 
Fixes: d8c8bbbb1aba ("hwspinlock: sprd: Add hardware spinlock driver")
Signed-off-by: Chunyan Zhang 
Link: https://lore.kernel.org/r/20201112070410.14810-1-zhang.lyra@gmail.com
Signed-off-by: Bjorn Andersson

hwspinlock: sprd: use module_platform_driver() instead postcore initcall

2020-11-03T00:04:06+00:00

The hardware spinlock devices are defined in the DT, there's no need for
init calls order, remove boilerplate code by using module_platform_driver.

Reviewed-by: Baolin Wang 
Signed-off-by: Chunyan Zhang 
Link: https://lore.kernel.org/r/20201030034654.15775-3-zhang.lyra@gmail.com
Signed-off-by: Bjorn Andersson

hwspinlock: sprd: Remove redundant header files

2020-10-26T15:17:54+00:00

Remove redundant header files.

Signed-off-by: Baolin Wang 
Link: https://lore.kernel.org/r/1590991552-93643-1-git-send-email-baolin.wang@linux.alibaba.com
Signed-off-by: Bjorn Andersson

hwspinlock: sprd: Remove redundant PM runtime implementation

2019-11-09T00:42:11+00:00

Since the hwspinlock core has changed the PM runtime to be optional, thus
remove the redundant PM runtime implementation in the Spreadtrum hwlock
driver.

Signed-off-by: Baolin Wang 
Signed-off-by: Bjorn Andersson

hwspinlock: sprd: Use devm_hwspin_lock_register() to register hwlock controller

2019-10-05T04:10:26+00:00

Use devm_hwspin_lock_register() to register the hwlock controller instead of
unregistering the hwlock controller explicitly when removing the device.

Signed-off-by: Baolin Wang 
Signed-off-by: Bjorn Andersson

hwspinlock: sprd: Use devm_add_action_or_reset() for calls to clk_disable_unprepare()

2019-10-05T04:09:52+00:00

Use devm_add_action_or_reset() for calls to clk_disable_unprepare(),
which can simplify the error handling.

Signed-off-by: Baolin Wang 
Signed-off-by: Bjorn Andersson

hwspinlock: sprd: Check the return value of clk_prepare_enable()

2019-10-05T04:07:44+00:00

We must check the return value of clk_prepare_enable() to make sure the
hardware spinlock controller can be enabled successfully, otherwise we
should return error.

Signed-off-by: Baolin Wang 
Signed-off-by: Bjorn Andersson

hwspinlock: sprd: Change to use devm_platform_ioremap_resource()

2019-10-05T04:07:19+00:00

Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together, which can simpify the code.

Signed-off-by: Baolin Wang 
Signed-off-by: Bjorn Andersson

hwspinlock: sprd: Switch to SPDX license identifier

2018-05-24T19:04:48+00:00

Use the appropriate SPDX license identifiers in the Spreadtrum hardware
spinlock driver source file and drop the previous boilerplate license text.

Cc: Baolin Wang 
Signed-off-by: Suman Anna 
Signed-off-by: Bjorn Andersson