linux-toradex.git/drivers/hwspinlock, branch v5.5 Linux kernel for Apalis and Colibri modules hwspinlock: u8500_hsem: Remove redundant PM runtime implementation 2019-11-09T00:42:26+00:00 Baolin Wang baolin.wang@linaro.org 2019-10-14T07:07:46+00:00 9d399f0c52951c1acf972bf98ea55ba8798fea7a Since the hwspinlock core has changed the PM runtime to be optional, thus remove the redundant PM runtime implementation in the u8500 HWSEM driver. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> 
Since the hwspinlock core has changed the PM runtime to be optional, thus
remove the redundant PM runtime implementation in the u8500 HWSEM driver.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
hwspinlock: sprd: Remove redundant PM runtime implementation 2019-11-09T00:42:11+00:00 Baolin Wang baolin.wang@linaro.org 2019-10-14T07:07:45+00:00 4d0c1c57329ac2db987160aa55ffdca479181dbe Since the hwspinlock core has changed the PM runtime to be optional, thus remove the redundant PM runtime implementation in the Spreadtrum hwlock driver. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> 
Since the hwspinlock core has changed the PM runtime to be optional, thus
remove the redundant PM runtime implementation in the Spreadtrum hwlock
driver.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
hwspinlock: Let the PM runtime can be optional 2019-11-09T00:42:00+00:00 Baolin Wang baolin.wang@linaro.org 2019-10-14T07:07:44+00:00 a6fc49051cdb847428edf189023b087c1b4fc598 Now some hwspinlock controllers did not have the requirement to implement the PM runtime, but drivers must enable the PM runtime to comply with the hwspinlock core. Thus we can change the PM runtime support to be optional by validating the -EACCES error number which means the PM runtime is not enabled, and removing the return value validating of pm_runtime_put(). So that we can remove some redundant PM runtime code in drivers. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> 
Now some hwspinlock controllers did not have the requirement to implement
the PM runtime, but drivers must enable the PM runtime to comply with the
hwspinlock core.

Thus we can change the PM runtime support to be optional by validating
the -EACCES error number which means the PM runtime is not enabled, and
removing the return value validating of pm_runtime_put(). So that we
can remove some redundant PM runtime code in drivers.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
hwspinlock: Remove BUG_ON() from the hwspinlock core 2019-11-09T00:41:13+00:00 Baolin Wang baolin.wang@linaro.org 2019-10-14T07:07:43+00:00 b2547dce4d4a23e8c4a2b0258e3bd31d43dddfad The original code use BUG_ON() to validate the parameters when locking or unlocking one hardware lock, but we should not crash the whole kernel though the hwlock parameters are incorrect, instead we can return the error number for users and give some warning. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> 
The original code use BUG_ON() to validate the parameters when locking
or unlocking one hardware lock, but we should not crash the whole kernel
though the hwlock parameters are incorrect, instead we can return
the error number for users and give some warning.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
hwspinlock: sprd: Use devm_hwspin_lock_register() to register hwlock controller 2019-10-05T04:10:26+00:00 Baolin Wang baolin.wang@linaro.org 2019-09-27T07:10:47+00:00 b674a30bf8b0edf3b966e32dfcb2e00dfca5a823 Use devm_hwspin_lock_register() to register the hwlock controller instead of unregistering the hwlock controller explicitly when removing the device. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> 
Use devm_hwspin_lock_register() to register the hwlock controller instead of
unregistering the hwlock controller explicitly when removing the device.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
hwspinlock: sprd: Use devm_add_action_or_reset() for calls to clk_disable_unprepare() 2019-10-05T04:09:52+00:00 Baolin Wang baolin.wang@linaro.org 2019-09-27T07:10:46+00:00 b4d64193d41e52a5d35923bc5a0772d9de250092 Use devm_add_action_or_reset() for calls to clk_disable_unprepare(), which can simplify the error handling. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> 
Use devm_add_action_or_reset() for calls to clk_disable_unprepare(),
which can simplify the error handling.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
hwspinlock: sprd: Check the return value of clk_prepare_enable() 2019-10-05T04:07:44+00:00 Baolin Wang baolin.wang@linaro.org 2019-09-27T07:10:45+00:00 3070c41643609c66d33de3577fc9d8ca15932513 We must check the return value of clk_prepare_enable() to make sure the hardware spinlock controller can be enabled successfully, otherwise we should return error. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> 
We must check the return value of clk_prepare_enable() to make sure the
hardware spinlock controller can be enabled successfully, otherwise we
should return error.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
hwspinlock: sprd: Change to use devm_platform_ioremap_resource() 2019-10-05T04:07:19+00:00 Baolin Wang baolin.wang@linaro.org 2019-09-27T07:10:44+00:00 74cfa956cbead238cf6c5307be461a087c569c97 Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together, which can simpify the code. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> 
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together, which can simpify the code.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
hwspinlock: u8500_hsem: Use devm_hwspin_lock_register() to register hwlock controller 2019-10-05T03:20:41+00:00 Baolin Wang baolin.wang@linaro.org 2019-09-27T08:27:43+00:00 acc98c1f2a1b4503588d3b1eb35db9cb76abdd89 Use devm_hwspin_lock_register() to register the hwlock controller instead of unregistering the hwlock controller explicitly when removing the device. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> 
Use devm_hwspin_lock_register() to register the hwlock controller instead of
unregistering the hwlock controller explicitly when removing the device.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
hwspinlock: u8500_hsem: Use devm_kzalloc() to allocate memory 2019-10-05T03:20:20+00:00 Baolin Wang baolin.wang@linaro.org 2019-09-27T08:27:42+00:00 637bcd19beeb9e40b8b64b41e8a8bdf03e918edd Use devm_kzalloc() to allocate memory. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> 
Use devm_kzalloc() to allocate memory.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>