linux-toradex.git/drivers/i2c, branch master

i2c: pxa: Use named initializers for the platform_device_id array

2026-06-18T10:08:49+00:00

Named initializers are better readable and more robust to changes of the
struct definition. This robustness is relevant for a planned change to
struct platform_device_id replacing .driver_data by an anonymous union.

Signed-off-by: Uwe Kleine-König (The Capable Hub) 
Signed-off-by: Andi Shyti 
Link: https://lore.kernel.org/r/827657abb02edb39bc90f7336194f614d383770e.1781688767.git.u.kleine-koenig@baylibre.com

i2c: imx-lpi2c: mark I2C adapter when hardware is powered down

2026-06-17T09:07:50+00:00

On some i.MX platforms, certain I2C client drivers keep a periodic
workqueue which continues to trigger I2C transfers.

During system suspend/resume, there exists a time window between:
  - suspend_noirq and the system entering suspend
  - the system starting to resume and resume_noirq

In this window, the I2C controller resources such as clock and pinctrl
may already be disabled or not yet restored.

If a workqueue triggers an I2C transfer in this period, the driver
attempts to access I2C registers while the hardware resources are
unavailable, which may lead to system hang.

Mark the I2C adapter as suspended during noirq suspend and block new
transfers until resume, ensuring that I2C transfers are only issued
when hardware resources are available.

Fixes: 1ee867e465c1 ("i2c: imx-lpi2c: add target mode support")
Signed-off-by: Carlos Song 
Cc:  # v6.14+
Acked-by: Mukesh Savaliya 
Reviewed-by: Frank Li 
Signed-off-by: Andi Shyti 
Link: https://lore.kernel.org/r/20260525031450.3183421-1-carlos.song@oss.nxp.com

i2c: stm32f7: truncate clock period instead of rounding it

2026-06-17T08:33:05+00:00

stm32f7_i2c_compute_timing() derives the I2C clock source period
(i2cclk) with DIV_ROUND_CLOSEST, which may round it up. When the
period is overestimated, all timings computed from it (SCLDEL,
SDADEL, SCLL, SCLH) come out shorter on the wire than calculated,
and the resulting bus rate can exceed the requested speed, violating
the I2C specification minimums for tLOW and tHIGH.

For example, with a 104.45 MHz clock source (e.g. PCLK1, the
reset-default I2C clock source on STM32MP1), i2cclk is rounded from
9.574 ns up to 10 ns. Requesting a 400 kHz fast mode bus with
72/27 ns rise/fall times and no analog/digital filters then produces
an actual bus rate of 415.6 kHz with tLOW = 1254 ns, violating both
the 400 kHz maximum rate and the 1300 ns tLOW minimum of the
specification.

Truncate the period instead, so that it can only be underestimated.
The error then falls on the safe side: the programmed timings come
out slightly longer than computed and the bus runs marginally below
the target rate (375.3 kHz in the example above) while meeting the
specification.

i2cbus is left rounded-to-closest: it is only used as the target of
the clk_error comparison and is never multiplied into the programmed
timings, so nearest rounding remains accurate there.

Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver")
Signed-off-by: Guillermo Rodríguez 
Cc:  # v4.14+
Acked-by: Alain Volmat 
Reviewed-by: Pierre-Yves MORDRET 
Signed-off-by: Andi Shyti 
Link: https://lore.kernel.org/r/20260611104857.242153-1-guille.rodriguez@gmail.com

i2c: qcom: Unify user-visible "Qualcomm" name

2026-06-16T23:29:02+00:00

Various names for Qualcomm as a company are used in user-visible config
options: QCOM, Qualcomm and Qualcomm Technologies.  Switch to unified
"Qualcomm" so it will be easier for users to identify the options when
for example running menuconfig.

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20260423173550.92317-2-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Andi Shyti

i2c: ls2x-v2: return IRQ_HANDLED after servicing an error

2026-06-16T23:19:53+00:00

The event ISR reads SR1 and, when an error flag (ARLO/AF/BERR) is set,
calls loongson2_i2c_isr_error() which clears the offending flag, issues
STOP for the AF case, records msg->result, masks every CR2 interrupt
enable and completes the waiter. The handler then returns IRQ_NONE,
declaring to the IRQ core that the device did not interrupt.

That report is wrong. The device did interrupt and the handler fully
serviced it. Because the IRQ is requested with IRQF_SHARED, the genirq
spurious-IRQ tracker counts each error as unhandled. A bus that emits
sporadic NACKs, arbitration losses or bus errors will therefore march
toward the spurious-IRQ threshold and the line can end up disabled,
wedging the controller.

Return IRQ_HANDLED on this path. The other IRQ_NONE site, taken when
neither an event nor an error bit is set, remains correct.

Fixes: 6d1b0785f6d5 ("i2c: ls2x-v2: Add driver for Loongson-2K0300 I2C controller")
Signed-off-by: David Carlier 
Assisted-by: Codex:GPT-5.5
Reviewed-by: Binbin Zhou 
Tested-by: Binbin Zhou 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Andi Shyti 
Link: https://lore.kernel.org/r/20260506154015.94815-1-devnexen@gmail.com

i2c: algo: bit: use str_plural helper in bit_xfer

2026-06-16T21:58:35+00:00

Replace the manual ternary "s" pluralizations with str_plural() to
simplify the code.

Signed-off-by: Thorsten Blum 
Signed-off-by: Andi Shyti 
Link: https://lore.kernel.org/r/20260511104911.183606-3-thorsten.blum@linux.dev

i2c: davinci: Unregister cpufreq notifier on probe failure

2026-06-16T12:40:00+00:00

davinci_i2c_probe() registers a cpufreq transition notifier before adding
the I2C adapter.  If i2c_add_numbered_adapter() fails, the probe error path
releases the device resources without unregistering the notifier.

Add a dedicated error path to unregister the cpufreq notifier after
i2c_add_numbered_adapter() fails.

Fixes: 82c0de11b734 ("i2c: davinci: Add cpufreq support")
Signed-off-by: Haoxiang Li 
Cc:  # v2.6.36+
Reviewed-by: Bartosz Golaszewski 
Signed-off-by: Andi Shyti 
Link: https://lore.kernel.org/r/20260610030513.2651018-1-haoxiang_li2024@163.com

i2c: qcom-cci: Remove overcautious disable_irq() calls

2026-06-16T12:40:00+00:00

In cci_probe() the controller's interrupt is requested using a devres
managed API, and in cci_probe() error path and cci_remove() it'd be
safe to rely on devres mechanism to free and shutdown the interrupt,
thus explicit disable_irq() calls can be removed as unnecessary ones.

Signed-off-by: Vladimir Zapolskiy 
Reviewed-by: Loic Poulain 
Reviewed-by: Konrad Dybcio 
Signed-off-by: Andi Shyti 
Link: https://lore.kernel.org/r/20260515234121.1607425-5-vladimir.zapolskiy@linaro.org

i2c: qcom-cci: Move cci_init() under cci_reset() function

2026-06-16T12:39:59+00:00

On probe or runtime errors cci_reset() is called and it should be coupled
with cci_init(), instead of doing this on caller's side, embed cci_init()
directly into the cci_reset() function.

This is a non-functional change, cci_reset() and cci_init() function
bodies are reordered.

Signed-off-by: Vladimir Zapolskiy 
Reviewed-by: Loic Poulain 
Reviewed-by: Konrad Dybcio 
Signed-off-by: Andi Shyti 
Link: https://lore.kernel.org/r/20260515234121.1607425-4-vladimir.zapolskiy@linaro.org

i2c: qcom-cci: Do not check return value of cci_init()

2026-06-16T12:39:56+00:00

The cci_init() function is not supposed to fail, and it never returns
a non-zero, so it'd make sense to convert its signature to void.

Signed-off-by: Vladimir Zapolskiy 
Reviewed-by: Loic Poulain 
Reviewed-by: Konrad Dybcio 
Signed-off-by: Andi Shyti 
Link: https://lore.kernel.org/r/20260515234121.1607425-3-vladimir.zapolskiy@linaro.org