linux-toradex.git/drivers/i3c, branch v6.2-rc2

i3c: export SETDASA method

2022-12-11T20:25:58+00:00

Because not all I3C drivers have the hot-join feature ready, and
especially not all I3C devices support hot-join feature, exporting
SETDASA method could be useful. With this function, the I3C controller
could perform a DAA to I3C devices when users decide to turn these I3C
devices off and on again during run-time.

Tested: This change has been tested with turnning off an I3C device and
turning on it again during run-time. The device driver calls SETDASA
method to perform DAA to the device. And communication between I3C
controller and device is set up again correctly.

Signed-off-by: Jack Chen 
Link: https://lore.kernel.org/r/20221207205059.3848851-1-zenghuchen@google.com
Signed-off-by: Alexandre Belloni

i3c: master: Remove the wrong place of reattach.

2022-10-12T21:45:29+00:00

The reattach should be used when an I3C device has its address changed.
But the modified place in this patch doesn't have the address changed of
the newdev. This wrong reattach will reserve the same address slot twice
and return unexpected -EBUSY when the bus find the duplicate device with
diffent dynamic address.

Signed-off-by: Billy Tsai 
Link: https://lore.kernel.org/r/20220926105145.8145-2-billy_tsai@aspeedtech.com
Signed-off-by: Alexandre Belloni

i3c: master: Free the old_dyn_addr when reattach.

2022-10-12T21:45:29+00:00

This patch is used to free the old_dyn_addr when the caller want to
reattach the device to the different dynamic address. If the
old_dyn_addr is 0 the function will treat it as no old_dyn_addr is
reserved on the bus. Without the patch, when the driver reattach the i3c
device after setnewda the old_dyn_addr will be permanently occupied.

Signed-off-by: Billy Tsai 
Link: https://lore.kernel.org/r/20220926105145.8145-1-billy_tsai@aspeedtech.com
Signed-off-by: Alexandre Belloni

i3c: master: svc: fix returnvar.cocci warning

2022-05-17T20:34:42+00:00

Fix the following coccicheck warning:

drivers/i3c/master/svc-i3c-master.c:1600:5-8:
Unneeded variable: "ret". Return "0" on line 1605.

Signed-off-by: Guo Zhengkui 
Reviewed-by: Miquel Raynal 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20220504164901.9622-1-guozhengkui@vivo.com

i3c/master: simplify the return expression of i3c_hci_remove()

2022-05-17T20:33:43+00:00

Simplify the return expression.

Reported-by: Zeal Robot 
Signed-off-by: Minghao Chi 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20220505021954.54524-1-chi.minghao@zte.com.cn

i3c: fix uninitialized variable use in i2c setup

2022-03-08T21:33:52+00:00

Commit 31b9887c7258 ("i3c: remove i2c board info from i2c_dev_desc")
removed the boardinfo from i2c_dev_desc to decouple device enumeration from
setup but did not correctly lookup the i2c_dev_desc to store the new
device, instead dereferencing an uninitialized variable.

Lookup the device that has already been registered by address to store
the i2c client device.

Fixes: 31b9887c7258 ("i3c: remove i2c board info from i2c_dev_desc")
Reported-by: kernel test robot 
Cc: Alexandre Belloni 
Signed-off-by: Jamie Iles 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20220308134226.1042367-1-quic_jiles@quicinc.com

i3c: support dynamically added i2c devices

2022-03-04T10:39:03+00:00

I2C devices can be added to the system dynamically through several
sources other than static board info including device tree overlays and
sysfs i2c new_device.

Add an I2C bus notifier to attach the clients at runtime if they were
not defined in the board info.  For DT devices find the LVR in the reg
property, for user-space new_device additions we synthesize a
conservative setting of no spike filters and fast mode only.

Cc: Alexandre Belloni 
Signed-off-by: Jamie Iles 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20220117174816.1963463-3-quic_jiles@quicinc.com

i3c: remove i2c board info from i2c_dev_desc

2022-03-04T10:39:03+00:00

I2C board info is only required during adapter setup so there is no
requirement to keeping a pointer to it once running.  To support dynamic
device addition we can't rely on board info - user-space creation
through sysfs won't have a boardinfo.

Cc: Alexandre Belloni 
Signed-off-by: Jamie Iles 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20220117174816.1963463-2-quic_jiles@quicinc.com

i3c: master: dw: check return of dw_i3c_master_get_free_pos()

2022-01-13T01:05:50+00:00

Clang static analysis reports this problem
dw-i3c-master.c:799:9: warning: The result of the left shift is
  undefined because the left operand is negative
                      COMMAND_PORT_DEV_INDEX(pos) |
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~

pos can be negative because dw_i3c_master_get_free_pos() can return an
error.  So check for an error.

Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
Signed-off-by: Tom Rix 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20220108150948.3988790-1-trix@redhat.com

i3c: master: mipi-i3c-hci: correct the config reference for endianness

2022-01-05T08:54:54+00:00

The referred config BIG_ENDIAN does not exist. The config for the
endianness of the CPU architecture is called CPU_BIG_ENDIAN.

Correct the config name to the existing config for the endianness.

Signed-off-by: Lukas Bulwahn 
Acked-by: Nicolas Pitre 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20220103094504.3602-1-lukas.bulwahn@gmail.com