<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux-toradex.git/drivers/ide/ide-cd_ioctl.c, branch v2.6.25.4</title>
<subtitle>Linux kernel for Apalis and Colibri modules</subtitle>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/'/>
<entry>
<title>ide-cd: mark REQ_TYPE_ATA_PC write requests with REQ_RW flag</title>
<updated>2008-03-07T20:53:49+00:00</updated>
<author>
<name>Bartlomiej Zolnierkiewicz</name>
<email>bzolnier@gmail.com</email>
</author>
<published>2008-03-07T20:53:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=b348487f0dc06f09a4c0d9e353eaa66e70230c7d'/>
<id>b348487f0dc06f09a4c0d9e353eaa66e70230c7d</id>
<content type='text'>
On Thursday 06 March 2008, walt wrote:

&gt; For me, this commit causes the problem it's intended to fix:
&gt; 
&gt; commit 9f10d9ee0ac6d79d7bc8b9a158bf4a29322d84d3
&gt; Author: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
&gt; Date:   Tue Feb 26 21:50:35 2008 +0100
&gt; 
&gt;      ide-cd: fix 'ireason' handling for REQ_TYPE_ATA_PC requests
&gt; 
&gt;      This fixes some hangs caused by not finishing the transfer before ending
&gt;      the request and also makes use of 'ireason == 1' quirk for spurious IRQs.
&gt; 
&gt; When I mount a CD there is a long delay, and I see this error message:
&gt; 
&gt; hdc: ide_cd_check_ireason: wrong transfer direction!
&gt; cdrom: failed setting lba address space
&gt; hdc: status error: status=0x58 { DriveReady SeekComplete DataRequest }
&gt; ide: failed opcode was: unknown
&gt; hdc: drive not ready for command
&gt; &lt;repeated many times&gt;
&gt; 
&gt; When I revert this commit everything works properly again, including
&gt; CD burning.

It turned out that REQ_TYPE_ATA_PC write requests were not marked as such
(the previous commit assumed them to be).

Reported-by: walt &lt;w41ter@gmail.com&gt;
Tested-by: walt &lt;w41ter@gmail.com&gt;
Reviewed-by: Borislav Petkov &lt;petkovbb@googlemail.com&gt;
Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
On Thursday 06 March 2008, walt wrote:

&gt; For me, this commit causes the problem it's intended to fix:
&gt; 
&gt; commit 9f10d9ee0ac6d79d7bc8b9a158bf4a29322d84d3
&gt; Author: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
&gt; Date:   Tue Feb 26 21:50:35 2008 +0100
&gt; 
&gt;      ide-cd: fix 'ireason' handling for REQ_TYPE_ATA_PC requests
&gt; 
&gt;      This fixes some hangs caused by not finishing the transfer before ending
&gt;      the request and also makes use of 'ireason == 1' quirk for spurious IRQs.
&gt; 
&gt; When I mount a CD there is a long delay, and I see this error message:
&gt; 
&gt; hdc: ide_cd_check_ireason: wrong transfer direction!
&gt; cdrom: failed setting lba address space
&gt; hdc: status error: status=0x58 { DriveReady SeekComplete DataRequest }
&gt; ide: failed opcode was: unknown
&gt; hdc: drive not ready for command
&gt; &lt;repeated many times&gt;
&gt; 
&gt; When I revert this commit everything works properly again, including
&gt; CD burning.

It turned out that REQ_TYPE_ATA_PC write requests were not marked as such
(the previous commit assumed them to be).

Reported-by: walt &lt;w41ter@gmail.com&gt;
Tested-by: walt &lt;w41ter@gmail.com&gt;
Reviewed-by: Borislav Petkov &lt;petkovbb@googlemail.com&gt;
Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ide-cd: move the remaining cdrom.c ioctl handling code to ide-cd_ioctl.c</title>
<updated>2008-02-01T22:09:29+00:00</updated>
<author>
<name>Borislav Petkov</name>
<email>bbpetkov@yahoo.de</email>
</author>
<published>2008-02-01T22:09:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=f9afd18b5827be93fd9fb3cc84ab9bba38b00db8'/>
<id>f9afd18b5827be93fd9fb3cc84ab9bba38b00db8</id>
<content type='text'>
There should be no functional changes from this.

Signed-off-by: Borislav Petkov &lt;bbpetkov@yahoo.de&gt;
Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There should be no functional changes from this.

Signed-off-by: Borislav Petkov &lt;bbpetkov@yahoo.de&gt;
Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ide-cd: move code handling cdrom.c IOCTLs to ide-cd_ioctl.c</title>
<updated>2008-02-01T22:09:25+00:00</updated>
<author>
<name>Bartlomiej Zolnierkiewicz</name>
<email>bzolnier@gmail.com</email>
</author>
<published>2008-02-01T22:09:25+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=17802998d2c8007d06565c39101d218f579c4454'/>
<id>17802998d2c8007d06565c39101d218f579c4454</id>
<content type='text'>
There should be no functionality changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There should be no functionality changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
