linux-toradex.git/drivers/ide/ide-dma.c, branch v2.6.30.5

ide: relax DMA info validity checking

2009-08-16T21:18:48+00:00

commit 346c17a6cf60375323adfaa4b8a9d841049f890e upstream.

There are some broken devices that report multiple DMA xfer modes
enabled at once (ATA spec doesn't allow it) but otherwise work fine
with DMA so just delete ide_id_dma_bug().

[ As discovered by detective work by Frans and Bart, due to how
  handling of the ID block was handled before commit c419993
  ("ide-iops: only clear DMA words on setting DMA mode") this
  check was always seeing zeros in the fields or other similar
  garbage.  Therefore this check wasn't actually checking anything.
  Now that the tests actually check the real bits, all we see are
  devices that trigger the check yet work perfectly fine, therefore
  killing this useless check is the best thing to do. -DaveM ]

Reported-by: Frans Pop 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ide: add support for CFA specified transfer modes (take 3)

2009-03-31T18:15:28+00:00

Add support for the CompactFlash specific PIO modes 5/6 and MWDMA modes 3/4.

Since there were no PIO5 capable hard drives produced and one would also need
66 MHz IDE clock to actually get the difference WRT the address setup timings
programmed, I decided to simply replace the old non-standard PIO mode 5 timings
with the CFA specified ones.

Signed-off-by: Sergei Shtylyov 
Cc: stf_xl@wp.pl
Signed-off-by: Bartlomiej Zolnierkiewicz

ide: identify data word 53 bit 1 doesn't cover words 62 and 63 (take 3)

2009-03-31T18:15:27+00:00

The IDE code assumed for years that the bit 1 of the identify data word 53 also
covers the validity of the SW/MW DMA information in words 62 and 63, but it has
always covered only words 64 thru 70, with words 62 and 63 being defined in the
original ATA spec, not in ATA-2...

This fix however should only concern *very* old hard disks and rather old CF
cards...

Signed-off-by: Sergei Shtylyov 
Signed-off-by: Bartlomiej Zolnierkiewicz

ide: sanitize ide_build_sglist() and ide_destroy_dmatable()

2009-03-31T18:15:24+00:00

* Move ide_map_sg() calls out from ide_build_sglist()
  to ide_dma_prepare().

* Pass command to ide_destroy_dmatable().

* Rename ide_build_sglist() to ide_dma_map_sg()
  and ide_destroy_dmatable() to ide_dma_unmap_sg().

There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz

ide: set/clear drive->waiting_for_dma flag in the core code

2009-03-31T18:15:22+00:00

Set/clear drive->waiting_for_dma flag in the core code
instead of in ->dma_setup and ->dma_end methods.

There should be no functional changes caused by this patch.

Acked-by: Sergei Shtylyov 
Signed-off-by: Bartlomiej Zolnierkiewicz

ide: move ide_map_sg() call out of ->dma_setup method (take 2)

2009-03-31T18:15:21+00:00

Move ide_map_sg() call from ->dma_setup implementations and
ide_destroy_dmatable() one from *_build_dmatable() to ide_dma_prepare().

There should be no functional changes caused by this patch.

Sergei:
Removed 'use_pio_instead' labels and replaced 'goto' with 'return 0' --
that required no changes to the follow-up patches...

Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Sergei Shtylyov 
Signed-off-by: Bartlomiej Zolnierkiewicz

ide: add ->dma_check method

2009-03-31T18:15:21+00:00

* Add (an optional) ->dma_check method for checking if DMA can be
  used for a given command and fail DMA setup in ide_dma_prepare()
  if necessary.

* Convert alim15x3 and trm290 host drivers to use ->dma_check.

* Rename ali15x3_dma_setup() to ali_dma_check() while at it.

There should be no functional changes caused by this patch.

Acked-by: Sergei Shtylyov 
Signed-off-by: Bartlomiej Zolnierkiewicz

ide: add ide_dma_prepare() helper

2009-03-31T18:15:20+00:00

* Add ide_dma_prepare() helper.

* Convert ide_issue_pc() and do_rw_taskfile() to use it.

* Make ide_build_sglist() static.

There should be no functional changes caused by this patch.

Acked-by: Sergei Shtylyov 
Signed-off-by: Bartlomiej Zolnierkiewicz

ide: destroy DMA mappings after ending DMA (v2)

2009-03-31T18:15:20+00:00

Move ide_destroy_dmatable() call out from ->dma_end method to
{ide_pc,cdrom_newpc,ide_dma}_intr(), ide_dma_timeout_retry()
and sgiioc4_resetproc().

This causes minor/safe behavior changes w.r.t.:
* cmd64x.c::cmd64{8,x}_dma_end()
* cs5536.c::cs5536_dma_end()
* icside.c::icside_dma_end()
* it821x.c::it821x_dma_end()
* scc_pata.c::__scc_dma_end()
* sl82c105.c::sl82c105_dma_end()
* tx4939ide.c::tx4939ide_dma_end()

v2:
* Fix build for CONFIG_BLK_DEV_IDEDMA=n (reported by Randy Dunlap).

Cc: Randy Dunlap 
Acked-by: Sergei Shtylyov 
Signed-off-by: Bartlomiej Zolnierkiewicz

ide: inline ide_dma_timeout() into ide_dma_timeout_retry()

2009-03-31T18:15:19+00:00

Since ide_dma_timeout() is only used by ide_dma_timeout_retry()
inline it there.

There should be no functional changes caused by this patch.

Acked-by: Sergei Shtylyov 
Signed-off-by: Bartlomiej Zolnierkiewicz