linux-toradex.git/drivers/ide/ide-floppy_ioctl.c, branch v2.6.32.33

ide-atapi: remove pc->buf

2009-05-15T04:44:38+00:00

Now after all users of pc->buf have been converted, remove the 64B buffer
embedded in each packet command.

There should be no functional change resulting from this patch.

Signed-off-by: Borislav Petkov

ide-floppy/ide_floppy_get_format_progress: use local sense buffer

2009-05-15T04:44:28+00:00

There should be no functional change resulting from this patch.

Signed-off-by: Borislav Petkov

ide-floppy/ide_floppy_format_unit: use local buffer

2009-05-15T04:44:20+00:00

Pass the buffer into ide_floppy_create_format_unit_cmd instead of using
pc->buf.

There should be no functional change resulting from this patch.

Signed-off-by: Borislav Petkov

ide-floppy/ide_floppy_get_sfrp_bit: use local buffer

2009-05-15T04:44:17+00:00

There should be no functional change resulting from this patch.

Signed-off-by: Borislav Petkov

ide-atapi: add a buffer-arg to ide_queue_pc_tail

2009-05-15T04:44:09+00:00

This is in preparation of removing ide_atapi_pc. Expose the buffer as an
argument to ide_queue_pc_tail with later replacing it with local buffer
or even kmalloc'ed one if needed due to stack usage constraints.

Also, add the possibility of passing a NULL-ptr buffer for cmds which
don't transfer data besides the cdb. While at it, switch to local buffer
in idetape_get_mode_sense_results().

There should be no functional change resulting from this patch.

Signed-off-by: Borislav Petkov

ide-atapi: add a len-parameter to ide_queue_pc_tail

2009-05-15T04:44:06+00:00

This is in preparation for removing ide_atapi_pc.

There should be no functional change resulting from this patch.

Signed-off-by: Borislav Petkov

ide: decrease size of ->pc_buf field in struct ide_atapi_pc

2009-03-31T18:15:25+00:00

struct ide_atapi_pc is often allocated on the stack and size of ->pc_buf
size is 256 bytes.  However since only ide_floppy_create_read_capacity_cmd()
and idetape_create_inquiry_cmd() require such size allocate buffers for
these pc-s explicitely and decrease ->pc_buf size to 64 bytes.

Cc: Borislav Petkov 
Signed-off-by: Bartlomiej Zolnierkiewicz

ide-floppy: allocate only toplevel packet commands

2009-01-02T15:12:51+00:00

This makes the top-level function just allocate a single pc entry, and then
pass it down as a pointer to all the helper functions that also need one
of those "struct ide_atapi_pc" things. As far as I can tell, the use of
these things never overlaps each other, BUT I DID NOT CHECK VERY CLOSELY!

So I'm not guaranteeing this is correct, and I don't have the hardware. It
would be good for somebody who knows the code more, and has the hardware,
could please test this?

With this, ide-floppy still has fairly big stack usage, but instead of

	idefloppy_ioctl [vmlinux]:              1208
	ide_floppy_get_capacity [vmlinux]:      872
	idefloppy_release [vmlinux]:            408
	idefloppy_open [vmlinux]:               408

where those two first ones are at the very top of the list of stack users
for me, it's now

	ide_floppy_get_capacity [vmlinux]:           404
	ide_floppy_ioctl [vmlinux]:                  364

ie they are still high, but they are no longer at the top.

Borislav: Since ide_floppy_get_capacity is passed as a function pointer to other
parts of the kernel (e.g., block layer) we need that ide_atapi_pc to be created
on stack. Also, redid stack users numbers above. The two functions missing from
Linus' original 'make stackusage' output are due to ide being
rewritten/reorganized atm.

Signed-off-by: Linus Torvalds 
Signed-off-by: Borislav Petkov 
Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH] switch ide_disk_ops ->ioctl() to sane prototype

2008-10-21T11:47:30+00:00

Signed-off-by: Al Viro

[PATCH] lose the unused file argument in generic_ide_ioctl()

2008-10-21T11:47:16+00:00

Signed-off-by: Al Viro