linux-toradex.git/drivers/ide/ide-io.c, branch v3.3.4

ide: always ensure that blk_delay_queue() is called if we have pending IO

2011-04-05T21:52:49+00:00

Just because we are not requeuing a request does not mean that
some aren't pending. So always issue a blk_delay_queue() if
either we are requeueing OR there's pending IO.

This fixes a boot problem for some IDE boxes.

Signed-off-by: Jens Axboe

ide: ide_requeue_and_plug() reinstate "always plug" behaviour

2011-04-05T21:51:37+00:00

We see stalls if we don't always ensure that the queue gets run
again. Even if rq == NULL, we could have other pending requests
in the queue.

Signed-off-by: Jens Axboe

ide: ensure that we re-run the queue handler

2011-03-26T18:49:54+00:00

The conversion to blk_delay_queue() missed parts of IDE.
Add a blk_delay_queue() to ensure that the request handler
gets reinvoked when it needs to.

Note that in all but one place the old plug re-run delay of
3 msecs is used, even though it probably could be shorter
for performance reasons in some of those cases.

Reported-by: Geert Uytterhoeven 
Signed-off-by: Jens Axboe

block: remove per-queue plugging

2011-03-10T07:52:07+00:00

Code has been converted over to the new explicit on-stack plugging,
and delay users have been converted to use the new API for that.
So lets kill off the old plugging along with aops->sync_page().

Signed-off-by: Jens Axboe

ide: remove unnecessary blk_queue_flushing() test in do_ide_request()

2010-09-10T10:35:36+00:00

Unplugging from a request function doesn't really help much (it's
already in the request_fn) and soon block layer will be updated to mix
barrier sequence with other commands, so there's no need to treat
queue flushing any differently.

ide was the only user of blk_queue_flushing().  Remove it.

Signed-off-by: Tejun Heo 
Cc: Christoph Hellwig 
Acked-by: David S. Miller 
Signed-off-by: Jens Axboe

block: fix some more cmd_type cleanup fallout

2010-08-07T16:22:29+00:00

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: remove wrappers for request type/flags

2010-08-07T16:17:56+00:00

Remove all the trivial wrappers for the cmd_type and cmd_flags fields in
struct requests.  This allows much easier grepping for different request
types instead of unwinding through macros.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

ide: Requeue request after DMA timeout

2010-04-01T08:31:13+00:00

I noticed that my KVM virtual machines were experiencing IDE
issues resulting in processes stuck on waiting for buffers to
complete.

The root cause is of course race conditions in the ancient qemu
backend that I'm using.  However, the fact that the guest isn't
recovering is a bug.

I've tracked it down to the change made last year to dequeue
requests at the start rather than at the end in the IDE layer.

commit 8f6205cd572fece673da0255d74843680f67f879
Author: Tejun Heo 
Date:   Fri May 8 11:53:59 2009 +0900

    ide: dequeue in-flight request

The problem is that the function ide_dma_timeout_retry does not
requeue the current request, causing one request to be lost for
each DMA timeout.

This patch fixes this by requeueing the request.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

Revert "ide: improve handling of Power Management requests"

2009-07-06T19:39:27+00:00

This reverts commit a1317f714af7aed60ddc182d0122477cbe36ee9b.

ide: always kill the whole request on error

2009-06-26T06:57:16+00:00

* Use blk_rq_bytes() instead of obsolete ide_rq_bytes() in ide_kill_rq()
  and ide_floppy_do_request() for failed requests.
  [ bugfix part ]

* Use blk_rq_bytes() instead of obsolete ide_rq_bytes() in ide_do_devset()
  and ide_complete_drive_reset().  Then remove ide_rq_bytes().
  [ cleanup part ]

Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: David S. Miller