linux-toradex.git/drivers/ide/ide-taskfile.c, branch v2.6.27-rc4 Linux kernel for Apalis and Colibri modules ide: enable local IRQs in all handlers for TASKFILE_NO_DATA data phase 2008-07-24T20:53:36+00:00 Bartlomiej Zolnierkiewicz bzolnier@gmail.com 2008-07-24T20:53:36+00:00 90d2c6bc68745d67cdbf00bab43818d90aa0dfb6 It is already done by task_no_data_intr() and there is no reason not to do it in other TASKFILE_NO_DATA data phase handlers. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> 
It is already done by task_no_data_intr() and there is no reason
not to do it in other TASKFILE_NO_DATA data phase handlers.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide: add struct ide_tp_ops (take 2) 2008-07-23T17:55:56+00:00 Bartlomiej Zolnierkiewicz bzolnier@gmail.com 2008-07-23T17:55:56+00:00 374e042c3e767ac2e5a40b78529220e0b3de793c * Add struct ide_tp_ops for transport methods. * Add 'const struct ide_tp_ops *tp_ops' to struct ide_port_info and ide_hwif_t. * Set the default hwif->tp_ops in ide_init_port_data(). * Set host driver specific hwif->tp_ops in ide_init_port(). * Export ide_exec_command(), ide_read_status(), ide_read_altstatus(), ide_read_sff_dma_status(), ide_set_irq(), ide_tf_{load,read}() and ata_{in,out}put_data(). * Convert host drivers and core code to use struct ide_tp_ops. * Remove no longer needed default_hwif_transport(). * Cleanup ide_hwif_t from methods that are now in struct ide_tp_ops. While at it: * Use struct ide_port_info in falconide.c and q40ide.c. * Rename ata_{in,out}put_data() to ide_{in,out}put_data(). v2: * Fix missing convertion in ns87415.c. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> 
* Add struct ide_tp_ops for transport methods.

* Add 'const struct ide_tp_ops *tp_ops' to struct ide_port_info
  and ide_hwif_t.

* Set the default hwif->tp_ops in ide_init_port_data().

* Set host driver specific hwif->tp_ops in ide_init_port().

* Export ide_exec_command(), ide_read_status(), ide_read_altstatus(),
  ide_read_sff_dma_status(), ide_set_irq(), ide_tf_{load,read}()
  and ata_{in,out}put_data().

* Convert host drivers and core code to use struct ide_tp_ops.

* Remove no longer needed default_hwif_transport().

* Cleanup ide_hwif_t from methods that are now in struct ide_tp_ops.

While at it:

* Use struct ide_port_info in falconide.c and q40ide.c.

* Rename ata_{in,out}put_data() to ide_{in,out}put_data().

v2:

* Fix missing convertion in ns87415.c.

There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide: add ->set_irq method 2008-07-23T17:55:52+00:00 Bartlomiej Zolnierkiewicz bzolnier@gmail.com 2008-07-23T17:55:52+00:00 6e6afb3b7401f0181da74a1add57f126946b43e6 Add ->set_irq method for setting nIEN bit of ATA Device Control register and use it instead of ide_set_irq(). While at it: * Use ->set_irq in init_irq() and do_reset1(). * Don't use HWIF() macro in ide_check_pm_state(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> 
Add ->set_irq method for setting nIEN bit of ATA Device Control
register and use it instead of ide_set_irq().

While at it:

* Use ->set_irq in init_irq() and do_reset1().

* Don't use HWIF() macro in ide_check_pm_state().

There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide: add ->read_status method 2008-07-23T17:55:52+00:00 Bartlomiej Zolnierkiewicz bzolnier@gmail.com 2008-07-23T17:55:52+00:00 b73c7ee25da6133f97f47ffd3557288417da7c76 * Remove ide_read_status() inline helper. * Add ->read_status method for reading ATA Status register and use it instead of ->INB. While at it: * Don't use HWGROUP() macro. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> 
* Remove ide_read_status() inline helper.

* Add ->read_status method for reading ATA Status register
  and use it instead of ->INB.

While at it:

* Don't use HWGROUP() macro.

There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide: add ->exec_command method 2008-07-23T17:55:51+00:00 Bartlomiej Zolnierkiewicz bzolnier@gmail.com 2008-07-23T17:55:51+00:00 c6dfa867bb45f4bff2e48f3bc89ab1d6a7ab4c21 Add ->exec_command method for writing ATA Command register and use it instead of ->OUTBSYNC. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> 
Add ->exec_command method for writing ATA Command register
and use it instead of ->OUTBSYNC.

There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide: remove needless includes from ide-taskfile.c (take 2) 2008-07-16T18:33:44+00:00 Bartlomiej Zolnierkiewicz bzolnier@gmail.com 2008-07-16T18:33:44+00:00 ad15e9fc8913b704978ffdda7d1f31c79ed6814d v2: On Sunday 15 June 2008, Geert Uytterhoeven wrote: > As ide-taskfile.c uses scatterlists, it should include <linux/scatterlist.h>. (v1 broke IDE build on m68k, thanks to Geert for finding the bug) Cc: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> 
v2:

On Sunday 15 June 2008, Geert Uytterhoeven wrote:
> As ide-taskfile.c uses scatterlists, it should include <linux/scatterlist.h>.

(v1 broke IDE build on m68k, thanks to Geert for finding the bug)

Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide: remove superfluous BUG_ON() from set_geometry_intr() 2008-07-16T18:33:43+00:00 Bartlomiej Zolnierkiewicz bzolnier@gmail.com 2008-07-16T18:33:43+00:00 605cfe8270cb182f494575c5a608404bb19fdfc5 ide_set_handler() bugs on ->handler == NULL so no need to do it in set_geometry_intr(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> 
ide_set_handler() bugs on ->handler == NULL so no need to do it
in set_geometry_intr().

There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide: allow any command requesting DMA data phase for HDIO_DRIVE_TASKFILE 2008-07-16T18:33:43+00:00 Bartlomiej Zolnierkiewicz bzolnier@gmail.com 2008-07-16T18:33:43+00:00 07fe69d5d0b6e476cecaf75e81c0c6093571087b Allow any command requesting DMA data phase for HDIO_DRIVE_TASKFILE ioctl and remove no longer needed task_dma_ok() Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> 
Allow any command requesting DMA data phase for HDIO_DRIVE_TASKFILE ioctl
and remove no longer needed task_dma_ok()

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide: pass 'hwif *' instead of 'drive *' to ->OUTBSYNC method 2008-07-15T19:21:49+00:00 Bartlomiej Zolnierkiewicz bzolnier@gmail.com 2008-07-15T19:21:49+00:00 f8c4bd0ab2b8783c0f080957781e9f70bee48eaa There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> 
There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide: move IRQ unmasking out from ->tf_load method 2008-07-15T19:21:48+00:00 Bartlomiej Zolnierkiewicz bzolnier@gmail.com 2008-07-15T19:21:48+00:00 ed4af48fd660176680da905817f6e40d51436e4c Move IRQ unmasking out from ->tf_load method to its users. There should be no functional changes caused by this patch (SELECT_MASK() is NOP except for hpt366, icside and sgiioc4). Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> 
Move IRQ unmasking out from ->tf_load method to its users.

There should be no functional changes caused by this patch
(SELECT_MASK() is NOP except for hpt366, icside and sgiioc4).

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>