linux-toradex.git/drivers/ide, branch v2.6.20.21

ide: use correct IDE error recovery

2007-04-13T20:47:05+00:00

ide: use correct IDE error recovery

IDE error recovery is using IDLE IMMEDIATE if the drive is busy or has DRQ set.
This violates the ATA spec (can only send IDLEÃ IMMEDIATE when drive is not
busy) and really hoses up some drives (modern drives will not be able to
recover using this error handling).  The correct thing to do is issue a SRST
followed by a SET FEATURES command.  This is what Western Digital recommends
for error recovery and what Western Digital says Windows does. Ã ItÃ also does
not violate the ATA spec as far as I can tell.

Bart:
* port the patch over the current tree
* undo the recalibration code removal
* send SET FEATURES command after checking for good drive status
* don't check whether the current request is of REQ_TYPE_ATA_{CMD,TASK}
  type because we need to send SET FEATURES before handling any requests
* some pre-ATA4 drives require INITIALIZE DEVICE PARAMETERS command before
  other commands (except IDENTIFY) so send SET FEATURES only if there are
  no pending drive->special requests
* update comments and patch description
* any bugs introduced by this patch are mine and not Suleiman's :-)

Signed-off-by: Suleiman Souhlal 
Acked-by: Alan Cox 
Cc: Chuck Ebbert 
Signed-off-by: Bartlomiej Zolnierkiewicz

ide: revert "ide: fix drive side 80c cable check, take 2" for now

2007-04-06T10:43:16+00:00

"ide: fix drive side 80c cable check, take 2" patch from Tejun Heo (commit
fab59375b9543f84d1714f7dd00f5d11e531bd3e) fixed 80c bit test (bit13 of word93)
but we also need to fix master/slave IDENTIFY order (slave device should be
probed first in order to make it release PDIAG- signal) and we should also
check for pre-ATA3 slave devices (which may not release PDIAG- signal).

Unfortunately the fact that IDE driver doesn't reset devices itself helps
only a bit as it seems that some BIOS-es reset ATA devices after programming
the chipset, some BIOS-es can be set to not probe/configure selected devices,
there may be no BIOS in case of add-on cards etc.

Since we are quite late in the release cycle and the required changes will
affect a lot of systems just revert the fix for now.

[ Please also see libata commit f31f0cc2f0b7527072d94d02da332d9bb8d7d94c. ]

Cc: Chuck Ebbert 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Greg Kroah-Hartman

jmicron: make ide jmicron driver play nice with libata ones

2007-04-06T10:43:16+00:00

jmicron: make ide jmicron driver play nice with libata ones

When libata is configured, the device is configured such that SATA and
PATA ports live in separate functions with different programming
interfaces.  pata_jmicron and ide jmicron drivers can drive only the
PATA part.

This patch makes jmicron match PCI class code such that it doesn't
attach itself to the SATA part preventing the proper ahci driver from
attaching.

This change is suggested by Bartlomiej.

Signed-off-by: Tejun Heo 
Cc: Jeff Garzik 
Cc: justin@jmicron.com
Cc: Chuck Ebbert 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Greg Kroah-Hartman

ide: remove clearing bmdma status from cdrom_decode_status() (rev #4)

2007-04-06T10:43:11+00:00

ide: remove clearing bmdma status from cdrom_decode_status() (rev #4)

patch 2/2:
  Remove clearing bmdma status from cdrom_decode_status() since ATA devices
  might need it as well.

  (http://lkml.org/lkml/2006/12/4/201 and http://lkml.org/lkml/2006/11/15/94)

Signed-off-by: Albert Lee 
Cc: Sergei Shtylyov 
Cc: Alan Cox 
Cc: "Adam W. Hawks" 
Cc: Chuck Ebbert 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Greg Kroah-Hartman

ide: clear bmdma status in ide_intr() for ICHx controllers (revised #4)

2007-04-06T10:43:11+00:00

ide: clear bmdma status in ide_intr() for ICHx controllers (revised #4)

patch 1/2 (revised):
- Fix drive->waiting_for_dma to work with CDB-intr devices.
- Do the dma status clearing in ide_intr() and add a new
  hwif->ide_dma_clear_irq for Intel ICHx controllers.

Revised per Alan, Sergei and Bart's advice.

Patch against 2.6.20-rc6. Tested ok on my ICH4 and pdc20275 adapters.
Please review/apply, thanks.

Signed-off-by: Albert Lee 
Cc: Sergei Shtylyov 
Cc: Alan Cox 
Cc: Adam Hawks 
Cc: Chuck Ebbert 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Greg Kroah-Hartman

ide: fix drive side 80c cable check

2007-03-09T18:50:18+00:00

eighty_ninty_three() had word 93 validitity check but not the 80c bit
test itself (bit 12).  This increases the chance of incorrect wire
detection especially because host side cable detection is often
unreliable and we sometimes soley depend on drive side cable
detection.  Fix it.

Signed-off-by: Tejun Heo 
Acked-by: Alan 
Signed-off-by: Greg Kroah-Hartman

[PATCH] via82cxxx: fix typo ("cx7000" should be corrected to "cx700")

2007-02-02T00:24:03+00:00

Noticed by JosephChan@via.com.tw.

Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Linus Torvalds

[PATCH] ide section fixes

2007-02-02T00:17:06+00:00

a) cleanup_module() should be __exit
b) externs should match reality

Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds

[PATCH] jmicron: 40/80pin primary detection

2007-01-31T00:01:35+00:00

jmicron module detects all JMB36x as JMB361 and PATA0 has wrong pin status
of XICBLID.

Cc: Jeff Garzik 
Cc: Alan Cox 
Cc: Bartlomiej Zolnierkiewicz 
Cc: Sergei Shtylyov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

via82cxxx/pata_via: correct PCI_DEVICE_ID_VIA_SATA_EIDE ID and add support for CX700 and 8237S

2007-01-27T12:47:08+00:00

This patch:
* Corrects the wrong device ID of PCI_DEVICE_ID_VIA_SATA_EIDE
  from 0x0581 to 0x5324.
* Adds VIA CX700 and VT8237S support in drivers/ide/pci/via82cxxx.c
* Adds VIA VT8237S support in drivers/ata/pata_via.c

Signed-off-by: Josepch Chan 
Signed-off-by: Bartlomiej Zolnierkiewicz