linux-toradex.git/drivers/ieee1394, branch v2.6.24.4

ieee1394: iso and async streams: s/g list fix

2007-11-04T13:31:16+00:00

Torsten Kaiser wrote:
> Looking that calltrace upwards, it seems replacing the
> memset(dma->sglist,...) with sg_init_table(...) would fix the BUG_ON()
> as that inits the SG_MAGIC.

Tested-by: Torsten Kaiser 
Signed-off-by: Stefan Richter

cleanup asm/scatterlist.h includes

2007-11-02T07:47:06+00:00

Not architecture specific code should not #include .

This patch therefore either replaces them with
#include  or simply removes them if they were
unused.

Signed-off-by: Adrian Bunk 
Signed-off-by: Jens Axboe

ieee1394: ieee1394_transactions.c: remove dead code

2007-10-31T18:02:19+00:00

This patch removes dead code spotted by the Intel C Compiler.

Signed-off-by: Adrian Bunk 
Signed-off-by: Stefan Richter

SG: Change sg_set_page() to take length and offset argument

2007-10-24T09:20:47+00:00

Most drivers need to set length and offset as well, so may as well fold
those three lines into one.

Add sg_assign_page() for those two locations that only needed to set
the page, where the offset/length is set outside of the function context.

Signed-off-by: Jens Axboe

[PATCH] Fix breakage after SG cleanups

2007-10-23T19:02:39+00:00

Commits

  58b053e4ce9d2fc3023645c1b96e537c72aa8d9a ("Update arch/ to use sg helpers")
  45711f1af6eff1a6d010703b4862e0d2b9afd056 ("[SG] Update drivers to use sg helpers")
  fa05f1286be25a8ce915c5dd492aea61126b3f33 ("Update net/ to use sg helpers")

converted many files to use the scatter gather helpers without ensuring
that the necessary headerfile  is included.  This
happened to work for ia64, powerpc, sparc64 and x86 because they
happened to drag in that file via their .

On most of the others this probably broke.

Instead of increasing the header file spider web I choose to include
 directly into the affectes files.

Signed-off-by: Ralf Baechle 
Signed-off-by: Jens Axboe 
Signed-off-by: Linus Torvalds

[SG] Update drivers to use sg helpers

2007-10-22T19:19:53+00:00

Signed-off-by: Jens Axboe

ieee1394: ieee1394_core.c: use DEFINE_SPINLOCK for spinlock definition

2007-10-16T21:59:59+00:00

drivers/ieee1394/ieee1394_core.c: Define spinlock using
DEFINE_SPINLOCK instead of assignment to SPIN_LOCK_UNLOCKED

Signed-off-by: Matthias Kaehlcke 
Signed-off-by: Stefan Richter

ieee1394: csr1212: proper refcounting

2007-10-16T21:59:59+00:00

At least since nodemgr got rid of coarse global locking, accesses to
struct csr1212_keyval's reference counter should be atomic and coupled
with proper barriers.  Also, calls to csr1212_keep_keyval(kv) should
occur before kv is being used.

(We probably should convert refcnt to struct kref, but how to keep
csr1212_destroy_keyval's implementation non-recursively then?)

Signed-off-by: Stefan Richter

ieee1394: nodemgr: fix leak of struct csr1212_keyval

2007-10-16T21:59:58+00:00

csr1212_keep_keyval(kv) in nodemgr_process_root_directory was
unbalanced if ne->vendor_name_kv already exists.  This happens for
example if eth1394 or raw1394 modify the local config ROM and it is
parsed again.

As a bonus, the attempt to add the vendor_name_kv sysfs attribute
when it already exists is now fixed for good.

Signed-off-by: Stefan Richter

ieee1394: pcilynx: I2C cleanups

2007-10-16T21:59:57+00:00

* Delete optional and empty i2c client_register and client_unregister
  callbacks.
* Use the proper i2c adapter ID.
* Don't use a template to initialize the i2c_adapter structure, it's
  inefficient.
* Update a misleading comment on why we use i2c_transfer rather than
  higher level i2c functions.

Signed-off-by: Jean Delvare 
Signed-off-by: Stefan Richter