linux-toradex.git/drivers/iio/industrialio-buffer.c, branch v4.10

iio: Use kmalloc_array() in iio_scan_mask_set()

2016-09-24T15:35:24+00:00

A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Jonathan Cameron

iio: ensure ret is initialized to zero before entering do loop

2016-09-05T20:00:14+00:00

A recent fix to iio_buffer_read_first_n_outer removed ret from being set by
a return from wait_event_interruptible and also added a continue in a loop
which causes the variable ret to not be set when it reaches the end of the
loop.  Fix this by initializing ret to zero.

Also remove extraneous white space at the end of the loop.

Fixes: fcf68f3c0bb2a5 ("fix sched WARNING "do not call blocking ops when !TASK_RUNNING")
Signed-off-by: Colin Ian King 
Cc: 
Signed-off-by: Jonathan Cameron

iio: fix sched WARNING "do not call blocking ops when !TASK_RUNNING"

2016-08-21T15:22:44+00:00

When using CONFIG_DEBUG_ATOMIC_SLEEP, the scheduler nicely points out
that we're calling sleeping primitives within the wait_event loop, which
means we might clobber the task state:

[   10.831289] do not call blocking ops when !TASK_RUNNING; state=1 set at []
[   10.845531] ------------[ cut here ]------------
[   10.850161] WARNING: at kernel/sched/core.c:7630
...
[   12.164333] ---[ end trace 45409966a9a76438 ]---
[   12.168942] Call trace:
[   12.171391] [] __might_sleep+0x64/0x90
[   12.176699] [] mutex_lock_nested+0x50/0x3fc
[   12.182440] [] iio_kfifo_buf_data_available+0x28/0x4c
[   12.189043] [] iio_buffer_ready+0x60/0xe0
[   12.194608] [] iio_buffer_read_first_n_outer+0x108/0x1a8
[   12.201474] [] __vfs_read+0x58/0x114
[   12.206606] [] vfs_read+0x94/0x118
[   12.211564] [] SyS_read+0x64/0xb4
[   12.216436] [] el0_svc_naked+0x24/0x28

To avoid this, we should (a la https://lwn.net/Articles/628628/) use the
wait_woken() function, which avoids the nested sleeping while still
handling races between waiting / wake-events.

Signed-off-by: Brian Norris 
Reviewed-by: Lars-Peter Clausen 
Cc:  # 3.19+ for introduction of wake_woken
Signed-off-by: Jonathan Cameron

iio: fix config watermark initial value

2016-03-28T10:00:38+00:00

config structure is set to 0 when updating the buffers, so by
default config->watermark will be 0. When computing the minimum
between config->watermark and the buffer->watermark or
insert_buffer-watermark, this will always be 0 regardless of the
value set by the user for the buffer.

Set as initial value for config->watermark the maximum allowed
value so that the minimum value will always be set from one of the
buffers.

Signed-off-by: Irina Tirdea 
Fixes: f0566c0c405d ("iio: Set device watermark based on watermark of all
attached buffers")
Cc: 
Signed-off-by: Jonathan Cameron

iio: Add helper function for calculating scan index storage size

2016-02-06T18:21:35+00:00

We have the same code for computing the scan index storage size in bytes
all over the place. Factor this out into helper functions.

Signed-off-by: Lars-Peter Clausen 
Acked-by: Daniel Baluta 
Signed-off-by: Jonathan Cameron

Merge 4.4-rc5 into staging-next

2015-12-14T03:23:01+00:00

We want those fixes in here for testing.

Signed-off-by: Greg Kroah-Hartman

iio: fix some warning messages

2015-11-21T16:00:05+00:00

WARN_ON() only takes a condition argument.  I have changed these to
WARN() instead.

Signed-off-by: Dan Carpenter 
Cc: 
Signed-off-by: Jonathan Cameron

iio: Add buffer enable/disable callbacks

2015-10-25T13:52:31+00:00

This patch adds a enable and disable callback that is called when the
buffer is enabled/disabled. This can be used by buffer implementations that
need to do some setup or teardown work. E.g. a DMA based buffer can use
this to start/stop the DMA transfer.

Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Jonathan Cameron

iio: Add support for indicating fixed watermarks

2015-10-25T13:51:11+00:00

For buffers which have a fixed wake-up watermark the watermark attribute
should be read-only. Add a new FIXED_WATERMARK flag to the
struct iio_buffer_access_funcs, which can be set by a buffer
implementation.

Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Jonathan Cameron

iio:iio_buffer_init(): Only set watermark if not already set

2015-10-25T13:50:42+00:00

Only initialize the watermark field if it is still 0. This allows drivers
to provide a custom default watermark value. E.g. some driver might have a
fixed watermark or can only support watermarks within a certain range and
the initial value for the watermark should be within this range.

Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Jonathan Cameron