linux-toradex.git/drivers/iio, branch v3.12.2

iio:buffer: Free active scan mask in iio_disable_all_buffers()

2013-10-15T18:26:43+00:00

Usually the active scan mask is freed in __iio_update_buffers() when the buffer
is disabled. But when the device is still sampling when it is removed we'll end
up disabling the buffers in iio_disable_all_buffers(). So we also need to free
the active scan mask here, otherwise it will be leaked.

Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Jonathan Cameron

iio: frequency: adf4350: add missing clk_disable_unprepare() on error in adf4350_probe()

2013-10-12T12:20:46+00:00

Add the missing clk_disable_unprepare() before return
from adf4350_probe() in the error handling case.

Signed-off-by: Wei Yongjun 
Reviewed-by: Lars-Peter CLausen 
Signed-off-by: Jonathan Cameron

iio:magnetometer: Bugfix magnetometer default output registers

2013-09-30T20:46:11+00:00

Signed-off-by: Denis Ciocca 
Signed-off-by: Jonathan Cameron

iio: Remove debugfs entries in iio_device_unregister()

2013-09-30T20:46:10+00:00

Remove the the debugfs entries in iio_device_unregister(). Otherwise the debugfs
entries might still be accessible even though the device used in the debugfs
callback has already been freed.

Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Jonathan Cameron

iio: amplifiers: ad8366: Remove regulator_put

2013-09-28T10:49:45+00:00

Since devm_regulator_get is used, regulator_put should not be
used. Remove it.

Signed-off-by: Sachin Kamat 
Signed-off-by: Jonathan Cameron

iio:buffer_cb: Add missing iio_buffer_init()

2013-09-21T11:52:50+00:00

Make sure to properly initialize the IIO buffer data structure.

Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Jonathan Cameron

iio: Prevent race between IIO chardev opening and IIO device free

2013-09-21T11:50:23+00:00

Set the IIO device as the parent for the character device

We need to make sure that the IIO device is not freed while the character device
exists, otherwise the freeing of the IIO device might race against the file open
callback. Do this by setting the character device's parent to the IIO device,
this will cause the character device to grab a reference to the IIO device and
only release it once the character device itself has been removed.

Also move the registration of the character device before the registration of
the IIO device to avoid the (rather theoretical case) that the IIO device is
already freed again before we can add the character device and grab a reference
to the IIO device.

We also need to move the call to cdev_del() from iio_dev_release() to
iio_device_unregister() (where it should have been in the first place anyway) to
avoid a reference cycle. As iio_dev_release() is only called once all reference
are dropped, but the character device holds a reference to the IIO device.

Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Jonathan Cameron

iio: fix: Keep a reference to the IIO device for open file descriptors

2013-09-21T11:45:07+00:00

Make sure that the IIO device is not freed while we still have file descriptors
for it.

Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Jonathan Cameron

iio: Stop sampling when the device is removed

2013-09-21T11:36:30+00:00

Make sure to stop sampling when the device is removed, otherwise it will
continue to sample forever.

Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Jonathan Cameron

iio: Fix crash when scan_bytes is computed with active_scan_mask == NULL

2013-09-21T11:30:58+00:00

if device has available_scan_masks set and the buffer is enabled without
any scan_elements enabled, in a NULL pointer is dereferenced in iio_compute_scan_bytes()

[   18.993713] Unable to handle kernel NULL pointer dereference at virtual address 00000000
[   19.002593] pgd = debd4000
[   19.005432] [00000000] *pgd=9ebc0831, *pte=00000000, *ppte=00000000
[   19.012329] Internal error: Oops: 17 [#1] PREEMPT ARM
[   19.017639] Modules linked in:
[   19.020843] CPU: 0    Not tainted  (3.9.11-00036-g75c888a-dirty #207)
[   19.027587] PC is at _find_first_bit_le+0xc/0x2c
[   19.032440] LR is at iio_compute_scan_bytes+0x2c/0xf4
[   19.037719] pc : []    lr : []    psr: 200d0013
[   19.037719] sp : debd9ed0  ip : 00000000  fp : 000802bc
[   19.049713] r10: 00000000  r9 : 00000000  r8 : deb67250
[   19.055206] r7 : 00000000  r6 : 00000000  r5 : 00000000  r4 : deb67000
[   19.062011] r3 : de96ec00  r2 : 00000000  r1 : 00000004  r0 : 00000000
[   19.068847] Flags: nzCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment user
[   19.076324] Control: 10c5387d  Table: 9ebd4019  DAC: 00000015

problem is the rollback code in iio_update_buffers(), old_mask may be NULL (e.g. on first
call)

I'm not too confident about the fix; works for me...

Signed-off-by: Peter Meerwald 
Reviewed-by: Lars-Peter Clausen 
Signed-off-by: Jonathan Cameron