linux-toradex.git/drivers/infiniband/core/uverbs_cmd.c, branch v3.10.15

IB/core: convert to idr_alloc()

2013-02-28T03:10:16+00:00

Convert to the much saner new idr interface.

v2: Mike triggered WARN_ON() in idr_preload() because send_mad(),
    which may be used from non-process context, was calling
    idr_preload() unconditionally.  Preload iff @gfp_mask has
    __GFP_WAIT.

Signed-off-by: Tejun Heo 
Reviewed-by: Sean Hefty 
Reported-by: "Marciniszyn, Mike" 
Cc: Roland Dreier 
Cc: Sean Hefty 
Cc: Hal Rosenstock 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2013-02-27T04:16:07+00:00

Pull vfs pile (part one) from Al Viro:
 "Assorted stuff - cleaning namei.c up a bit, fixing ->d_name/->d_parent
  locking violations, etc.

  The most visible changes here are death of FS_REVAL_DOT (replaced with
  "has ->d_weak_revalidate()") and a new helper getting from struct file
  to inode.  Some bits of preparation to xattr method interface changes.

  Misc patches by various people sent this cycle *and* ocfs2 fixes from
  several cycles ago that should've been upstream right then.

  PS: the next vfs pile will be xattr stuff."

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (46 commits)
  saner proc_get_inode() calling conventions
  proc: avoid extra pde_put() in proc_fill_super()
  fs: change return values from -EACCES to -EPERM
  fs/exec.c: make bprm_mm_init() static
  ocfs2/dlm: use GFP_ATOMIC inside a spin_lock
  ocfs2: fix possible use-after-free with AIO
  ocfs2: Fix oops in ocfs2_fast_symlink_readpage() code path
  get_empty_filp()/alloc_file() leave both ->f_pos and ->f_version zero
  target: writev() on single-element vector is pointless
  export kernel_write(), convert open-coded instances
  fs: encode_fh: return FILEID_INVALID if invalid fid_type
  kill f_vfsmnt
  vfs: kill FS_REVAL_DOT by adding a d_weak_revalidate dentry op
  nfsd: handle vfs_getattr errors in acl protocol
  switch vfs_getattr() to struct path
  default SET_PERSONALITY() in linux/elf.h
  ceph: prepopulate inodes only when request is aborted
  d_hash_and_lookup(): export, switch open-coded instances
  9p: switch v9fs_set_create_acl() to inode+fid, do it before d_instantiate()
  9p: split dropping the acls from v9fs_set_create_acl()
  ...

new helper: file_inode(file)

2013-02-23T04:31:31+00:00

Signed-off-by: Al Viro

IB/uverbs: Implement memory windows support in uverbs

2013-02-21T19:59:09+00:00

The existing user/kernel uverbs API has IB_USER_VERBS_CMD_ALLOC/DEALLOC_MW.
Implement these calls, along with destroying user memory windows during
process cleanup.

Signed-off-by: Haggai Eran 
Signed-off-by: Shani Michaeli 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

switch simple cases of fget_light to fdget

2012-09-27T02:20:08+00:00

Signed-off-by: Al Viro

switch infinibarf users of fget() to fget_light()

2012-09-27T01:10:10+00:00

Signed-off-by: Al Viro

Merge branches 'core', 'cxgb4', 'ipath', 'iser', 'lockdep', 'mlx4', 'nes', 'ocrdma', 'qib' and 'raw-qp' into for-linus

2012-05-21T16:00:47+00:00

IB/core: Add raw packet QP type

2012-05-08T18:18:09+00:00

IB_QPT_RAW_PACKET allows applications to build a complete packet,
including L2 headers, when sending; on the receive side, the HW will
not strip any headers.

This QP type is designed for userspace direct access to Ethernet; for
example by applications that do TCP/IP themselves.  Only processes
with the NET_RAW capability are allowed to create raw packet QPs (the
name "raw packet QP" is supposed to suggest an analogy to AF_PACKET /
SOL_RAW sockets).

Signed-off-by: Or Gerlitz 
Reviewed-by: Sean Hefty 
Signed-off-by: Roland Dreier

IB/uverbs: Lock SRQ / CQ / PD objects in a consistent order

2012-05-08T18:17:34+00:00

Since XRC support was added, the uverbs code has locked SRQ, CQ and PD
objects needed during QP and SRQ creation in different orders
depending on the the code path.  This leads to the (at least
theoretical) possibility of deadlock, and triggers the lockdep splat
below.

Fix this by making sure we always lock the SRQ first, then CQs and
finally the PD.

    ======================================================
    [ INFO: possible circular locking dependency detected ]
    3.4.0-rc5+ #34 Not tainted
    -------------------------------------------------------
    ibv_srq_pingpon/2484 is trying to acquire lock:
     (SRQ-uobj){+++++.}, at: [] idr_read_uobj+0x2f/0x4d [ib_uverbs]

    but task is already holding lock:
     (CQ-uobj){+++++.}, at: [] idr_read_uobj+0x2f/0x4d [ib_uverbs]

    which lock already depends on the new lock.

    the existing dependency chain (in reverse order) is:

    -> #2 (CQ-uobj){+++++.}:
           [] lock_acquire+0xbf/0xfe
           [] down_read+0x34/0x43
           [] idr_read_uobj+0x2f/0x4d [ib_uverbs]
           [] idr_read_obj+0x9/0x19 [ib_uverbs]
           [] ib_uverbs_create_qp+0x180/0x684 [ib_uverbs]
           [] ib_uverbs_write+0xb7/0xc2 [ib_uverbs]
           [] vfs_write+0xa7/0xee
           [] sys_write+0x45/0x69
           [] system_call_fastpath+0x16/0x1b

    -> #1 (PD-uobj){++++++}:
           [] lock_acquire+0xbf/0xfe
           [] down_read+0x34/0x43
           [] idr_read_uobj+0x2f/0x4d [ib_uverbs]
           [] idr_read_obj+0x9/0x19 [ib_uverbs]
           [] __uverbs_create_xsrq+0x96/0x386 [ib_uverbs]
           [] ib_uverbs_detach_mcast+0x1cd/0x1e6 [ib_uverbs]
           [] ib_uverbs_write+0xb7/0xc2 [ib_uverbs]
           [] vfs_write+0xa7/0xee
           [] sys_write+0x45/0x69
           [] system_call_fastpath+0x16/0x1b

    -> #0 (SRQ-uobj){+++++.}:
           [] __lock_acquire+0xa29/0xd06
           [] lock_acquire+0xbf/0xfe
           [] down_read+0x34/0x43
           [] idr_read_uobj+0x2f/0x4d [ib_uverbs]
           [] idr_read_obj+0x9/0x19 [ib_uverbs]
           [] ib_uverbs_create_qp+0x1e5/0x684 [ib_uverbs]
           [] ib_uverbs_write+0xb7/0xc2 [ib_uverbs]
           [] vfs_write+0xa7/0xee
           [] sys_write+0x45/0x69
           [] system_call_fastpath+0x16/0x1b

    other info that might help us debug this:

    Chain exists of:
      SRQ-uobj --> PD-uobj --> CQ-uobj

     Possible unsafe locking scenario:

           CPU0                    CPU1
           ----                    ----
      lock(CQ-uobj);
                                   lock(PD-uobj);
                                   lock(CQ-uobj);
      lock(SRQ-uobj);

     *** DEADLOCK ***

    3 locks held by ibv_srq_pingpon/2484:
     #0:  (QP-uobj){+.+...}, at: [] ib_uverbs_create_qp+0xe9/0x684 [ib_uverbs]
     #1:  (PD-uobj){++++++}, at: [] idr_read_uobj+0x2f/0x4d [ib_uverbs]
     #2:  (CQ-uobj){+++++.}, at: [] idr_read_uobj+0x2f/0x4d [ib_uverbs]

    stack backtrace:
    Pid: 2484, comm: ibv_srq_pingpon Not tainted 3.4.0-rc5+ #34
    Call Trace:
     [] print_circular_bug+0x1f8/0x209
     [] __lock_acquire+0xa29/0xd06
     [] ? __idr_get_uobj+0x20/0x5e [ib_uverbs]
     [] ? idr_read_uobj+0x2f/0x4d [ib_uverbs]
     [] lock_acquire+0xbf/0xfe
     [] ? idr_read_uobj+0x2f/0x4d [ib_uverbs]
     [] ? lock_release+0x166/0x189
     [] down_read+0x34/0x43
     [] ? idr_read_uobj+0x2f/0x4d [ib_uverbs]
     [] idr_read_uobj+0x2f/0x4d [ib_uverbs]
     [] idr_read_obj+0x9/0x19 [ib_uverbs]
     [] ib_uverbs_create_qp+0x1e5/0x684 [ib_uverbs]
     [] ? lock_acquire+0xdb/0xfe
     [] ? lock_release_non_nested+0x94/0x213
     [] ? might_fault+0x40/0x90
     [] ? might_fault+0x40/0x90
     [] ib_uverbs_write+0xb7/0xc2 [ib_uverbs]
     [] vfs_write+0xa7/0xee
     [] ? fget_light+0x3b/0x99
     [] sys_write+0x45/0x69
     [] system_call_fastpath+0x16/0x1b

Reported-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/uverbs: Make lockdep output more readable

2012-05-08T18:17:34+00:00

Add names for our lockdep classes, so instead of having to decipher
lockdep output with mysterious names:

    Chain exists of:
      key#14 --> key#11 --> key#13

lockdep will give us something nicer:

    Chain exists of:
      SRQ-uobj --> PD-uobj --> CQ-uobj

Signed-off-by: Roland Dreier