linux-toradex.git/drivers/infiniband/ulp/iser/iser_verbs.c, branch v3.14

IB/iser: Avoid dereferencing iscsi_iser conn object when not bound to iser connection

2014-02-14T17:48:03+00:00

Fix a possible NULL pointer dereference in disconnection flow. This
can happen if the target disconnected/rejected the connection request,
e.g before the binding stage between iscsi connection to the transport
connection.

Signed-off-by: Alex Tabachnik 
Signed-off-by: Roi Dayan 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Fix possible memory leak in iser_create_frwr_pool()

2013-09-03T04:24:08+00:00

Fix leak where desc is not being freed in error flows.

Signed-off-by: Roi Dayan 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Roland Dreier

IB/iser: Introduce fast memory registration model (FRWR)

2013-08-10T00:18:10+00:00

Newer HCAs and Virtual functions may not support FMRs but rather a fast
registration model, which we call FRWR - "Fast Registration Work Requests".

This model was introduced in 00f7ec36c ("RDMA/core: Add memory management
extensions support") and works when the IB device supports the
IB_DEVICE_MEM_MGT_EXTENSIONS capability.

Upon creating the iser device iser will test whether the HCA supports
FMRs.  If no support for FMRs, check if IB_DEVICE_MEM_MGT_EXTENSIONS
is supported and assign function pointers that handle fast
registration and allocation of appropriate resources (fast_reg
descriptors).

Registration is done using posting IB_WR_FAST_REG_MR to the QP and
invalidations using posting IB_WR_LOCAL_INV.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Place the fmr pool into a union in iser's IB conn struct

2013-08-10T00:18:09+00:00

This is preparation step for other memory registration methods to be
added.  In addition, change reg/unreg routines signature to indicate
they use FMRs.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Generalize rdma memory registration

2013-08-10T00:18:09+00:00

Currently the driver uses FMRs as the only means to register the
memory pointed by SG provided by the SCSI mid-layer with the RDMA
device.

As preparation step for adding more methods for fast path memory
registration, make the alloc/free and reg/unreg calls function
pointers, which are for now just set to the existing FMR ones.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Accept session->cmds_max from user space

2013-08-10T00:18:08+00:00

Use cmds_max passed from user space to be the number of PDUs to be
supported for the session instead of hard-coded ISCSI_DEF_XMIT_CMDS_MAX.
This allow controlling the max number of SCSI commands for the session.
Also don't ignore the qdepth passed from user space.

Derive from session->cmds_max the actual number of RX buffers and FMR
pool size to allocate during the connection bind phase.

Since the iser transport connection is established before the iscsi
session/connection are created and bound, we still use one hard-coded
quantity ISER_DEF_XMIT_CMDS_MAX to compute the maximum number of
work-requests to be supported by the RC QP used for the connection.

The above quantity is made to be a power of two between ISCSI_TOTAL_CMDS_MIN
(16) and ISER_DEF_XMIT_CMDS_MAX (512) inclusive.

Signed-off-by: Shlomo Pongratz 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Restructure allocation/deallocation of connection resources

2013-08-10T00:18:08+00:00

This is a preparation step to a patch that accepts the number of max
SCSI commands to be supported a session from user space iSCSI tools.

Move the allocation of the login buffer, FMR pool and its associated
page vector from iser_create_ib_conn_res() (which is called prior when
we actually know how many commands should be supported) to
iser_alloc_rx_descriptors() (which is called during the iscsi
connection bind step where this quantity is known).

Also do small refactoring around the deallocation to make that path
similar to the allocation one.

Signed-off-by: Shlomo Pongratz 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Add Mellanox copyright

2013-06-05T00:03:12+00:00

Add Mellanox copyright to the iser initiator source code which I maintain.

Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Fix device removal flow

2013-06-05T00:03:11+00:00

Change the code to destroy the "last opened" rdma_cm id after making
sure we released all other objects (QP, CQs, PD, etc) associated with
the IB device.

Since iser accesses the IB device using the rdma_cm id, we need to
free any objects that are related to the device that is associated
with the rdma_cm id prior to destroying that id.  When this isn't
done, the low level driver that created this device can be unloaded
before iser has a chance to free all the objects and a such a call may
invoke code segment which isn't valid any more and crash.

Cc: Sean Hefty 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Add support for iser CM REQ additional info

2013-05-02T00:34:14+00:00

Annex A12 of the IBTA spec defines additional information that needs
to be provided through the CM exchange relating to usage of ZBVA (Zero
Based VAs) and Send With Invalidate over an iSER connection.

Currently, the initiator sets both to not supported, but does provide
the header so that existing iSER targets can be patched to start
looking on the private data carried by the CM.

This is a preparation step to enable iSER with HW drivers for which
FMRs are not supported, such as mlx4 VF instances or new HW devices
which might support only FRWR (Fast Registration Work-Requests) along
the details of the IB_DEVICE_MEM_MGT_EXTENSIONS device capability.

Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier