linux-toradex.git/drivers/infiniband/ulp/iser/iser_verbs.c, branch v5.0

iser: set sector for ambiguous mr status errors

2018-11-21T23:03:43+00:00

If for some reason we failed to query the mr status, we need to make sure
to provide sufficient information for an ambiguous error (guard error on
sector 0).

Fixes: 0a7a08ad6f5f ("IB/iser: Implement check_protection")
Cc: 
Reported-by: Dan Carpenter 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Jason Gunthorpe

RDMA/ulp: Use dev_name instead of ibdev->name

2018-09-26T19:51:48+00:00

These return the same thing but dev_name is a more conventional use of the
kernel API.

Signed-off-by: Jason Gunthorpe 
Reviewed-by: Steve Wise 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Dennis Dalessandro

IB/iser: Simplify ib_post_(send|recv|srq_recv)() calls

2018-07-24T22:06:36+00:00

Instead of declaring and passing a dummy 'bad_wr' pointer, pass NULL
as third argument to ib_post_(send|recv|srq_recv)().

Signed-off-by: Bart Van Assche 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Max Gurtovoy 
Signed-off-by: Jason Gunthorpe

IB/iser: Do not reduce max_sectors

2018-05-31T17:07:17+00:00

The iSER driver reduces max_sectors. For example, if you load the
ib_iser module with max_sectors=1024, you will see that
/sys/class/block//queue/max_hw_sectors_kb is 508. It is an
incorrect value. The expected value is (max_sectors * sector_size) /
1024 = 512.

Reducing of max_sectors can cause performance degradation due to
unnecessary splitting of IO requests.

The number of pages per MR has been fixed here, so there is no longer
any need to reduce max_sectors.

Fixes: 9c674815d346 ("IB/iser: Fix max_sectors calculation")
Signed-off-by: Sergey Gorenko 
Reviewed-by: Israel Rukshin 
Reviewed-by: Max Gurtovoy 
Cc: Christoph Hellwig 
Cc: Sagi Grimberg 
Acked-by: Sagi Grimberg 
Signed-off-by: Doug Ledford

IB/{ipoib, iser}: Consistent print format of vendor error

2017-09-29T15:18:56+00:00

Vendor error print should be consistent across protocols to avoid any
confusion.
This patch corrects that.

Suggested-by: Santosh Shilimkar 
Signed-off-by: Ajaykumar Hotchandani 
Reviewed-by: Santosh Shilimkar 
Acked-by: Wengang Wang 
Reviewed-by: Yuval Shaia 
Signed-off-by: Yuval Shaia 
Acked-by: Sagi Grimberg 
Acked-by: Roi Dayan 
Signed-off-by: Doug Ledford

RDMA/(core, ulp): Convert register/unregister event handler to be void

2017-08-24T20:27:10+00:00

The functions ib_register_event_handler() and
ib_unregister_event_handler() always returned success and they can't fail.

Let's convert those functions to be void, remove redundant checks and
cleanup tons of goto statements.

Signed-off-by: Leon Romanovsky 
Reviewed-by: Dennis Dalessandro 
Signed-off-by: Doug Ledford

IB/iser: Handle lack of memory management extentions correctly

2017-07-11T14:47:16+00:00

max_fast_reg_page_list_len is only valid when the
memory management extentions are signaled by the underlying
driver.

Fix by adjusting iser_calc_scsi_params() to use
ISCSI_ISER_MAX_SG_TABLESIZE when the extentions are not indicated.

Reported-by: Thomas Rosenstein 
Fixes: Commit df749cdc45d9 ("IB/iser: Support up to 8MB data transfer in a single command")
Reviewed-by: Dennis Dalessandro 
Signed-off-by: Mike Marciniszyn 
Acked-by: Sagi Grimberg 
Tested-by: Thomas Rosenstein 
Signed-off-by: Doug Ledford

RDMA/iser: Fix possible mr leak on device removal event

2017-03-25T02:31:19+00:00

When the rdma device is removed, we must cleanup all
the rdma resources within the DEVICE_REMOVAL event
handler to let the device teardown gracefully. When
this happens with live I/O, some memory regions are
occupied. Thus, track them too and dereg all the mr's.

We are safe with mr access by iscsi_iser_cleanup_task.

Reported-by: Raju Rangoju 
Signed-off-by: Sagi Grimberg 
Reviewed-by: Max Gurtovoy 
Reviewed-by: Max Gurtovoy 
Signed-off-by: Doug Ledford

IB/iser: Protect completion context active_qps update

2017-02-19T14:18:31+00:00

As iser connections can share completion contexts, we need
to protect the active_qps update each time we set it.

Signed-off-by: Max Gurtovoy 
Acked-by: Sagi Grimberg 
Signed-off-by: Doug Ledford

IB/iser: remove unused variable from iser_conn struct

2017-01-24T16:37:45+00:00

max_sectors calculation was fixed in commit:
9c674815d346 ("IB/iser: Fix max_sectors calculation").
Thus, iser_conn variable scsi_max_sectors is not needed anymore.

Signed-off-by: Max Gurtovoy 
Reviewed-by: Sagi Grimberg 
Tested-by: Raju Rangoju 
Signed-off-by: Doug Ledford