linux-toradex.git/drivers/infiniband/ulp/srp, branch v4.10

IB/srp: fix invalid indirect_sg_entries parameter value

2017-01-24T16:30:14+00:00

After setting indirect_sg_entries module_param to huge value (e.g 500,000),
srp_alloc_req_data() fails to allocate indirect descriptors for the request
ring (kmalloc fails). This commit enforces the maximum value of
indirect_sg_entries to be SG_MAX_SEGMENTS as signified in module param
description.

Fixes: 65e8617fba17 (scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS)
Fixes: c07d424d6118 (IB/srp: add support for indirect tables that don't fit in SRP_CMD)
Cc: stable@vger.kernel.org # 4.7+
Signed-off-by: Israel Rukshin 
Signed-off-by: Max Gurtovoy 
Reviewed-by: Laurence Oberman 
Reviewed-by: Bart Van Assche --
Signed-off-by: Doug Ledford

IB/srp: fix mr allocation when the device supports sg gaps

2017-01-24T16:03:17+00:00

If the device support arbitrary sg list mapping (device cap
IB_DEVICE_SG_GAPS_REG set) we allocate the memory regions with
IB_MR_TYPE_SG_GAPS.

Fixes: 509c5f33f4f6 ("IB/srp: Prevent mapping failures")
Cc:  # 4.7+
Signed-off-by: Israel Rukshin 
Signed-off-by: Max Gurtovoy 
Reviewed-by: Leon Romanovsky 
Reviewed-by: Mark Bloch 
Reviewed-by: Yuval Shaia 
Reviewed-by: Bart Van Assche 
Signed-off-by: Doug Ledford

IB/srp: Make writing the add_target sysfs attr interruptible

2016-12-14T18:31:47+00:00

Avoid that shutdown of srp_daemon is delayed if add_target_mutex is
held by another process.

Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

IB/srp: Make mapping failures easier to debug

2016-12-14T18:31:37+00:00

Make it easier to figure out what is going on if memory mapping
fails because more memory regions than mr_per_cmd are needed.

Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

IB/srp: Make login failures easier to debug

2016-12-14T18:31:37+00:00

If login fails because memory region allocation failed it can be
hard to figure out what happened. Make it easier to figure out
why login failed by logging a message if ib_alloc_mr() fails.

Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

IB/srp: Introduce a local variable in srp_add_one()

2016-12-14T18:31:37+00:00

This patch makes the srp_add_one() code more compact and does not
change any functionality.

Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

IB/srp: Fix CONFIG_DYNAMIC_DEBUG=n build

2016-12-14T18:31:37+00:00

Avoid that the kernel build fails as follows if dynamic debug support
is disabled:

drivers/infiniband/ulp/srp/ib_srp.c:2272:3: error: implicit declaration of function 'DEFINE_DYNAMIC_DEBUG_METADATA'
drivers/infiniband/ulp/srp/ib_srp.c:2272:33: error: 'ddm' undeclared (first use in this function)
drivers/infiniband/ulp/srp/ib_srp.c:2275:39: error: '_DPRINTK_FLAGS_PRINT' undeclared (first use in this function)

Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

IB/srp: Fix infinite loop when FMR sg[0].offset != 0

2016-10-07T20:54:39+00:00

Avoid that mapping an sg-list in which the first element has a
non-zero offset triggers an infinite loop when using FMR. This
patch makes the FMR mapping code similar to that of ib_sg_to_pages().

Note: older Mellanox HCAs do not support non-zero offsets for FMR.
See also commit 8c4037b501ac ("IB/srp: always avoid non-zero offsets
into an FMR").

Reported-by: Alex Estrin 
Signed-off-by: Bart Van Assche 
Cc: 
Signed-off-by: Doug Ledford

IB/srp: Remove an unused argument

2016-10-07T20:54:39+00:00

Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

IB/srp: use IB_PD_UNSAFE_GLOBAL_RKEY

2016-09-23T17:47:44+00:00

Signed-off-by: Christoph Hellwig 
Reviewed-by: Max Gurtovoy 
Signed-off-by: Doug Ledford