linux-toradex.git/drivers/infiniband/ulp/srp, branch v5.0

RDMA/srp: Rework SCSI device reset handling

2019-02-04T23:31:33+00:00

Since .scsi_done() must only be called after scsi_queue_rq() has
finished, make sure that the SRP initiator driver does not call
.scsi_done() while scsi_queue_rq() is in progress. Although
invoking sg_reset -d while I/O is in progress works fine with kernel
v4.20 and before, that is not the case with kernel v5.0-rc1. This
patch avoids that the following crash is triggered with kernel
v5.0-rc1:

BUG: unable to handle kernel NULL pointer dereference at 0000000000000138
CPU: 0 PID: 360 Comm: kworker/0:1H Tainted: G    B             5.0.0-rc1-dbg+ #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1 04/01/2014
Workqueue: kblockd blk_mq_run_work_fn
RIP: 0010:blk_mq_dispatch_rq_list+0x116/0xb10
Call Trace:
 blk_mq_sched_dispatch_requests+0x2f7/0x300
 __blk_mq_run_hw_queue+0xd6/0x180
 blk_mq_run_work_fn+0x27/0x30
 process_one_work+0x4f1/0xa20
 worker_thread+0x67/0x5b0
 kthread+0x1cf/0x1f0
 ret_from_fork+0x24/0x30

Cc: 
Fixes: 94a9174c630c ("IB/srp: reduce lock coverage of command completion")
Signed-off-by: Bart Van Assche 
Signed-off-by: Jason Gunthorpe

Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma

2018-12-28T22:57:10+00:00

Pull rdma updates from Jason Gunthorpe:
 "This has been a fairly typical cycle, with the usual sorts of driver
  updates. Several series continue to come through which improve and
  modernize various parts of the core code, and we finally are starting
  to get the uAPI command interface cleaned up.

   - Various driver fixes for bnxt_re, cxgb3/4, hfi1, hns, i40iw, mlx4,
     mlx5, qib, rxe, usnic

   - Rework the entire syscall flow for uverbs to be able to run over
     ioctl(). Finally getting past the historic bad choice to use
     write() for command execution

   - More functional coverage with the mlx5 'devx' user API

   - Start of the HFI1 series for 'TID RDMA'

   - SRQ support in the hns driver

   - Support for new IBTA defined 2x lane widths

   - A big series to consolidate all the driver function pointers into a
     big struct and have drivers provide a 'static const' version of the
     struct instead of open coding initialization

   - New 'advise_mr' uAPI to control device caching/loading of page
     tables

   - Support for inline data in SRPT

   - Modernize how umad uses the driver core and creates cdev's and
     sysfs files

   - First steps toward removing 'uobject' from the view of the drivers"

* tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma: (193 commits)
  RDMA/srpt: Use kmem_cache_free() instead of kfree()
  RDMA/mlx5: Signedness bug in UVERBS_HANDLER()
  IB/uverbs: Signedness bug in UVERBS_HANDLER()
  IB/mlx5: Allocate the per-port Q counter shared when DEVX is supported
  IB/umad: Start using dev_groups of class
  IB/umad: Use class_groups and let core create class file
  IB/umad: Refactor code to use cdev_device_add()
  IB/umad: Avoid destroying device while it is accessed
  IB/umad: Simplify and avoid dynamic allocation of class
  IB/mlx5: Fix wrong error unwind
  IB/mlx4: Remove set but not used variable 'pd'
  RDMA/iwcm: Don't copy past the end of dev_name() string
  IB/mlx5: Fix long EEH recover time with NVMe offloads
  IB/mlx5: Simplify netdev unbinding
  IB/core: Move query port to ioctl
  RDMA/nldev: Expose port_cap_flags2
  IB/core: uverbs copy to struct or zero helper
  IB/rxe: Reuse code which sets port state
  IB/rxe: Make counters thread safe
  IB/mlx5: Use the correct commands for UMEM and UCTX allocation
  ...

RDMA/srp: Add support for immediate data

2018-12-19T20:07:25+00:00

Request permission to send immediate data during login. If the SRP
target grants this request, send the payload of write requests <= 8 KB
as immediate data.

Cc: Sergey Gorenko 
Cc: Max Gurtovoy 
Cc: Laurence Oberman 
Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

RDMA/srp: Rework handling of the maximum information unit length

2018-12-19T20:07:25+00:00

Move the maximum initiator to target information unit length parameter
from struct srp_target_port into struct srp_rdma_ch. This patch does
not change any functionality but makes the next patch easier to read.

Cc: Sergey Gorenko 
Cc: Max Gurtovoy 
Cc: Laurence Oberman 
Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

RDMA/srp: Move srp_rdma_ch.max_ti_iu_len declaration

2018-12-19T20:07:25+00:00

Since srp_rdma_ch.max_ti_iu_len is used in the hot path, move it to the
section with data structure members used in the hot path.

Cc: Sergey Gorenko 
Cc: Max Gurtovoy 
Cc: Laurence Oberman 
Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

RDMA/srp: Propagate ib_post_send() failures to the SCSI mid-layer

2018-12-19T20:07:25+00:00

This patch avoids that the SCSI mid-layer keeps retrying forever if
ib_post_send() fails. This was discovered while testing immediate
data support and passing a too large num_sge value to ib_post_send().

Cc: Sergey Gorenko 
Cc: Max Gurtovoy 
Cc: Laurence Oberman 
Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

RDMA/srp: Handle large SCSI CDBs correctly

2018-12-19T20:07:25+00:00

Reserve additional space for CDBs that contain more than sixteen bytes
and set the add_cdb_len field for such CDBs as required. From the SRP
standard: "The ADDITIONAL CDB LENGTH field contains the length in
dwords of the ADDITIONAL CDB field."

Cc: Sergey Gorenko 
Cc: Max Gurtovoy 
Cc: Laurence Oberman 
Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

RDMA/srp: Document srp_parse_in() arguments

2018-12-19T20:07:25+00:00

This patch avoids that a warning is reported when building with W=1.

Cc: Sergey Gorenko 
Cc: Max Gurtovoy 
Cc: Laurence Oberman 
Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

include/scsi/srp.h: Add support for immediate data

2018-12-19T20:07:25+00:00

Add constants and data structures to support immediate data. These
changes conform to SRP2r04.

Cc: Sergey Gorenko 
Cc: Max Gurtovoy 
Cc: Laurence Oberman 
Signed-off-by: Bart Van Assche 
Signed-off-by: Doug Ledford

scsi: flip the default on use_clustering

2018-12-19T04:13:12+00:00

Most SCSI drivers want to enable "clustering", that is merging of
segments so that they might span more than a single page.  Remove the
ENABLE_CLUSTERING define, and require drivers to explicitly set
DISABLE_CLUSTERING to disable this feature.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen