linux-toradex.git/drivers/infiniband/ulp, branch v6.12

RDMA/srpt: Make slab cache names unique

2024-10-11T17:07:33+00:00

Since commit 4c39529663b9 ("slab: Warn on duplicate cache names when
DEBUG_VM=y"), slab complains about duplicate cache names. Hence this
patch. The approach is as follows:
- Maintain an xarray with the slab size as index and a reference count
  and a kmem_cache pointer as contents. Use srpt-${slab_size} as kmem
  cache name.
- Use 512-byte alignment for all slabs instead of only for some of the
  slabs.
- Increment the reference count instead of calling kmem_cache_create().
- Decrement the reference count instead of calling kmem_cache_destroy().

Fixes: 5dabcd0456d7 ("RDMA/srpt: Add support for immediate data")
Link: https://patch.msgid.link/r/20241009210048.4122518-1-bvanassche@acm.org
Reported-by: Shinichiro Kawasaki 
Closes: https://lore.kernel.org/linux-block/xpe6bea7rakpyoyfvspvin2dsozjmjtjktpph7rep3h25tv7fb@ooz4cu5z6bq6/
Suggested-by: Jason Gunthorpe 
Signed-off-by: Bart Van Assche 
Tested-by: Shin'ichiro Kawasaki 
Signed-off-by: Jason Gunthorpe

IB/iser: Remove unused declaration in header file

2024-09-10T13:41:03+00:00

The definition of iser_finalize_rdma_unaligned_sg() has been removed
since commit dd0107a08996 ("IB/iser: set block queue_virt_boundary").
Let's remove the unused declaration in header file.

Signed-off-by: Zhang Zekun 
Link: https://patch.msgid.link/20240909121408.80079-2-zhangzekun11@huawei.com
Reviewed-by: Kalesh AP 
Reviewed-by: Sagi Grimberg 
Acked-by: Max Gurtovoy 
Signed-off-by: Leon Romanovsky

RDMA/rtrs-clt: Remove an extra space

2024-08-28T12:24:35+00:00

No functional changes.

Signed-off-by: Jack Wang 
Signed-off-by: Alexei Pastuchov 
Signed-off-by: Grzegorz Prajsner 
Signed-off-by: Md Haris Iqbal 
Link: https://patch.msgid.link/20240821112217.41827-12-haris.iqbal@ionos.com
Signed-off-by: Leon Romanovsky

RDMA/rtrs-clt: Do local invalidate after write io completion

2024-08-28T12:24:35+00:00

Switch local invalidate after write io completion avoid the
chain usage of WR, this fixed the local protection error on
LOCAL INVALIDATE WR.

Signed-off-by: Jack Wang 
Signed-off-by: Md Haris Iqbal 
Signed-off-by: Grzegorz Prajsner 
Link: https://patch.msgid.link/20240821112217.41827-11-haris.iqbal@ionos.com
Signed-off-by: Leon Romanovsky

RDMA/rtrs: Register ib event handler

2024-08-28T12:24:35+00:00

Use ib_register_event_handler() to register event handlers for both
client and server side. For now, all those handlers do, is to print
type of incoming event.

Signed-off-by: Grzegorz Prajsner 
Signed-off-by: Jack Wang 
Signed-off-by: Md Haris Iqbal 
Link: https://patch.msgid.link/20240821112217.41827-10-haris.iqbal@ionos.com
Signed-off-by: Leon Romanovsky

RDMA/rtrs-srv: Avoid null pointer deref during path establishment

2024-08-28T12:24:35+00:00

For RTRS path establishment, RTRS client initiates and completes con_num
of connections. After establishing all its connections, the information
is exchanged between the client and server through the info_req message.
During this exchange, it is essential that all connections have been
established, and the state of the RTRS srv path is CONNECTED.

So add these sanity checks, to make sure we detect and abort process in
error scenarios to avoid null pointer deref.

Signed-off-by: Md Haris Iqbal 
Signed-off-by: Jack Wang 
Signed-off-by: Grzegorz Prajsner 
Link: https://patch.msgid.link/20240821112217.41827-9-haris.iqbal@ionos.com
Signed-off-by: Leon Romanovsky

RDMA/rtrs-clt: Print request type for errors

2024-08-28T12:24:35+00:00

Extend the output to print also the request type.

Signed-off-by: Jack Wang 
Signed-off-by: Grzegorz Prajsner 
Signed-off-by: Md Haris Iqbal 
Link: https://patch.msgid.link/20240821112217.41827-8-haris.iqbal@ionos.com
Signed-off-by: Leon Romanovsky

RDMA/rtrs-clt: Reset cid to con_num - 1 to stay in bounds

2024-08-28T12:24:35+00:00

In the function init_conns(), after the create_con() and create_cm() for
loop if something fails. In the cleanup for loop after the destroy tag, we
access out of bound memory because cid is set to clt_path->s.con_num.

This commits resets the cid to clt_path->s.con_num - 1, to stay in bounds
in the cleanup loop later.

Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality")
Signed-off-by: Md Haris Iqbal 
Signed-off-by: Jack Wang 
Signed-off-by: Grzegorz Prajsner 
Link: https://patch.msgid.link/20240821112217.41827-7-haris.iqbal@ionos.com
Signed-off-by: Leon Romanovsky

RDMA/rtrs-clt: Reuse need_inval from mr

2024-08-28T12:24:35+00:00

mr has a member need_inval, which can be used to indicate if
local invalidate is needed, switch to it and remove need_inv
from rtrs_clt_io_req.

Signed-off-by: Jack Wang 
Signed-off-by: Md Haris Iqbal 
Signed-off-by: Grzegorz Prajsner 
Link: https://patch.msgid.link/20240821112217.41827-6-haris.iqbal@ionos.com
Signed-off-by: Leon Romanovsky

RDMA/rtrs: Reset hb_missed_cnt after receiving other traffic from peer

2024-08-28T12:24:35+00:00

Reset hb_missed_cnt after receiving traffic from other peer, so
hb is more robust again high load on host or network.

Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality")
Signed-off-by: Jack Wang 
Signed-off-by: Md Haris Iqbal 
Signed-off-by: Grzegorz Prajsner 
Link: https://patch.msgid.link/20240821112217.41827-5-haris.iqbal@ionos.com
Signed-off-by: Leon Romanovsky