linux-toradex.git/drivers/input/joydev.c, branch v4.13-rc4

input: utilize new cdev_device_add helper function

2017-03-21T05:44:32+00:00

Replace the open coded registration of the cdev and dev with the
new device_add_cdev() helper in evdev, joydev and mousedev. The helper
replaces a common pattern by taking the proper reference against the
parent device and adding both the cdev and the device.

Signed-off-by: Logan Gunthorpe 
Acked-by: Dmitry Torokhov 
Signed-off-by: Greg Kroah-Hartman

Input: joydev - do not report stale values on first open

2017-02-09T21:29:04+00:00

Postpone axis initialization to the first open instead of doing it
in joydev_connect. This is to make sure the generated startup events
are representative of the current joystick state rather than what
it was when joydev_connect() was called, potentially much earlier.
Once the first user is connected to joydev node we'll be updating
joydev->abs[] values and subsequent clients will be getting correct
initial states as well.

This solves issues with joystick driven menus that start scrolling
up each time they are started, until the user moves the joystick to
generate events. In emulator menu setups where the menu program is
restarted every time the game exits, the repeated need to move the
joystick to stop the unintended scrolling gets old rather quickly...

Signed-off-by: Raphael Assenat 
Signed-off-by: Dmitry Torokhov

Input: joydev - use clamp() macro

2017-02-01T18:39:40+00:00

We have a nice macro ensuring that the value is within certain range, let's
use it instead of open-coding.

Signed-off-by: Dmitry Torokhov

Input: joydev - remove unused linux/miscdevice.h include

2016-12-18T23:55:47+00:00

This patch remove the inclusion of linux/miscdevice.h for joydev
since it does not use miscdevice.

Signed-off-by: Corentin Labbe 
Signed-off-by: Dmitry Torokhov

Input: joydev - recognize devices with Z axis as joysticks

2016-09-27T03:03:06+00:00

Current implementation of joydev's input_device_id table recognizes only
devices with ABS_X, ABS_WHEEL or ABS_THROTTLE axes as joysticks.

There are joystick devices that do not have those axes, for example TRC
Rudder device. The device in question has ABS_Z, ABS_RX and ABS_RY axes
causing it not being detected as joystick.

This patch adds ABS_Z to the input_device_id list allowing devices with
ABS_Z axis to be detected correctly.

Signed-off-by: Ville Ranki 
Signed-off-by: Dmitry Torokhov

Input: joydev - fix possible ERR_PTR() dereferencing

2015-10-06T23:38:40+00:00

Commit 5702222c9a7a ("Input: joydev - use memdup_user() to duplicate
memory from user-space") changed the kmalloc() and copy_from_user()
with a single call to memdup_user() but wrongly used the same error
path than the old code in which the buffer allocated by kmalloc() was
freed if copy_from_user() failed.

This is of course wrong since if memdup_user() fails, no memory was
allocated and the error in the error-valued pointer should be returned.

Fixes: 5702222c9a7a ("Input: joydev - use memdup_user() to duplicate
memory from user-space")
Reported-by: Dan Carpenter 
Signed-off-by: Javier Martinez Canillas 
Signed-off-by: Dmitry Torokhov

Input: joydev - use memdup_user() to duplicate memory from user-space

2015-10-02T18:44:16+00:00

The memdup_user() helper function can be used to duplicate a memory region
from user-space to kernel-space. There is no need to open code the same
logic using kmalloc() and copy_from_user() instead. This was found with
make coccicheck that reported the following warning:

drivers/input/joydev.c:447:10-17: WARNING opportunity for memdup_user
drivers/input/joydev.c:483:10-17: WARNING opportunity for memdup_user

Signed-off-by: Javier Martinez Canillas 
Signed-off-by: Dmitry Torokhov

Merge tag 'v4.2-rc3' into next

2015-07-20T17:08:17+00:00

Sync up with Linux 4.2-rc3 to bring in infrastructure (OF) pieces.

Input: joydev - use for_each_set_bit where appropriate

2015-07-09T04:50:58+00:00

Use for_each_set_bit to check for set bits in bitmap as it is more
efficient than checking individual bits.

Signed-off-by: Anshul Garg 
Signed-off-by: Dmitry Torokhov

Input: joydev - don't classify the vmmouse as a joystick

2015-05-21T22:58:27+00:00

Joydev is currently thinking some absolute mice are joystick, and that
messes up games in VMware guests, as the cursor typically gets stuck in
the top left corner.

Try to detect the event signature of a VMmouse input device and back off
for such devices. We're still incorrectly detecting, for example, the
VMware absolute USB mouse as a joystick, but adding an event signature
matching also that device would be considerably more risky, so defer that
to a later merge window.

Signed-off-by: Thomas Hellstrom 
Signed-off-by: Dmitry Torokhov