linux-toradex.git/drivers/input/mouse/appletouch.c, branch v3.10.78

USB: input: appletouch: fix up compiler warning

2012-05-04T22:35:56+00:00

My last patch fixing up the dev_* messages caused a compiler warning
accidentally for an unused variable.  Fix this up, as it was my fault.

Cc: Alessandro Rubini 
Cc: Dmitry Torokhov 
Signed-off-by: Greg Kroah-Hartman

USB: input: appletouch.c: fix up dev_* messages

2012-05-04T22:33:01+00:00

Previously I had made the struct device point to the input device, but
after talking with Dmitry, he said that the USB device would make more
sense for this driver to point to.  So converted it to use that instead.

CC: Alessandro Rubini 
CC: Dmitry Torokhov 
Signed-off-by: Greg Kroah-Hartman

USB: appletouch.c: remove dbg() usage

2012-05-02T04:33:04+00:00

dbg() was a very old USB-specific macro that should no longer
be used. This patch removes it from being used in the driver
and uses dev_dbg() instead.

CC: Alessandro Rubini 
CC: Dmitry Torokhov 
Signed-off-by: Greg Kroah-Hartman

USB: input: appletouch.c: fix up dev_err() usage

2012-05-02T00:56:47+00:00

We should always reference the input device for dev_err(), not the USB
device.  Fix up the places where I got this wrong.

Reported-by: Dmitry Torokhov 
CC: Alessandro Rubini 
Signed-off-by: Greg Kroah-Hartman

USB: appletouch.c: remove err() usage

2012-04-25T21:48:31+00:00

err() was a very old USB-specific macro that I thought had
gone away.  This patch removes it from being used in the
driver and uses dev_err() instead.

CC: Alessandro Rubini 
CC: Dmitry Torokhov 
Signed-off-by: Greg Kroah-Hartman

USB: convert drivers/input/* to use module_usb_driver()

2011-11-18T17:48:31+00:00

This converts the drivers in drivers/input/* to use the
module_usb_driver() macro which makes the code smaller and a bit
simpler.

Added bonus is that it removes some unneeded kernel log messages about
drivers loading and/or unloading.

Cc: Dmitry Torokhov 
Cc: Ville Syrjala 
Cc: Henk Vergonet 
Cc: Alessandro Rubini 
Cc: Henrik Rydberg 
Cc: "Magnus Hörlin" 
Cc: Chris Moeller 
Cc: Christoph Fritz 
Cc: Lucas De Marchi 
Cc: Jesper Juhl 
Cc: Edwin van Vliet 
Cc: Ping Cheng 
Cc: Eduard Hasenleithner 
Cc: Alexander Strakh 
Cc: Glenn Sommer 
Signed-off-by: Greg Kroah-Hartman

Input: appletouch - remove extra KERN_DEBUG use from dprintk

2010-10-31T14:16:00+00:00

Signed-off-by: Joe Perches 
Signed-off-by: Dmitry Torokhov

Revert "Input: appletouch - fix integer overflow issue"

2010-08-09T03:48:08+00:00

This reverts commit 04b4b88cca0ebe3813b4b6f014fb6a0db380b137.

While the original problem only caused a slight disturbance on the
edge of the touchpad, the commit above to "fix" it completely breaks
operation on some other models such as mine.

We'll sort this out separately, revert the patch for now.

Signed-off-by: Benjamin Herrenschmidt

USB: rename usb_buffer_alloc() and usb_buffer_free() users

2010-05-20T20:21:38+00:00

For more clearance what the functions actually do,

  usb_buffer_alloc() is renamed to usb_alloc_coherent()
  usb_buffer_free()  is renamed to usb_free_coherent()

They should only be used in code which really needs DMA coherency.

All call sites have been changed accordingly, except for staging
drivers.

Signed-off-by: Daniel Mack 
Cc: Alan Stern 
Cc: Pedro Ribeiro 
Signed-off-by: Greg Kroah-Hartman

Input: appletouch - fix integer overflow issue

2010-03-11T08:00:56+00:00

When reading data from Geyser 2 touchpads used on post Oct 2005 Apple
PowerBooks the driver was casting X and Y coordinates values to
'signed char'. Testing on one of such PowerBooks I have noticed that
touchpad always generates positive values, but some of them are greater
that 127, and thus, when cast to 'signed char' being interpreted as
a negative.

Such bigger values have been observed infrequently, closer to the
edges of a touchpad, so the problem was not very visible.
Nevertheless, the patch would potentially improve touchpad
driver accuracy.

Signed-off-by: Vadim Zaliva 
Signed-off-by: Dmitry Torokhov