linux-toradex.git/drivers/input/mouse/synaptics.c, branch v5.1-rc1

Input: synaptics - enable SMBus for HP EliteBook 840 G4

2018-12-21T09:09:17+00:00

dmesg reports that "Your touchpad (PNP: SYN3052 SYN0100 SYN0002 PNP0f13)
says it can support a different bus."

I've tested the offered psmouse.synaptics_intertouch=1 with 4.18.x and
4.19.x and it seems to work well. No problems seen with suspend/resume.

Also, it appears that RMI/SMBus mode is actually required for 3-4 finger
multitouch gestures to work -- otherwise they are not reported at all.

Information from dmesg in both modes:

  psmouse serio3: synaptics: Touchpad model: 1, fw: 8.2, id: 0x1e2b1,
      caps: 0xf00123/0x840300/0x2e800/0x0, board id: 3139, fw id: 2000742

  psmouse serio3: synaptics: Trying to set up SMBus access
  rmi4_smbus 6-002c: registering SMbus-connected sensor
  rmi4_f01 rmi4-00.fn01: found RMI device,
      manufacturer: Synaptics, product: TM3139-001, fw id: 2000742

Signed-off-by: Mantas Mikulėnas 
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Dmitry Torokhov

Input: synaptics - enable RMI on ThinkPad T560

2018-12-09T05:51:02+00:00

Before commit 7fd6d98b89f3 ("i2c: i801: Allow ACPI AML access I/O
ports not reserved for SMBus"), enabling RMI on the T560 would cause
the touchpad to stop working after resuming from suspend. Now that
this issue is fixed, RMI can be enabled safely and works fine.

Reviewed-by: Benjamin Tissoires 
Signed-off-by: Yussuf Khalil 
Signed-off-by: Dmitry Torokhov

Input: synaptics - enable SMBus for HP 15-ay000

2018-12-03T19:37:17+00:00

SMBus works fine for the touchpad with id SYN3221, used in the HP 15-ay000
series,

This device has been reported in these messages in the "linux-input"
mailing list:
* https://marc.info/?l=linux-input&m=152016683003369&w=2
* https://www.spinics.net/lists/linux-input/msg52525.html

Reported-by: Nitesh Debnath 
Reported-by: Teika Kazura 
Signed-off-by: Teika Kazura 
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Dmitry Torokhov

Input: synaptics - add PNP ID for ThinkPad P50 to SMBus

2018-12-03T19:37:17+00:00

Noticed the other day the trackpoint felt different on my P50, then
realized it was because rmi4 wasn't loading for this machine
automatically. Suspend/resume, hibernate, and everything else seem to
work perfectly fine on here.

Signed-off-by: Lyude Paul 
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov

Input: synaptics - avoid using uninitialized variable when probing

2018-10-19T17:40:12+00:00

synaptics_detect() does not check whether sending commands to the
device succeeds and instead relies on getting unique data from the
device. Let's make sure we seed entire buffer with zeroes to make sure
we will not use garbage on stack that just happen to be 0x47.

Reported-by: syzbot+13cb3b01d0784e4ffc3f@syzkaller.appspotmail.com
Reviewed-by: Benjamin Tissoires 
Reviewed-by: Peter Hutterer 
Signed-off-by: Dmitry Torokhov

Merge branch 'ib/4.17-xen-kbdfront-runtime-config' into next

2018-06-12T23:38:35+00:00

Bring in xen-kbdfront changes.

Input: psmouse-smbus - allow to control psmouse_deactivate

2018-05-23T23:49:22+00:00

This seems to be Synaptics specific, as some Elan touchpads are not
correctly switching to SMBus if we call deactivate before switching to
SMBus on cold boot and on resume.

Tested with the T480s

Signed-off-by: Benjamin Tissoires 
Acked-by: KT Liao 
Signed-off-by: Dmitry Torokhov

Input: synaptics - add Lenovo 80 series ids to SMBus

2018-05-23T18:47:04+00:00

This time, Lenovo decided to go with different pieces in its latest
series of Thinkpads.

For those we have been able to test:
- the T480 is using Synaptics with an IBM trackpoint
   -> it behaves properly with or without intertouch, there is no point
      not using RMI4
- the X1 Carbon 6th gen is using Synaptics with an IBM trackpoint
   -> the touchpad doesn't behave properly under PS/2 so we have to
      switch it to RMI4 if we do not want to have disappointed users
- the X280 is using Synaptics with an ALPS trackpoint
   -> the recent fixes in the trackpoint handling fixed it so upstream
      now works fine with or without RMI4, and there is no point not
      using RMI4
- the T480s is using an Elan touchpad, so that's a different story

Cc:  # v4.14.x, v4.15.x, v4.16.x
Signed-off-by: Benjamin Tissoires 
Acked-by: KT Liao 
Signed-off-by: Dmitry Torokhov

Input: synaptics - add Intertouch support on X1 Carbon 6th and X280

2018-05-23T18:46:42+00:00

Synaptics devices reported it has Intertouch support,
and it fails via PS/2 as following logs:

psmouse serio2: Failed to reset mouse on synaptics-pt/serio0
psmouse serio2: Failed to enable mouse on synaptics-pt/serio0

Set these new devices to use SMBus to fix this issue, then they report
SMBus version 3 is using, patch:
https://patchwork.kernel.org/patch/9989547/ enabled SMBus ver 3 and
makes synaptics devices work fine on SMBus mode.

Signed-off-by: Aaron Ma 
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov

Input: synaptics - Lenovo Thinkpad X1 Carbon G5 (2017) with Elantech trackpoints should use RMI

2018-05-23T18:45:50+00:00

Lenovo use two different trackpoints in the fifth generation Thinkpad X1
Carbon. Both are accessible over SMBUS/RMI but the pnpIDs are missing.
This patch is for the Elantech trackpoint specifically which also
reports SMB version 3 so rmi_smbus needs to be updated in order to
handle it.

For the record, I was not the first one to come up with this patch as it
has been floating around the internet for a while now. However, I have
spent significant time with testing and my efforts to find the original
author of the patch have been unsuccessful.

Signed-off-by: Edvard Holst 
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov