linux-toradex.git/drivers/input/mouse/synaptics_i2c.c, branch v5.14

Input: synaptics_i2c - remove redundant spinlock

2019-02-17T06:57:31+00:00

Remove a leftover spinlock.

This was required back when mod_delayed_work() did not exist, and had to
be implemented with a cancel + queue. See commit e7c2f967445d
("workqueue: use mod_delayed_work() instead of __cancel + queue")

schedule_delayed_work() and mod_delayed_work() can now be used
concurrently. So the spinlock is no longer needed.

Signed-off-by: Sven Van Asbroeck 
Signed-off-by: Dmitry Torokhov

Input: synaptics_i2c - add OF device ID table

2017-03-23T21:46:32+00:00

The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:.

But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.

Signed-off-by: Javier Martinez Canillas 
Signed-off-by: Dmitry Torokhov

Input: synaptics_i2c - change msleep to usleep_range for small msecs

2016-12-18T23:55:57+00:00

msleep(1~20) may not do what the caller intends, and will often sleep longer.
(~20 ms actual sleep for any value given in the 1~20ms range)
This is not the desired behaviour for many cases like device resume time,
device suspend time, device enable time, retry logic, etc.
Thus, change msleep to usleep_range for precise wakeups.

Signed-off-by: Aniroop Mathur 
Acked-by: Igor Grinberg 
Signed-off-by: Dmitry Torokhov

Input: drop owner assignment from i2c_driver

2015-07-17T23:57:00+00:00

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Dmitry Torokhov

Input: synaptics_i2c - use proper boolean values

2015-05-26T21:16:11+00:00

The variable no_decel is bool type so assigning "true" instead of "1".
Also, synaptics_i2c_get_input() has bool return type, so let's use "false"
there.

Signed-off-by: Shailendra Verma 
Signed-off-by: Dmitry Torokhov

Input: mouse - use __maybe_unused instead of ifdef around suspend/resume

2014-11-02T07:10:07+00:00

Use __maybe_unused instead of ifdef guards around suspend/resume
functions, in order to increase build coverage and fix build warnings.

Signed-off-by: Jingoo Han 
Signed-off-by: Dmitry Torokhov

Input: remove use of __devexit

2012-11-24T08:05:38+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton 
Acked-by: Mark Brown 
Signed-off-by: Dmitry Torokhov

Input: remove use of __devinit

2012-11-24T08:05:19+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Acked-by: Mark Brown 
Acked-by: Javier Martinez Canillas 
Signed-off-by: Dmitry Torokhov

Input: remove use of __devexit_p

2012-11-24T08:03:48+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton 
Acked-by: Russell King 
Signed-off-by: Dmitry Torokhov

workqueue: use mod_delayed_work() instead of __cancel + queue

2012-08-21T20:18:24+00:00

Now that mod_delayed_work() is safe to call from IRQ handlers,
__cancel_delayed_work() followed by queue_delayed_work() can be
replaced with mod_delayed_work().

Most conversions are straight-forward except for the following.

* net/core/link_watch.c: linkwatch_schedule_work() was doing a quite
  elaborate dancing around its delayed_work.  Collapse it such that
  linkwatch_work is queued for immediate execution if LW_URGENT and
  existing timer is kept otherwise.

Signed-off-by: Tejun Heo 
Cc: "David S. Miller" 
Cc: Tomi Valkeinen