linux-toradex.git/drivers/input/rmi4/rmi_spi.c, branch v4.14 Linux kernel for Apalis and Colibri modules Input: synaptics-rmi4 - when registering sensors do not call them "drivers" 2017-04-03T23:24:00+00:00 Dmitry Torokhov dmitry.torokhov@gmail.com 2017-03-24T21:21:44+00:00 54bf08946a4ba0567f6ec063f0e42b276c478bcf We are not registering drivers, but transport devices (AKA sensors), so let's call them that. Also let's rename "retval" to "error" in probe() functions as the variables are used to store error codes. Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
We are not registering drivers, but transport devices (AKA sensors), so
let's call them that.

Also let's rename "retval" to "error" in probe() functions as the variables
are used to store error codes.

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
 Merge branch 'synaptics-rmi4' into next 2016-12-16T05:36:09+00:00 Dmitry Torokhov dmitry.torokhov@gmail.com 2016-12-16T05:36:09+00:00 ebfb0184ef560897fad35005989e82433419202c Merge updated Synaptics RMI4 support, including support for SMBus controllers and flashing firmware. 
Merge updated Synaptics RMI4 support, including support for SMBus
controllers and flashing firmware.
Input: synaptics-rmi4 - move IRQ handling to rmi_driver 2016-11-09T01:12:05+00:00 Bjorn Andersson bjorn.andersson@linaro.org 2016-11-09T00:34:57+00:00 3aeed5b573f97b4525841cc07c1e948227af389f The attn IRQ is related to the chip, rather than the transport, so move all handling of interrupts to the core driver. This also makes sure that there are no races between interrupts and availability of the resources used by the core driver. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
The attn IRQ is related to the chip, rather than the transport, so move
all handling of interrupts to the core driver. This also makes sure that
there are no races between interrupts and availability of the resources
used by the core driver.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
 Input: synaptics-rmi4 - fix error handling in SPI transport driver 2016-10-04T18:52:23+00:00 Guenter Roeck linux@roeck-us.net 2016-10-04T18:48:55+00:00 bbc2ceeb3220e54c7574f0b5e3a252fd9a62cf8a Instantiating the rmi4 SPI transport driver without an interrupt assigned caused the driver to fail to load, but it does not clean up its transport device registration. Result may be a crash at a later time, for example when rebooting the system. Fixes: 8d99758dee31 ("Input: synaptics-rmi4 - add SPI transport driver") Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
Instantiating the rmi4 SPI transport driver without an interrupt assigned
caused the driver to fail to load, but it does not clean up its transport
device registration. Result may be a crash at a later time, for example
when rebooting the system.

Fixes: 8d99758dee31 ("Input: synaptics-rmi4 - add SPI transport driver")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
 Input: synaptics-rmi4 - add device tree support to the SPI transport driver 2016-03-11T00:04:25+00:00 Andrew Duggan aduggan@synaptics.com 2016-03-10T23:59:52+00:00 48147b9768b83265bf2e1211bcadeca035011380 Add devicetree binding for SPI devices. Signed-off-by: Andrew Duggan <aduggan@synaptics.com> Acked-by: Rob Herring <robh@kernel.org> Tested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Tested-by: Linus Walleij <linus.walleij@linaro.org> Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
Add devicetree binding for SPI devices.

Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
Acked-by: Rob Herring <robh@kernel.org>
Tested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Linus Walleij <linus.walleij@linaro.org>
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
 Input: synaptics-rmi4 - add SPI transport driver 2016-03-11T00:04:24+00:00 Andrew Duggan aduggan@synaptics.com 2016-03-10T23:58:12+00:00 8d99758dee31ff4a72bfc35d3a7a51fe66b7bb91 Add the transport driver for devices using RMI4 over SPI. Signed-off-by: Andrew Duggan <aduggan@synaptics.com> Tested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Tested-by: Linus Walleij <linus.walleij@linaro.org> Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
Add the transport driver for devices using RMI4 over SPI.

Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
Tested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Linus Walleij <linus.walleij@linaro.org>
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>