linux-toradex.git/drivers/input/serio/hp_sdc_mlc.c, branch v3.0.2

Input: serio HIL MLC - don't deref null, don't leak and return proper error

2010-11-20T21:38:18+00:00

While reviewing various users of kernel memory allocation functions I came
across drivers/input/serio/hil_mlc.c::hil_mlc_register() and noticed that:

 - it calls kzalloc() but fails to check for a NULL return before use.
 - it makes several allocations and if one fails it doesn't free the
   previous ones.
 - It doesn't return -ENOMEM in the failed memory allocation case (it just
   crashes).

This patch corrects all of the above and also reworks the only caller of
this function that I could find
(drivers/input/serio/hp_sdc_mlc.c::hp_sdc_mlc_out()) so that it now checks
the return value of hil_mlc_register() and properly propagates it on
failure and I also restructured the code to remove some labels and goto's
to make it, IMHO nicer to read.

Signed-off-by: Jesper Juhl 
Tested-by: Helge Deller 
Acked-by: Helge Deller 
Signed-off-by: Dmitry Torokhov

tree-wide: fix assorted typos all over the place

2009-12-04T14:39:55+00:00

That is "success", "unknown", "through", "performance", "[re|un]mapping"
, "access", "default", "reasonable", "[con]currently", "temperature"
, "channel", "[un]used", "application", "example","hierarchy", "therefore"
, "[over|under]flow", "contiguous", "threshold", "enough" and others.

Signed-off-by: André Goddard Rosa 
Signed-off-by: Jiri Kosina

parisc: hp_sdc_mlc.c - check return value of down_trylock()

2009-08-02T13:13:29+00:00

Signed-off-by: Helge Deller

Merge master.kernel.org:/pub/scm/linux/kernel/git/torvalds/linux-2.6 into next

2008-07-21T04:55:14+00:00

Input: hp_sdc_mlc.c - make a struct static

2008-06-30T13:38:33+00:00

This patch makes the needlessly global struct hp_sdc_mlc_priv_s static.

Signed-off-by: Adrian Bunk 
Signed-off-by: Dmitry Torokhov

m68k: Some input drivers do not check the platform

2008-05-18T20:28:49+00:00

Some input drivers do not check whether they're actually running on the
correct platform, causing multi-platform kernels to crash if they are not.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Linus Torvalds

Convert asm/semaphore.h users to linux/semaphore.h

2008-04-19T02:22:54+00:00

Signed-off-by: Matthew Wilcox

Input: HIL - fix rwlock recursion bug

2007-03-16T04:59:29+00:00

The following bug happens when insmoding hp_sdc_mlc.ko:

    HP SDC MLC: Registering the System Domain Controller's HIL MLC.
    BUG: rwlock recursion on CPU#0, hotplug/1814, 00854734
    Backtrace:
     [<10267560>] _raw_write_lock+0x50/0x88
     [<10104008>] _write_lock_irqsave+0x14/0x24
     [<008537d4>] hp_sdc_mlc_out+0x38/0x25c [hp_sdc_mlc]
     [<0084ebd8>] hilse_donode+0x308/0x470 [hil_mlc]
     [<0084ed80>] hil_mlcs_process+0x40/0x6c [hil_mlc]
     [<10130f80>] tasklet_action+0x78/0xb8
     [<10130cec>] __do_softirq+0x60/0xcc
     [<1010428c>] __lock_text_end+0x38/0x48
     [<10108348>] do_cpu_irq_mask+0xf0/0x11c
     [<1010b068>] intr_return+0x0/0xc

Signed-off-by: Helge Deller 
Signed-off-by: Dmitry Torokhov

Input: HIL - cleanup coding style

2007-03-01T04:51:29+00:00

Signed-off-by: Helge Deller 
Signed-off-by: Dmitry Torokhov

Input: HIL - various fixes for HIL drivers

2007-03-01T04:51:19+00:00

 - mark some structures const or __read_mostly
 - hilkbd.c: fix uninitialized spinlock in HIL keyboard driver
 - hil_mlc.c: use USEC_PER_SEC instead of 1000000
 - hp_sdc: bugfix for request_irq()/free_irq() parameters, this prevented
           multiple load/unload cycles as module

Signed-off-by: Helge Deller 
Signed-off-by: Dmitry Torokhov