linux-toradex.git/drivers/input/touchscreen/ar1021_i2c.c, branch v4.16-rc6

Input: ar1021_i2c - set INPUT_PROP_DIRECT

2017-11-03T19:47:33+00:00

If INPUT_PROP_DIRECT is set, userspace doesn't have to fall back to old
ways of identifying touchscreen devices. Let's add it.

Signed-off-by: Martin Kepplinger 
Signed-off-by: Dmitry Torokhov

Input: ar1021_i2c - use BIT to check for a bit

2017-05-01T19:30:00+00:00

The MSB for the first byte of touch data transmission is always 1. Make
it a little more obvious we're testing this bit by using BIT(7).

Signed-off-by: Martin Kepplinger 
Signed-off-by: Dmitry Torokhov

Input: ar1021_i2c - enable touch mode during open

2017-05-01T16:28:49+00:00

The device could as well be in command mode, in which this driver cannot
handle the device. When opening the device, let's make sure the device
will be in the mode we expect it to be for this driver.

Signed-off-by: Martin Kepplinger 
Signed-off-by: Dmitry Torokhov

Input: ar1021_i2c - highlight support for AR1020

2017-04-14T17:17:04+00:00

ar1021_i2c also supports the ar1020 device I'm using. This is tested.
They also share the same datasheet:

   http://ww1.microchip.com/downloads/en/DeviceDoc/40001393C.pdf

So let users see that they have a compatible in front of them by adding
AR1020 to the driver's description.

Signed-off-by: Martin Kepplinger 
Signed-off-by: Dmitry Torokhov

Input: ar1021_i2c - do not force raising edge IRQ trigger

2017-04-14T17:16:50+00:00

We should not be forcing edge triggered interrupt, but rather let platform
decide the kind of trigger it needs to use. Also, the driver is not quite
safe with regard to edge-triggered interrupts as it does not try to kick
the controller after requesting/enabling IRQ.

Reviewed-By: Christian Gmeiner 
Tested-by: Martin Kepplinger 
Signed-off-by: Dmitry Torokhov

Input: ar1021_i2c - fix too long name in driver's device table

2017-04-14T17:16:38+00:00

The name field in structure i2c_device_id is 20 characters, and we expect
it to be NULL-terminated, however we are trying to stuff it with 21 bytes
and thus NULL-terminator is lost. This causes issues when one creates
device with name "MICROCHIP_AR1021_I2C" as i2c core cuts off the last "C",
and automatic module loading by alias does not work as result.

The -I2C suffix in the device name is superfluous, we know what bus we are
dealing with, so let's drop it. Also, no other driver uses capitals, and
the manufacturer name is normally not included, except in very rare cases
of incompatible name collisions.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=116211
Fixes: dd4cae8bf166 ("Input: Add Microchip AR1021 i2c touchscreen")
Reviewed-By: Christian Gmeiner 
Tested-by: Martin Kepplinger 
Signed-off-by: Dmitry Torokhov

Input: ar1021_i2c - coding style fixes

2017-04-12T15:47:18+00:00

Use the common kernel coding style and corrently align parameters with
open parenthesis.

Signed-off-by: Martin Kepplinger 
Signed-off-by: Dmitry Torokhov

Input: ar1021_i2c - drop unnecessary call to i2c_set_clientdata

2017-01-18T19:33:05+00:00

There is no call to i2c_get_clientdata() or dev_get_drvdata().
Drop the unnecessary call to i2c_set_clientdata().

Signed-off-by: Guenter Roeck 
Signed-off-by: Dmitry Torokhov

Input: drop owner assignment from i2c_driver

2015-07-17T23:57:00+00:00

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Dmitry Torokhov

Input: constify of_device_id arrays

2015-03-19T19:16:18+00:00

of_device_id is always used as const argument (See driver.of_match_table
and open firmware functions).

Signed-off-by: Fabian Frederick 
Signed-off-by: Dmitry Torokhov