linux-toradex.git/drivers/input/touchscreen/tps6507x-ts.c, branch v6.2-rc3 Linux kernel for Apalis and Colibri modules Input: tps6507x-ts - remove variable loops 2022-10-24T12:18:55+00:00 Colin Ian King colin.i.king@gmail.com 2022-10-24T11:59:12+00:00 51de52c9db8225a2a170c9e5ae35ea8cf307dbac The variable loops is being incremented but is never referenced, it is redundant and can be removed. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Link: https://lore.kernel.org/r/20221020181642.24417-1-colin.i.king@gmail.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
The variable loops is being incremented but is never referenced,
it is redundant and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Link: https://lore.kernel.org/r/20221020181642.24417-1-colin.i.king@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Input: tsc6507x-ts - switch to using polled mode of input devices 2019-10-30T00:13:41+00:00 Dmitry Torokhov dmitry.torokhov@gmail.com 2019-10-29T23:50:47+00:00 7cca5a342ecd78ee163eaf352dc3995291b55406 We have added polled mode to the normal input devices with the intent of retiring input_polled_dev. This converts tsc6507x-ts driver to use the polling mode of standard input devices and removes dependency on INPUT_POLLDEV. Link: https://lore.kernel.org/r/20191017204217.106453-5-dmitry.torokhov@gmail.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
We have added polled mode to the normal input devices with the intent of
retiring input_polled_dev. This converts tsc6507x-ts driver to use the
polling mode of standard input devices and removes dependency on
INPUT_POLLDEV.

Link: https://lore.kernel.org/r/20191017204217.106453-5-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Input: tps6507x-ts - update to devm_* API 2017-03-15T22:44:49+00:00 Yegor Yefremov yegorslists@googlemail.com 2017-03-11T00:26:08+00:00 2e2a0db8c88d47123d3dd29d46eba12c26f71149 Update the code to use devm_* API so that driver core will manage resources. Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
Update the code to use devm_* API so that driver core will manage
resources.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
 Input: tps6507x-ts - simplify function return logic 2015-10-02T18:44:18+00:00 Javier Martinez Canillas javier@osg.samsung.com 2015-10-02T18:19:54+00:00 e5e66ed00ea555a4f66793b4be84ff99c9c7fa6e The invoked function already returns zero on success or a negative errno code so there is no need to open code the logic in the caller. This also fixes the following make coccicheck warning: drivers/input/touchscreen/tps6507x-ts.c:57:5-8: WARNING: end returns can be simplified Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
The invoked function already returns zero on success or a negative
errno code so there is no need to open code the logic in the caller.

This also fixes the following make coccicheck warning:

drivers/input/touchscreen/tps6507x-ts.c:57:5-8: WARNING: end returns can be simplified

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
 input: touchscreen: drop owner assignment from platform_drivers 2014-10-20T14:20:41+00:00 Wolfram Sang wsa@the-dreams.de 2014-10-20T14:20:41+00:00 7b8f16c2d1a81b29035379b471226ea09817a29c A platform_driver does not need to set an owner, it will be populated by the driver core. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> 
A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Input: tps6507x-ts - convert to polled input device infrastructure 2013-07-01T18:38:41+00:00 Dmitry Torokhov dmitry.torokhov@gmail.com 2013-04-15T18:11:00+00:00 5705b8aca5a80141de5637ff0e23b31b26f2c5bf There is no need to roll our own polling scheme when we already have one implemented by the core. Tested-by: Manish Badarkhe <badarkhe.manish@gmail.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
There is no need to roll our own polling scheme when we already have
one implemented by the core.

Tested-by: Manish Badarkhe <badarkhe.manish@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Input: tps6507x-ts - remove vref from platform data 2013-06-25T16:47:35+00:00 Dmitry Torokhov dmitry.torokhov@gmail.com 2013-04-15T18:05:54+00:00 22381288ba7fcb4d84cfba828dbca71c60d4ef79 Although defined in platform data, vref is not used anywhere. Also remove model, irq, and clear_penirq as they are not used either. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
Although defined in platform data, vref is not used anywhere.

Also remove model, irq, and clear_penirq as they are not used either.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Input: tps6507x-ts - use bool for booleans 2013-06-25T16:47:02+00:00 Dmitry Torokhov dmitry.torokhov@gmail.com 2013-04-15T18:01:21+00:00 02a71600df7805d80e4269684a75a0efc689657d Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Input: tps6507x-ts - remove bogus unreachable code 2013-06-25T16:46:44+00:00 Alan Cox alan@linux.intel.com 2012-11-03T19:16:12+00:00 04848ba829b3b740c7c9ae0c5916f90efaed0f5d tsc->polling is write only and the poll local is meaningless Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
tsc->polling is write only and the poll local is meaningless

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Input: remove use of __devexit 2012-11-24T08:05:38+00:00 Bill Pemberton wfp5p@virginia.edu 2012-11-24T05:50:47+00:00 e2619cf78e19476bfd7ceaefa9eff0847529346e CONFIG_HOTPLUG is going away as an option so __devexit is no longer needed. Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>