linux-toradex.git/drivers/iommu/omap-iommu-debug.c, branch v4.9.60

iommu/omap: Align code with open parenthesis

2016-04-05T15:53:20+00:00

This patch fixes one existing alignment checkpatch check
warning of the type "Alignment should match open parenthesis"
in the OMAP IOMMU debug source file.

Signed-off-by: Suman Anna 
Signed-off-by: Joerg Roedel

fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void

2015-09-11T22:21:34+00:00

The seq_ function return values were frequently misused.

See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
     seq_has_overflowed() and make public")

All uses of these return values have been removed, so convert the
return types to void.

Miscellanea:

o Move seq_put_decimal_ and seq_escape prototypes closer the
  other seq_vprintf prototypes
o Reorder seq_putc and seq_puts to return early on overflow
o Add argument names to seq_vprintf and seq_printf
o Update the seq_escape kernel-doc
o Convert a couple of leading spaces to tabs in seq_escape

Signed-off-by: Joe Perches 
Cc: Al Viro 
Cc: Steven Rostedt 
Cc: Mark Brown 
Cc: Stephen Rothwell 
Cc: Joerg Roedel 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

iommu/omap: Fix debug_read_tlb() to use seq_printf()

2015-08-03T15:23:41+00:00

The debug_read_tlb() uses the sprintf() functions directly on the buffer
allocated by buf = kmalloc(count), without taking into account the size
of the buffer, with the consequence corrupting the heap, depending on
the count requested by the user.

The patch fixes the issue replacing sprintf() by seq_printf().

Signed-off-by: Salva Peiró 
Signed-off-by: Joerg Roedel

iommu/omap: Remove trailing semi-colon from a macro

2015-08-03T14:04:26+00:00

Remove the trailing semi-colon in the DEBUG_FOPS_RO macro
definition. This fixes the checking warning,
    "WARNING: macros should not use a trailing semicolon"

Signed-off-by: Suman Anna 
Signed-off-by: Joerg Roedel

iommu/omap: Move debugfs functions to omap-iommu-debug.c

2015-08-03T14:03:50+00:00

The main OMAP IOMMU driver file has some helper functions used
by the OMAP IOMMU debugfs functionality, and there is already a
dedicated source file omap-iommu-debug.c dealing with these debugfs
routines. Move all these functions to the omap-iommu-debug.c file,
so that all the debugfs related routines are in one place.

The move required exposing some new functions and moving some
definitions to the internal omap-iommu.h header file.

Signed-off-by: Suman Anna 
Signed-off-by: Joerg Roedel

iommu/omap: Switch pagetable debugfs entry to use seq_file

2014-10-23T12:33:48+00:00

The debugfs entry 'pagetable' that shows the page table entry
(PTE) data currently outputs only data that can be fit into a
page. Switch the entry to use the seq_file interface so that
it can show all the valid page table entries.

The patch also corrected the output for L2 entries, and prints
the proper L2 PTE instead of the previous L1 page descriptor
pointer.

Signed-off-by: Suman Anna 
Acked-by: Laurent Pinchart 
Signed-off-by: Joerg Roedel

iommu/omap: Fix bus error on debugfs access of unattached IOMMU

2014-10-23T12:33:48+00:00

Any debugfs access on an OMAP IOMMU that is not enabled (done during
attach) results in a bus error due to access of registers without
the clock or the reset enabled for the respective IOMMU. So, add a
check to make sure the IOMMU is enabled/attached by a client device.
This gracefully prints a "Operation not permitted" trace when the
corresponding IOMMU is not enabled.

Signed-off-by: Suman Anna 
Acked-by: Laurent Pinchart 
Signed-off-by: Joerg Roedel

iommu/omap: Integrate omap-iommu-debug into omap-iommu

2014-10-23T12:33:16+00:00

The debugfs support for OMAP IOMMU is currently implemented
as a module, warranting certain OMAP-specific IOMMU API to
be exported. The OMAP IOMMU, when enabled, can only be built-in
into the kernel, so integrate the OMAP IOMMU debug module
into the OMAP IOMMU driver. This helps in eliminating the
need to export most of the current OMAP IOMMU API.

The following are the main changes:
- The debugfs directory and entry creation logic is reversed,
  the calls are invoked by the OMAP IOMMU driver now.
- The current iffy circular logic of adding IOMMU archdata
  to the IOMMU devices itself to get a pointer to the omap_iommu
  object in the debugfs support code is replaced by directly
  using the omap_iommu structure while creating the debugfs
  entries.
- The debugfs root directory is renamed from the generic name
  "iommu" to a specific name "omap_iommu".
- Unneeded headers have also been cleaned up while at this.
- There will no longer be a omap-iommu-debug.ko module after
  this patch.
- The OMAP_IOMMU_DEBUG Kconfig option is converted to boolean
  only, the OMAP IOMMU debugfs support is built alongside the
  OMAP IOMMU driver only when this option is enabled.

Signed-off-by: Suman Anna 
Acked-by: Laurent Pinchart 
Signed-off-by: Joerg Roedel

iommu/omap: Make pagetable debugfs entry read-only

2014-10-23T12:32:26+00:00

Remove the writeability on the 'pagetable' debugfs entry,
so that the mapping/unmapping into an OMAP IOMMU is only
limited to actual client devices/drivers at kernel-level.

Signed-off-by: Suman Anna 
Acked-by: Laurent Pinchart 
Signed-off-by: Joerg Roedel

iommu/omap: Fix the permissions on nr_tlb_entries

2014-10-23T12:32:25+00:00

The permissions on the debugfs entry "nr_tlb_entries" should
have been octal, not decimal, so fix it.

Signed-off-by: Suman Anna 
Acked-by: Laurent Pinchart 
Signed-off-by: Joerg Roedel