linux-toradex.git/drivers/iommu, branch v4.0.2

iommu/vt-d: Remove unused variable

2015-03-24T14:39:26+00:00

Unused after commit 71684406905f ("iommu/vt-d: Detach domain *only*
from attached iommus").  Reported by 0-day builder.

Signed-off-by: Alex Williamson 
Signed-off-by: Joerg Roedel

iommu: ipmmu-vmsa: Add terminating entry for ipmmu_of_ids

2015-03-23T14:22:09+00:00

The of_device_id table is supposed to be zero-terminated.

Signed-off-by: Axel Lin 
Acked-by: Laurent Pinchart 
Signed-off-by: Joerg Roedel

iommu/vt-d: Detach domain only from attached iommus

2015-03-23T14:22:08+00:00

Device domains never span IOMMU hardware units, which allows the
domain ID space for each IOMMU to be an independent address space.
Therefore we can have multiple, independent domains, each with the
same domain->id, but attached to different hardware units.  This is
also why we need to do a heavy-weight search for VM domains since
they can span multiple IOMMUs hardware units and we don't require a
single global ID to use for all hardware units.

Therefore, if we call iommu_detach_domain() across all active IOMMU
hardware units for a non-VM domain, the result is that we clear domain
IDs that are not associated with our domain, allowing them to be
re-allocated and causing apparent coherency issues when the device
cannot access IOVAs for the intended domain.

This bug was introduced in commit fb170fb4c548 ("iommu/vt-d: Introduce
helper functions to make code symmetric for readability"), but is
significantly exacerbated by the more recent commit 62c22167dd70
("iommu/vt-d: Fix dmar_domain leak in iommu_attach_device") which calls
domain_exit() more frequently to resolve a domain leak.

Fixes: fb170fb4c548 ("iommu/vt-d: Introduce helper functions to make code symmetric for readability")
Signed-off-by: Alex Williamson 
Cc: Jiang Liu 
Cc: stable@vger.kernel.org # v3.17+
Signed-off-by: Joerg Roedel

iommu/arm-smmu: fix ARM_SMMU_FEAT_TRANS_OPS condition

2015-03-23T14:21:26+00:00

This patch is a fix to "iommu/arm-smmu: add support for iova_to_phys
through ATS1PR".
According to ARM documentation, translation registers are optional even
in SMMUv1, so ID0_S1TS needs to be checked to verify their presence.
Also, we check that the domain is a stage-1 domain.

Signed-off-by: Baptiste Reynal 
Acked-by: Will Deacon 
Signed-off-by: Joerg Roedel

iommu/io-pgtable-arm: Add built time dependency

2015-03-03T13:04:12+00:00

If io-pgtable-arm is an ARM-specific driver then configuration option
IOMMU_IO_PGTABLE_LPAE should not be presented to the user by default
for non-ARM kernels.

Signed-off-by: Jean Delvare 
Cc: Will Deacon 
Cc: Joerg Roedel 
Acked-by: Will Deacon 
Signed-off-by: Joerg Roedel

iommu/msm: Mark driver BROKEN

2015-02-25T12:42:26+00:00

The MSM IOMMU driver unconditionally calls bus_set_iommu(), which is a
very stupid thing to do on multi-platform kernels. While marking the
driver BROKEN may seem a little extreme, there is no other way to make
the driver skip initialization. One of the problems is that it doesn't
have devicetree binding documentation and the driver doesn't contain a
struct of_device_id table either, so no way to check that it is indeed
valid to set up the IOMMU operations for this driver.

This fixes a problem on Tegra20 where the DRM driver will try to use the
obviously non-existent MSM IOMMU.

Marking the driver BROKEN shouldn't do any harm, since there aren't any
users currently. There is no struct of_device_id table, so the device
can't be instantiated from device tree, and I couldn't find any code
that would instantiate a matching platform_device either, so the driver
is effectively unused.

Reported-by: Nicolas Chauvet 
Cc: David Brown 
Cc: Daniel Walker 
Cc: Bryan Huntsman 
Cc: Olav Haugan 
Acked-by: Rob Clark 
Signed-off-by: Thierry Reding 
Signed-off-by: Joerg Roedel

iommu/rockchip: Play nice in multi-platform builds

2015-02-25T12:42:25+00:00

The Rockchip IOMMU driver unconditionally executes code and registers a
struct iommu_ops with the platform bus irrespective of whether it runs
on a Rockchip SoC or not. This causes problems in multi-platform kernels
where drivers for other SoCs will no longer be able to register their
own struct iommu_ops or even try to use a struct iommu_ops for an IOMMU
that obviously isn't there.

The smallest fix I could think of is to check for the existence of any
Rockchip IOMMU devices in the device tree and skip initialization
otherwise.

This fixes a problem on Tegra20 where the DRM driver will try to use the
obviously non-existent Rockchip IOMMU.

Reported-by: Nicolas Chauvet 
Cc: Heiko Stuebner 
Cc: Daniel Kurtz 
Reviewed-by: Heiko Stuebner 
Tested-by: Heiko Stuebner 
Signed-off-by: Thierry Reding 
Signed-off-by: Joerg Roedel

iommu/omap: Play nice in multi-platform builds

2015-02-25T12:41:33+00:00

The OMAP IOMMU driver unconditionally executes code and registers a
struct iommu_ops with the platform bus irrespective of whether it runs
on an OMAP SoC or not. This causes problems in multi-platform kernels
where drivers for other SoCs will no longer be able to register their
own struct iommu_ops or even try to use a struct iommu_ops for an IOMMU
that obviously isn't there.

The smallest fix I could think of is to check for the existence of any
OMAP IOMMU devices in the device tree and skip initialization otherwise.

This fixes a problem on Tegra20 where the DRM driver will try to use the
obviously non-existent OMAP IOMMU.

Reported-by: Nicolas Chauvet 
Cc: Tony Lindgren 
Cc: Suman Anna 
Cc: Laurent Pinchart 
Signed-off-by: Thierry Reding 
Acked-by: Laurent Pinchart 
Signed-off-by: Joerg Roedel

iommu/exynos: Play nice in multi-platform builds

2015-02-25T12:40:52+00:00

The Exynos System MMU driver unconditionally executes code and registers
a struct iommu_ops with the platform bus irrespective of whether it runs
on an Exynos SoC or not. This causes problems in multi-platform kernels
where drivers for other SoCs will no longer be able to register their
own struct iommu_ops or even try to use a struct iommu_ops for an IOMMU
that obviously isn't there.

The smallest fix I could think of is to check for the existence of any
Exynos System MMU devices in the device tree and skip initialization
otherwise.

This fixes a problem on Tegra20 where the DRM driver will try to use the
obviously non-existent Exynos System MMU.

Reported-by: Nicolas Chauvet 
Cc: Kukjin Kim 
Signed-off-by: Thierry Reding 
Signed-off-by: Joerg Roedel

iommu/io-pgtable-arm: Fix self-test WARNs on i386

2015-02-25T12:37:32+00:00

Various build/boot bots have reported WARNs being triggered by the ARM
iopgtable LPAE self-tests on i386 machines.

This boils down to two instances of right-shifting a 32-bit unsigned
long (i.e. an iova) by more than the size of the type. On 32-bit ARM,
this happens to give us zero, hence my testing didn't catch this
earlier.

This patch fixes the issue by using DIV_ROUND_UP and explicit case to
to avoid the erroneous shifts.

Reported-by: Fengguang Wu 
Reported-by: Huang Ying 
Signed-off-by: Will Deacon 
Signed-off-by: Joerg Roedel